From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=bBq6mpkE; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by mail.toke.dk (Postfix) with ESMTPS id 73A9C14D9773 for ; Thu, 20 Aug 2026 17:45:15 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-495590dde14so28280965e9.0 for ; Thu, 20 Aug 2026 08:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787240714; x=1787845514; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=a1eX4DFVYT+BZd7oT7NYu1d4HaTZbGISixdfKYs3hNE=; b=bBq6mpkE02r+cgzHQlaKNTcuVYP6IuUlpQNF2xtQ2gfiES3h0OLOdbE+PhfDvsdZ7O QnFuyVZuOT05urvzQ0nfmFRYgN7XsFckdLxeeQVdC30nVNMiS0Awvgc1OdF1+q4iOVY2 oo0EL+oEBY8ezZH+si7EqE6FkrwgMilVug1o69Mj3CjiS9RuDKr3iXlHdbA4InkhqnZP FUy6qLwzCQwcol9o/CYqBCMRDzKoeUBZ2Xm5PNBxTLeRBQ9iLdL356IznOYYRZ9CwwXy UZOZFhyQbD1lUDg1qYanqszTCkvmYidXFhAIxC2ZfYz3amAAeFA/5s/cokqFq+M59a+6 GczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787240714; x=1787845514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a1eX4DFVYT+BZd7oT7NYu1d4HaTZbGISixdfKYs3hNE=; b=o39nzinfaGqXHYK9otQPLjggnZuypNAVUw4d2KrnlWKtYO87X8LY837Y8hhxxCSkYt 8B+a70EZvxkHuGy546h4CLVRio/eElVsnJpuAQ8QPo3HpOQhPhYd1X7gaJIoZ01KqRhN 0+ReBFDFgikKIP5tT9Ev6dGVZU0GKsWQnEEyrS1RMSGUskqE5PkEDH+YVrOysNoq8jRT rbmfjQ1sfZW1EZSQPpmtmNlqM2KiZhTwdZ/FsHwXyjP0DNESBwg3rh2IV+rwXPWhVNUi M1I2nP2jErWmekRE1iDt+J1+IBLoD8ng3jqBFvCGDM/Q/DdeuMuGiSG4zB2BXKZGaHLq qm3g== X-Forwarded-Encrypted: i=1; AHgh+RoJoL5ILHcegbMV3YuOJnb2DYOBpfd7ntZZLFYVWI3xh8rLG0ZNeKeNknUTUmMlzsCkl4co@lists.bufferbloat.net X-Gm-Message-State: AOJu0YydgOyBsa9A0r/O2D6IFDEoEg1KJD0211zz0wBgcf5y6eRJYwQ/ 0GEJ5l5U2JJrc3WH4YYhmdLQ8g9I5bsdbLRIYAJStyNksz/UJ+pJnFZg+s/VyZseldM= X-Gm-Gg: AR+sD11AtGsHUU89aWLohVXRWc5pWWmM4sqZG2EVA6oZRJHKwfqpAuFFc7fNNLx7Wke wQJSNnAPLSjfC3hTyq6ZZdv6ISAHpiDwtI8iOuJWG9vl0KPvr1a0o2BNLt6OpdV77vfJ08wCLkv vNpGsVzwh5ZKkpf7/KCxx0yNzhkUuAX1bjSjMCBPe+Nh7qcwi4vjNNWBsPev7cIGS2B+k8AhrZ9 kQKMMKov88WnIRVw5C9kauEZDDJWKJg+aaZg1Moa+Y6lzHTNDBzaGOkuqHMlPzysKfFD5ybrO1s FU8IiPBxlzht1PFdR0HvuAfx9WNbP5veHDhh37z6M3lX+B2XPnKISbNyFG0uBVp/nQYYQgcuxkq HIhwGEOQwXLbtgIkdHAI/6ewI+qEVrqhCOkF0UG1o5xaunPDXtgiBZFLwuaWZ8LG9zw6MDAAEm/ ndsDmr6zM1WPXJQa0AwHnu5th3gRJMD3odM/BjIJoLxH06DgskRWD8Eq204NDMMMQD0UD7FSGo X-Received: by 2002:a05:600c:8a1a:10b0:499:b001:b8d4 with SMTP id 5b1f17b1804b1-499b001b8e1mr129153565e9.5.1787240713825; Thu, 20 Aug 2026 08:45:13 -0700 (PDT) Received: from unicorn.lan.internal ([2a0d:3341:b894:4600:ea33:29d5:6d76:8b36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b1450fb9sm13444652f8f.14.2026.08.20.08.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 08:45:13 -0700 (PDT) From: Giuseppe Piscitelli To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 20 Aug 2026 17:45:03 +0200 Message-ID: <20260820154503.892214-1-ooonea@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MailFrom: ooonea@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: HMN76SH3M6Z7P3EJVCYEU7GJIKIGHVQZ X-Message-ID-Hash: HMN76SH3M6Z7P3EJVCYEU7GJIKIGHVQZ X-Mailman-Approved-At: Thu, 20 Aug 2026 17:49:18 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] [PATCH net v3] net/sched: sch_cake: fix autorate reconfiguration throttling List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: CAKE's autorate-ingress path intends to limit shaper reconfiguration to once per 250 ms, but last_reconfig_time is only checked and never updated. Since the field stays zero, every qualifying capacity-estimate window can call cake_reconfigure(), causing avoidable rate churn and scheduler work under bursty traffic. Store the current timestamp when autorate actually reconfigures the qdisc so the guard enforces the intended interval. Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") Assisted-by: Codex:gpt-5.5 Signed-off-by: Giuseppe Piscitelli --- v3: resend via git send-email; v2 went out through a mail client that mangled whitespace and does not apply v2: spell out my full name in From/Signed-off-by (Paolo Abeni) net/sched/sch_cake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index f25f60978..dc9326702 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ktime_add_ms(q->last_reconfig_time, 250))) { q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4; + q->last_reconfig_time = now; cake_reconfigure(sch); } } base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b -- 2.54.0