From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=JvqTUeEs; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine
Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25])
	by mail.toke.dk (Postfix) with ESMTPS id E6562176EEE9
	for <cake@lists.bufferbloat.net>; Tue, 06 Oct 2026 17:30:50 +0200 (CEST)
Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18])
	by tor.source.kernel.org (Postfix) with ESMTP id D3B61601E4;
	Tue,  6 Oct 2026 15:30:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45CDC1F0089B;
	Tue,  6 Oct 2026 15:30:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1791300648;
	bh=auABOYcQ94uUoT7JSgrvfzqh9UYMOH31EMmDcgigAMo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=JvqTUeEsF5pdT1EZns112KUPZ5rdfER0JzNDhJ74xmnTAYJo0Pu40wzSqUavteccG
	 WpH3RrF2CwcRgNF9plMo7J0TJbj8TxaAjdYeQnPzPT81tAmrpmbjN+wgcztH+04ws9
	 3NMPzjKiT5AD3YTFrXlaHxytl0GRijYTiJUf1hVHknSyRjqSnGpVbVuei8hB8w1o7k
	 bdzsMBNZp6JjTgBEVNVdDFSAjXX4dl7/VwijuVHfGy93M/l9IyzXB8s/B38C+TNiVN
	 4fJmlI4s7acMN554hS2VrjiqQcKv57Y35b7ymVc4etlxYI8Fkql6Aj3kbZ5+nsNd/i
	 8ToPo2vqTItOA==
From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Victor Nogueira <victor@mojatatu.com>,
	Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
	moeller0@gmx.de, cake@lists.bufferbloat.net,
	Sashiko <sashiko-bot@kernel.org>
Message-ID: <20261006153043.GM83879@horms.kernel.org>
References: <QDISC-BA27.v4.20261001193440@mojatatu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <QDISC-BA27.v4.20261001193440@mojatatu.com>
X-MailFrom: horms@kernel.org
X-Mailman-Rule-Hits: nonmember-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation
Message-ID-Hash: JS3ZNSD7LT6REMWI2BUAWHLNDI5CLIVF
X-Message-ID-Hash: JS3ZNSD7LT6REMWI2BUAWHLNDI5CLIVF
X-Mailman-Approved-At: Thu, 08 Oct 2026 16:45:13 +0200
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [Cake] Re: [PATCH net-next v4] net/sched: cap the accounted backlog before it can wrap
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
Archived-At: <https://lists.bufferbloat.net/cake/20261006153043.GM83879@horms.kernel.org/>
List-Archive: <https://lists.bufferbloat.net/cake/>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Owner: <mailto:cake-owner@lists.bufferbloat.net>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Subscribe: <mailto:cake-join@lists.bufferbloat.net>
List-Unsubscribe: <mailto:cake-leave@lists.bufferbloat.net>
Date: Tue, 06 Oct 2026 15:30:51 
X-Original-Date: Tue, 6 Oct 2026 16:30:43 +0100

On Fri, Oct 02, 2026 at 03:44:31AM -0400, Jamal Hadi Salim wrote:

...

> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c

...

> @@ -1712,18 +1738,24 @@ static struct cake_tin_data *cake_select_tin(struct Qdisc *sch,
>  	return &qd->tins[tin];
>  }
>  
> -static u32 cake_classify(struct Qdisc *sch, struct cake_tin_data **t,
> -			 struct sk_buff *skb, int flow_mode, int *qerr)
> +/* Run the optional external classifier. Returns true when the packet was
> + * consumed by a terminal TC action (reason in *qerr); else *flow/*host

FYI:

W=1 builds complain that the line above has a '/*' embedded in a comment.
This is likely why Sashiko NIPA didn't run for this series.

...