From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=bV1J2kH7; arc=none (Message is not ARC signed); dmarc=fail (Used From Domain Record) header.from=networkplumber.org policy.dmarc=quarantine Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by mail.toke.dk (Postfix) with ESMTPS id CF9E11792988 for ; Thu, 08 Oct 2026 17:23:51 +0200 (CEST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-cc751eddf25so1820088a12.3 for ; Thu, 08 Oct 2026 08:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1791473029; x=1792077829; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HFpZNzJ7hMF7uOeDE/y2phCur9YgPkP3RKc91yp0O2I=; b=bV1J2kH7SbUUrFOWyEQXBisOMXPJxi1EWqklV+qP4rVIsK1hQRTBC9MXOTSiPylkDx d6k7kJ4aJ/kwGptnNWtrABQr3ixuiEFemjja/SZ+tDcsXhH6FYaPQFQiWUhjKHcwKnz6 EHwSuPrK0P8hd8PrtnXomfUoSA6HkjRim6BdsWgpH98rRreSF+dEVyFBM2Jm/x8MbGP5 aquBIgfB6e8CIlKlTvS8H7HQJVaTpXuFIIKQm4sGUK7+wJftstyhXeElcJvDWCe1eVl2 jLqvXcfUjuDxBnG6VUPKvKiZNIdK7YKiE3Wj1u1DQF1jInGhsFHoZCp1DSQX2/u/IvP4 56fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791473029; x=1792077829; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HFpZNzJ7hMF7uOeDE/y2phCur9YgPkP3RKc91yp0O2I=; b=EvBIQ5JXYAssw57y47zmWnRvxejCIK9+f2jhDCsKjiWdNwrML1ght07VQjXxrbP5b7 6Xt5QJNlho5sMRpZcK8KDuvQ0hbLI/Sm4zLmlxSwbLLauaz461jPC1Ihkub5ASriDvTr e+U4bmPhkwAwl2hiqCRuDrnqisP904by4PELXEc1AmptzSBAYRPiKMRoLRkFti9/N6T5 75SRQ0aoefYjf4PA5Qk9dfTAZYBtCym6zezOiuwRNfodmEdqTW1jlp5sb2MqDoj8L4Mf +9WKfvGXl9TqssWgcX9kngiQdeUuUca+bCO/To2VYU2iCM2rf7E5M1LWHPctYJcTQUmV bHYg== X-Forwarded-Encrypted: i=1; AKwUvBxexhEsPri/iyq/UmJNmW+D7ZxkP5UnfpsAZnUKFlHWYl2d5GjnsSFzX0IB+nf0p0ourgGd@lists.bufferbloat.net X-Gm-Message-State: AFq9FYL9LlYPgmf/gAAjE3P0Of1netE5D33OyK1J8pBtGev8nG49/zug avQ1aKjeg/rRU3Eye4t39GHBPVcYFOaOK4AHyGRO2PTdZReyJuw5P6CxnUTxrkkBSGM= X-Gm-Gg: AYBFou22CBf3RGJp+gr4TaYbIOWLDxnhkEcyoD4QUhZVeBKwvGjdRvO4V5pfTwWQg0u Zx1fQFLeu2nQAWd0VkSUcqlfv4NFAZlxdzjycvlrhLIj/4+3d3RyqsQEwrD4qJM7tv+SNapBcbr nvHtVaxVLqiHSDCBSOsMp2b+1VFlPdFSdMdlsFg5zM64Js5WVZm8/R3Ir0TkfC3dx+lIthm+a8e y0aP2BBYOoGeioSAxntxp6JJNOZhozJ9uMPVTiQYVB8KNmRItUmP8HAgRk8eiiMbx4eqADUnruT CNpapOjAEuKBmKZvYT6W/RjO+Bn8bDvVE7l6BqG801eexYKk8Cc5CuxGCwzJ7jVvBwt7gFKEUwy ziv1UBiFdWaIrw2d76YfLkXmfWlJuWrK53+Rk2Fmbss0IJ3E2xa9C6xa+Whdz4yrANCsujzuc2+ Axog9d1jyzziOCfDLpR5pnWpMx+UF58ObAi9+mgYQBvb5Iv0Lx0nEeiITpZL+aaLmKB61eCu8oz NTEWNSuHM6y2U+rglB5mOI+suznk6qQy6i+LvVc X-Received: by 2002:a17:90b:5486:b0:3a4:9c30:425 with SMTP id 98e67ed59e1d1-3a8a117a9e4mr4971001a91.44.1791473029071; Thu, 08 Oct 2026 08:23:49 -0700 (PDT) Received: from phoenix.local (204-195-112-43.wavecable.com. [204.195.112.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a9f1a2d9aasm4520225a91.4.2026.10.08.08.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 08:23:48 -0700 (PDT) Date: Thu, 8 Oct 2026 08:23:45 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: Jamal Hadi Salim , netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , moeller0@gmx.de, cake@lists.bufferbloat.net, Sashiko Message-ID: <20261008082345.5e16ca44@phoenix.local> In-Reply-To: <87pkxks68f.fsf@toke.dk> References: <87a4oottcj.fsf@toke.dk> <87pkxks68f.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2BR5ASNSTGAQITB7VXET7Z4BDJWRYFFS X-Message-ID-Hash: 2BR5ASNSTGAQITB7VXET7Z4BDJWRYFFS X-MailFrom: stephen@networkplumber.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v5] net/sched: cap the accounted backlog before it can wrap List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 08 Oct 2026 14:54:08 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> =20 > >> > +/* Compute the flow/host hash keys from the packet as received. Mus= t run > >> > + * before skb_gso_segment(), which rewrites an encapsulated GSO pac= ket's > >> > + * headers to the inner ones and would change the keys. Reads only = the skb > >> > + * and commits no qdisc state, so it may run before admission is kn= own. > >> > + */ =20 > >> > >> And drop the weird LLM comments, please. If you split the series > >> properly they are not needed. > >> =20 > > > > Like I said, it's a dilemma. =20 >=20 > See above. As heavy LLM user, I often have to tell it. "Thats good, now rewrite the commit and comments for humans. Make the result conform to the style of other places in the same code"