From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 18F793CB35 for ; Mon, 7 Jan 2019 03:20:47 -0500 (EST) Received: by mail-lj1-x22e.google.com with SMTP id t9-v6so37343760ljh.6 for ; Mon, 07 Jan 2019 00:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8hP2+hk+fyZuEP23CIt3HlHfMSSk7OH0TW8ks/oXtNo=; b=M9+pw5VjUy72S3M6ILKRyijPfvEp1Yd7OW2M9JymS6gMV6QI1OCb5v8DBLpzxlKXW/ agkmgiTRelMGbRBn5Hh/RXRs7Mg1F92VurJm2mXt224mpHP8AaIAfr0IOefIAN5RTfVB noc320QjkmnIEKIg0TdfqV2knb/A3Js81odTAwzzDX0cHxq4tei1gFR049oQSB4wgJYc I54y+k9bxzTETiby7pGu66XYIThEmorpy7jftZSqkvz/Fm8C2BAMq7tvFidsIIh67nA3 fn4CB/QjWZzj7ibohIskgHQv/MHm1hw05FxeflEgnveVHlI48I8x6sF45LARB3oMIkeo wAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8hP2+hk+fyZuEP23CIt3HlHfMSSk7OH0TW8ks/oXtNo=; b=Ps47Zg3l9E76pesqe1dcQ7fGCglCn7WQnKLoqIB/rYbo5AH5PuJA/0cKqGQYe1F2Pb yLzpjzZvJXypWsnqpFI39vvCXBCeaEiTKxEDlKzeLstjdCbxTiPcC9vCczP0aGpGbx58 Ape+N3BLsqn0uc7eiggluZrdfHLJWbkP1/nNgEVp+lXAOqaOssob+8v+UZMNknvQk91I arvdWtjuS/ZzaYADUn6cFbN4gp/u3cysD2bYq7EwrsdGLucw2TN9+ooM3I/DSmmkOLdx Gzf6al63ZauqAjVEbqwkimpN2KdiSvP3QWspxtYBmnlTiCmAdZAS1Y1ZqeaOoeS6Gb/l mORA== X-Gm-Message-State: AJcUukeMuEfwo0+/BLifwCfTIqU29S43GjG20Vfa+LYNxo8Ad3AyxDBY 48yP5fUnt42g9ZkPCmK9aMA= X-Google-Smtp-Source: ALg8bN6yTSmbd8RaHG5kI/gAxTVxispqqhG+YU4JHygj77/OR9/+Stc5lHSSTqnbaeOYqsc+L60+vQ== X-Received: by 2002:a2e:97d7:: with SMTP id m23-v6mr9886144ljj.18.1546849245851; Mon, 07 Jan 2019 00:20:45 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-238-230-nat-p.elisa-mobile.fi. [83.245.238.230]) by smtp.gmail.com with ESMTPSA id c20sm12327010lfj.67.2019.01.07.00.20.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 00:20:45 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: <008901d4a63d$7d054420$770fcc60$@gmail.com> Date: Mon, 7 Jan 2019 10:20:43 +0200 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <2EEF29A5-9038-478E-B23F-9C5B64A09B81@gmail.com> References: <008901d4a63d$7d054420$770fcc60$@gmail.com> To: Georgios Amanakis X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] host hashes and NAT neglected in src/dst-host mode X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 08:20:47 -0000 > On 7 Jan, 2019, at 6:00 am, = wrote: >=20 > 633 if ((flow_override || !(flow_mode & CAKE_FLOW_FLOWS)) && > 634 (host_override || !(flow_mode & CAKE_FLOW_HOSTS))) > 635 goto skip_hash; These lines require careful reading. First, the "override" flags indicate whether an external filter has = changed the flow or host hashes, meaning we should not then update them = ourselves. Secondly, the logic is "if we *don't* need the flow hash *and* we = *don't* need the host hash, then skip the complicated hash code". In the dual and triple modes, both the flow and host hashes are = required, and bit-level examination of the codes used to identify them = should reflect that. In "flows" and "host" modes, only one or the other = are needed, but they will still disable the above check (unless an = external filter was used). In short, only "flowblind" mode or the use of external filters are = capable of skipping that block. - Jonathan Morton