From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from webmail.newmedia-net.de (smtps.newmedia-net.de [IPv6:2a05:a1c0:0:de::167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 237133B2A4 for ; Thu, 16 Jan 2020 07:48:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newmedia-net.de; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=8BWhv5XqVjyUqRNK8laGmZTkph0L+g3khAoqdy1/5J8=; b=oCVcvLJM2HvimLfs3COsDlWWKnJ23BXUzNjteWgGJ5GLYg6i5XuInDqk/vYh0SrVQc9oJjg7dnPhR77TtsFgWGNnpzU//gcDlZ9fuv4cYhFT0918WnTurlqLtWsozVAo2O09Hl2ler/dD4gXJsgApQdvJ0/IPNwZaN3Q12Fc360=; To: cake@lists.bufferbloat.net References: <1578730684729@kroah.com> <13E6E54B-BCF8-44C7-9E0F-55127DB9A42C@darbyshire-bryant.me.uk> From: Sebastian Gottschall Message-ID: <2c75f117-30de-8d79-1637-f9a155c38e7a@newmedia-net.de> Date: Thu, 16 Jan 2020 13:47:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Received: from [2a01:7700:8040:300:853d:6c61:95c4:6bb4] by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1is4XF-0000Xq-P1 for cake@lists.bufferbloat.net; Thu, 16 Jan 2020 13:46:10 +0100 Subject: Re: [Cake] Patch "sch_cake: avoid possible divide by zero in cake_enqueue()" has been added to the 4.19-stable tree X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 12:48:09 -0000 dd-wrt has it already :-) Am 11.01.2020 um 22:38 schrieb Dave Taht: > Thank you for all the gymnastics to keep cake alive in openwrt. > > I would still like there to be a sce branch of the out of tree work > that I could point people at > in my lca talk this week, but I understand that's increasingly difficult. > > On Sat, Jan 11, 2020 at 1:20 PM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> >>> On 11 Jan 2020, at 20:40, Dave Taht wrote: >>> >>> did this make it into openwrt already? >> It’s complicated and it depends what you mean by openwrt. >> >> First off, the fix relates to auto-bandwith mode or whatever it’s called and I don’t think many people use it. Nonetheless: >> >> Is the fix in ’net-next’: yes >> Is the fix in 4.19 stable: In the queue for 4.19.95 >> >> Is openwrt on 4.19.95: No >> Does openwrt use the in-tree version of Cake?: No >> >> Is the fix in the Out-Of-Tree cake git repo: Yes >> >> Has the openwrt CAKE package been bumped to follow cake git repo?: master, yes, as of 2020/01/11 (earlier today) >> >> OpenWrt 19.07 has just been released, its concept of cake package has not been bumped. Neither has 18.06. >> >> >> It is worth noting that until yesterday/recently the out of tree cake repo had residue in it from some experimental stuff (SCE & updating conntrack marks) and did not represent upstream in-tree CAKE anyway. That situation was corrected AFAIK completely this morning. >> >> Ideally I would like openwrt to use the in-tree CAKE, with ‘feature backports’ from later kernels as backport patches. Unfortunately some targets in openwrt are still on 4.14 kernels so there is no in-tree CAKE to use. Dropping CAKE from pre 4.19 kernels caused a bit of an outcry when I did it, so the next idea was to have a choice of cake kernel module for K4.19 targets, in-tree & out-of-tree CAKE. Unfortunately that exposed a weakness in package dependency selection, so that idea hasn’t flown either. I’m afraid enthusiasm levels then dropped. >> >> >