Re: [Cake] new patchset for upstream net-next

[George Amanakis <gamanakis@gmail.com>]

grep'ing in net-next for nf_ct_get_tuplepr reveals these are still in use.


On 11/25/2017 7:49 PM, George Amanakis wrote:
> I tried Kevin's latest commit, now it fails with:
>
>   CHK     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   DESCEND  objtool
>   CHK     include/generated/utsrelease.h
>   CHK     scripts/mod/devicetable-offsets.h
>   CHK     include/generated/bounds.h
>   CHK     include/generated/timeconst.h
>   CHK     include/generated/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CHK     kernel/config_data.h
>   GEN     .version
>   CHK     include/generated/compile.h
>   UPD     include/generated/compile.h
>   CC      init/version.o
>   AR      init/built-in.o
>   AR      built-in.o
>   LD      vmlinux.o
>   MODPOST vmlinux.o
> net/sched/sch_cake.o: In function `cake_hash':
> sch_cake.c:(.text+0x23d0): undefined reference to `nf_ct_get_tuplepr'
> sch_cake.c:(.text+0x23f3): undefined reference to `nf_conntrack_find_get'
> make: *** [Makefile:993: vmlinux] Error 1
>
> Everything is selected (Y or M) under "Core Netfilter Configuration". 
> Are these functions deprecated in net-next?
>
> George
>
>
> On 11/25/2017 4:42 PM, Dave Taht wrote:
>> bad merge. darn it.
>>
>> On Sat, Nov 25, 2017 at 11:57 AM, George Amanakis 
>> <gamanakis@gmail.com> wrote:
>>> After correcting this, it fails with:
>>>
>>>    CHK     include/config/kernel.release
>>>    CHK     include/generated/uapi/linux/version.h
>>>    DESCEND  objtool
>>>    CHK     include/generated/utsrelease.h
>>>    CHK     scripts/mod/devicetable-offsets.h
>>>    CHK     include/generated/bounds.h
>>>    CHK     include/generated/timeconst.h
>>>    CHK     include/generated/asm-offsets.h
>>>    CALL    scripts/checksyscalls.sh
>>>    CHK     include/generated/compile.h
>>>    CHK     kernel/config_data.h
>>>    CC      net/sched/sch_cake.o
>>> net/sched/sch_cake.c: In function ‘cake_hash’:
>>> net/sched/sch_cake.c:746:7: error: ‘allocate_host’ undeclared (first 
>>> use in
>>> this function); did you mean ‘allocate_dst’?
>>>     if (allocate_host) {
>>>         ^~~~~~~~~~~~~
>>>         allocate_dst
>>> net/sched/sch_cake.c:746:7: note: each undeclared identifier is 
>>> reported
>>> only once for each function it appears in
>>> make[2]: *** [scripts/Makefile.build:310: net/sched/sch_cake.o] Error 1
>>> make[1]: *** [scripts/Makefile.build:569: net/sched] Error 2
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1012: net] Error 2
>>> make: *** Waiting for unfinished jobs....
>>> ==> ERROR: A failure occurred in build().
>>>      Aborting...
>>>
>>> George
>>
>>
>