From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0B1C93B29E for ; Sat, 25 Nov 2017 19:51:38 -0500 (EST) Received: by mail-qk0-x22f.google.com with SMTP id b85so28469165qkc.13 for ; Sat, 25 Nov 2017 16:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=6qnccef8c7YynatmDeaCZqWZ3XHkyUjqVEUiYdeClrE=; b=c2LLCNvPULW9Yi6bMMst0oGEsC5y658y269FVDc+7qx/QplW43aAJ0fCgSt+hxoEp1 iZn7kVjI3ByEOUPnGmwCmD1ye2Sf452ZsTUScNbqWfekTZ3lTbRhniFSmYCwgRw45IC7 Qo6YDQFr2g9YQy4UxruqosC7+wF0/aArGwfaKzcOEHaXL1zui2VSxkx2qXXDHMLprY/0 oNKDyCCfHRJRAj6JMx8cabWaV0Zsztj75k0vC4x9w4wrBCItYt5Vo0DSygLSEZk2HL57 qSFyyWfkuf6yGu/qMw7xfINIBO40xqJ1hvmOtVPz4ukDWW5zK/CsLuGrplYRjuKYGAXC 6wcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6qnccef8c7YynatmDeaCZqWZ3XHkyUjqVEUiYdeClrE=; b=S6OST2ei57umz2Pu0kX2ZHCdy1NLSMoUCY2LR3Te+GSl5UOpkSLMKTcjwoRT6JTKeV IMZry7/Gkdpk2pQC3v66mVsHYDboFupYrLr3ZTY7bdv4DhZuad/iOg10kLg8nCCcfQAs W1L/nW8M8wxjbjabWaiW2Zbn68cq17uh7Doq95w2+YYBOmkXTNxe0ysRocH74P45l7lP CYbqmnePKK5NVeA3/l+4RD13Wyollb7+PDFhR9BQHU6P3PoUXZt4LodGEW0ANkH9oLb7 U0Ngnm4b4qTTFPoWcVPh/KtqfLaAhmlu3msxf3ug2F34L5QXAhv/3lVnV2Lj3/r9FqnK Bp3g== X-Gm-Message-State: AJaThX4aNT72i0v1+S4xu23KNRRguFn8FUZ/yIoZVcX6SSWDlWv+o/GQ nwyxmVl17vdjiFjYhZ7BGKFMijvU X-Google-Smtp-Source: AGs4zMb8GqwX+WJMK6VFgB+Dq8PbhNqhCS3+78YaGJdzOZihqSXRSgOOC1kiXtTEk14HEqcQgZb0WQ== X-Received: by 10.55.23.68 with SMTP id i65mr49678794qkh.179.1511657498364; Sat, 25 Nov 2017 16:51:38 -0800 (PST) Received: from ?IPv6:2601:152:4300:cf35:e147:24d1:8a60:15a3? ([2601:152:4300:cf35:e147:24d1:8a60:15a3]) by smtp.gmail.com with ESMTPSA id l52sm4829468qtc.43.2017.11.25.16.51.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Nov 2017 16:51:38 -0800 (PST) From: George Amanakis To: Dave Taht , George Amanakis via Cake References: <59515a10-e1c5-7b58-851f-ece09191fb43@gmail.com> Message-ID: <2d095770-e896-f5dd-6ba9-efb91da71451@gmail.com> Date: Sat, 25 Nov 2017 19:51:36 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [Cake] new patchset for upstream net-next X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Nov 2017 00:51:39 -0000 grep'ing in net-next for nf_ct_get_tuplepr reveals these are still in use. On 11/25/2017 7:49 PM, George Amanakis wrote: > I tried Kevin's latest commit, now it fails with: > >   CHK     include/config/kernel.release >   CHK     include/generated/uapi/linux/version.h >   DESCEND  objtool >   CHK     include/generated/utsrelease.h >   CHK     scripts/mod/devicetable-offsets.h >   CHK     include/generated/bounds.h >   CHK     include/generated/timeconst.h >   CHK     include/generated/asm-offsets.h >   CALL    scripts/checksyscalls.sh >   CHK     include/generated/compile.h >   CHK     kernel/config_data.h >   GEN     .version >   CHK     include/generated/compile.h >   UPD     include/generated/compile.h >   CC      init/version.o >   AR      init/built-in.o >   AR      built-in.o >   LD      vmlinux.o >   MODPOST vmlinux.o > net/sched/sch_cake.o: In function `cake_hash': > sch_cake.c:(.text+0x23d0): undefined reference to `nf_ct_get_tuplepr' > sch_cake.c:(.text+0x23f3): undefined reference to `nf_conntrack_find_get' > make: *** [Makefile:993: vmlinux] Error 1 > > Everything is selected (Y or M) under "Core Netfilter Configuration". > Are these functions deprecated in net-next? > > George > > > On 11/25/2017 4:42 PM, Dave Taht wrote: >> bad merge. darn it. >> >> On Sat, Nov 25, 2017 at 11:57 AM, George Amanakis >> wrote: >>> After correcting this, it fails with: >>> >>>    CHK     include/config/kernel.release >>>    CHK     include/generated/uapi/linux/version.h >>>    DESCEND  objtool >>>    CHK     include/generated/utsrelease.h >>>    CHK     scripts/mod/devicetable-offsets.h >>>    CHK     include/generated/bounds.h >>>    CHK     include/generated/timeconst.h >>>    CHK     include/generated/asm-offsets.h >>>    CALL    scripts/checksyscalls.sh >>>    CHK     include/generated/compile.h >>>    CHK     kernel/config_data.h >>>    CC      net/sched/sch_cake.o >>> net/sched/sch_cake.c: In function ‘cake_hash’: >>> net/sched/sch_cake.c:746:7: error: ‘allocate_host’ undeclared (first >>> use in >>> this function); did you mean ‘allocate_dst’? >>>     if (allocate_host) { >>>         ^~~~~~~~~~~~~ >>>         allocate_dst >>> net/sched/sch_cake.c:746:7: note: each undeclared identifier is >>> reported >>> only once for each function it appears in >>> make[2]: *** [scripts/Makefile.build:310: net/sched/sch_cake.o] Error 1 >>> make[1]: *** [scripts/Makefile.build:569: net/sched] Error 2 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [Makefile:1012: net] Error 2 >>> make: *** Waiting for unfinished jobs.... >>> ==> ERROR: A failure occurred in build(). >>>      Aborting... >>> >>> George >> >> >