Re: [Cake] https://tools.ietf.org/html/draft-ietf-tsvwg-le-phb-06 is in last call

[Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>]

[-- Attachment #1.1: Type: text/plain, Size: 2036 bytes --]

Maybe attached patch is more comprehensive?

KDB

> On 21 Aug 2019, at 16:07, Dave Taht <dave.taht@gmail.com> wrote:
> 
> Just ressurrecting this old thread for review now that this is an
> official RFC. I note also that the NQB diffserv codepoint is entering
> last call also.
> 
> https://tools.ietf.org/html/draft-white-tsvwg-nqb-02
> 
> On Sun, Feb 3, 2019 at 10:39 AM Dave Taht <dave.taht@gmail.com> wrote:
>> 
>> And seems likely to be adopted.
>> 
>> There seems to be an urge to make this codepoint starvable, which
>> since I ascribe to nagle's dictum "every application has a right to
>> one packet in the network" - doesn't work for me - but the draft is
>> vaguely worded enough to just start dumping this codepoint into the
>> background queue of both sqm and cake and worry about it in a decade
>> or three.
>> 
>> it's 000001 which I guess is:
>> 
>> diff --git a/sch_cake.c b/sch_cake.c
>> index 3a26db0..67263b3 100644
>> --- a/sch_cake.c
>> +++ b/sch_cake.c
>> @@ -343,7 +343,7 @@ static const u8 diffserv4[] = {
>> };
>> 
>> static const u8 diffserv3[] = {
>> -       0, 0, 0, 0, 2, 0, 0, 0,
>> +       0, 1, 0, 0, 2, 0, 0, 0,
>>        1, 0, 0, 0, 0, 0, 0, 0,
>>        0, 0, 0, 0, 0, 0, 0, 0,
>>        0, 0, 0, 0, 0, 0, 0, 0,
>> 
>> (or is that reversed? my big endian/little endian chops scuks, and
>> nobody modified the gen_cake_const tool to match what cake expects
>> now)
>> 
>> on my off days I kind of wish the diffserv lookup we do in cake had
>> managed to make it into the linux mqprio/prio stuff by default.
>> 
>> --
>> 
>> Dave Täht
>> CTO, TekLibre, LLC
>> http://www.teklibre.com
>> Tel: 1-831-205-9740
> 
> 
> 
> --
> 
> Dave Täht
> CTO, TekLibre, LLC
> http://www.teklibre.com
> Tel: 1-831-205-9740
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake


Cheers,

Kevin D-B

gpg: 012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A

[-- Attachment #1.2: 0001-RFC-8622-diffserv3-4-8-LE-PHB-support.patch --]
[-- Type: application/octet-stream, Size: 1633 bytes --]

From 1f460443d1bd54d269e3efda6999c0bbd91f7a03 Mon Sep 17 00:00:00 2001
From: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Date: Mon, 4 Feb 2019 21:27:58 +0000
Subject: [PATCH] RFC 8622 diffserv3, 4 & 8 LE PHB support

Change tin mapping on diffserv3, 4 & 8 for LE PHB support,
in essence make LE a member of the Bulk tin.

Bulk has the least priority and minimum of 1/16th total bandwidth in the
face of higher priority traffic.

NB: Diffserv 3 & 4 swap tin 0 & 1 priorities from the default order as
found in diffserv8, in case anyone is wondering why it looks a bit odd.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
---
 sch_cake.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sch_cake.c b/sch_cake.c
index 93c0c8a..81950ad 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -333,8 +333,8 @@ static const u8 precedence[] = {
 };
 
 static const u8 diffserv8[] = {
-	2, 5, 1, 2, 4, 2, 2, 2,
-	0, 2, 1, 2, 1, 2, 1, 2,
+	2, 0, 1, 2, 4, 2, 2, 2,
+	1, 2, 1, 2, 1, 2, 1, 2,
 	5, 2, 4, 2, 4, 2, 4, 2,
 	3, 2, 3, 2, 3, 2, 3, 2,
 	6, 2, 3, 2, 3, 2, 3, 2,
@@ -344,7 +344,7 @@ static const u8 diffserv8[] = {
 };
 
 static const u8 diffserv4[] = {
-	0, 2, 0, 0, 2, 0, 0, 0,
+	0, 1, 0, 0, 2, 0, 0, 0,
 	1, 0, 0, 0, 0, 0, 0, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
@@ -355,7 +355,7 @@ static const u8 diffserv4[] = {
 };
 
 static const u8 diffserv3[] = {
-	0, 0, 0, 0, 2, 0, 0, 0,
+	0, 1, 0, 0, 2, 0, 0, 0,
 	1, 0, 0, 0, 0, 0, 0, 0,
 	0, 0, 0, 0, 0, 0, 0, 0,
 	0, 0, 0, 0, 0, 0, 0, 0,
-- 
2.20.1 (Apple Git-117)


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]