From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 982E93CB3F for ; Wed, 7 Mar 2018 06:08:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Pmw6SCizq49IJr6VofMNnrkoPQpE5Mm/GCVJCt3fyMQ=; b=sCPrtUTMZgum3M5bkeTRe0IyXupJw8WQOIY19wNpNLivnvMaelsJkZ6vFmDqkltH+pbVZ2v5uHUi+fDBi2X1Swol0A4THG2pZ7wSpAiz68b2CzHfbiK8jVr/NNv3r978pqYeraIHqJzmJftMhI4BQe4a7DQlgaFWFCRJTi30qIs= Received: from VI1PR0702MB3741.eurprd07.prod.outlook.com (52.134.3.159) by VI1PR0702MB3613.eurprd07.prod.outlook.com (52.134.1.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.7; Wed, 7 Mar 2018 11:08:12 +0000 Received: from VI1PR0702MB3741.eurprd07.prod.outlook.com ([fe80::cd2c:f6e1:4042:fe80]) by VI1PR0702MB3741.eurprd07.prod.outlook.com ([fe80::cd2c:f6e1:4042:fe80%2]) with mapi id 15.20.0567.011; Wed, 7 Mar 2018 11:08:11 +0000 From: Kevin Darbyshire-Bryant To: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= CC: Jonathan Morton , "cake@lists.bufferbloat.net" Thread-Topic: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure Thread-Index: AQHTtf92ZAagU2vDn02WdO/2XvDtbKPElDwAgAAI7YA= Date: Wed, 7 Mar 2018 11:08:11 +0000 Message-ID: <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> In-Reply-To: <87sh9cyxy9.fsf@toke.dk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-originating-ip: [2a02:c7f:1232:22b::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0702MB3613; 6:HW0K1o79zXnX8+kLJJr9sI2lehD2Nqo+mPL5M8VjicdJfiYAw0RDzQNFFsHNwjP8mVIsEv9MYDZzNetEQ2U2WqxIf+9BDraQQhDe/lOXpZnheMBaLk4J3TFi+4yfGgp7rOrb2j175aguLvFCS/5Xv1Oh4XN61gkXZVTMcNgnA6aANKmj+sexmO7jjrv/1xhqx7OWdViToYXQRIYz7QeMSw3ngnCVx9s2iFf0t44wo0PIP6lFrp7E4OLiLsTT88ECeCEck3gkJhfnGv6GZgvtAiVko1DfpCD8N0TUPURpNnxL3k+8pLlYfc7Ded1PAVR7n6naM67yrh4+00VKpGyiw3yK2k35O6+UO5WGMvtzc51J59iurlhWC0BVyiFvJlrK; 5:a2HHM55CPSLnghP/26Q053f+cSsyMZ7EbRlqYMPK6HtAZFoUKNdUMcwOkKFZcpQfk9F8LC7sha8Tj2pIzE83QMO5cU9mWoIaqKv0ZBuS1snwfdFTEiBzMWhTIbiBGu2pN6xGRjqKDDJBFYI64RtPCKvGtim253TPVrIFbnMAvT4=; 24:WZ6kM5w6Kl9Jr17tkmknhQlzOfI3AgD32oTZI1qwQqxH0j+rd0Wd2KhI5qMt7d6R1xr1TVUu3sLml2CP8Ol2eHm/9VfuEWcu6CLDWctxXkk=; 7:ve26TUlMGigijn+4Z1UF3l9pR9Wl1glJBCXLvTlo9wsQBPcSFqLOSXQC8LSsAB91e4C/+iFYklUFJfosIsbJnpuXpv+0bIDpKizoRUES9Q5st+47rbIxlVwXkIvMehMlK26km9WvtELh6+705zsCLKwrV+lCtSZsh0V+ruaydrZiUzexEimnsRi4xIj1rSpR/0vNuJ3MUzpKJpE6kGhGrBaUn/LQHecji7gHMxQ/2DXSJq1vPLxGNF40Eaf/L6Yl x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b3b7a137-4e1b-4929-8261-08d5841bb775 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(3008032)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:VI1PR0702MB3613; x-ms-traffictypediagnostic: VI1PR0702MB3613: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(6041288)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(2016111802025)(6043046)(6072148)(201708071742011); SRVR:VI1PR0702MB3613; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0702MB3613; x-forefront-prvs: 0604AFA86B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39830400003)(376002)(346002)(39380400002)(366004)(52314003)(189003)(199004)(53754006)(4326008)(8676002)(53936002)(54906003)(106356001)(316002)(105586002)(93886005)(25786009)(39060400002)(3660700001)(15650500001)(74482002)(6486002)(6436002)(76176011)(186003)(6116002)(102836004)(2906002)(6306002)(6512007)(6246003)(99286004)(82746002)(3280700002)(46003)(8936002)(2950100002)(6916009)(83716003)(97736004)(2900100001)(229853002)(68736007)(86362001)(36756003)(99936001)(59450400001)(6506007)(305945005)(5660300001)(7736002)(53546011)(33656002)(81156014)(14454004)(966005)(478600001)(81166006)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0702MB3613; H:VI1PR0702MB3741.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: U8xOLi+UlFftCzRLcQZGuwDp5Qr0l11Ty75xEs/fSueMXObQrz9cRWhIK6IPF3tCn7ZlPermyySkkMJ/tOwLtDqjy6bgMv1MbdqqHxul4eFy6Mnwz9xTfP4TtPEWpCZDtnfZTM2gAx6G0g8wHliVpnUFyqjSijJ/Sn48YNpyFNMwLzng2/eHNZRBWlzH6eEdJBWBBYcOwt0+BOLnfrjs0oaOBebXwjw7iAhFrN40HDT1o0QmScRCmhSg+20XB/t8WPnlNORV7EE9kMIMCkgzT4sELOzjPYNrzO3pxtHMM84Drkg5WMvM0W6X2ebh8a9/qpCxWsH8wjnMkWra9KMXoQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_F9200E80-91F4-4024-89EF-FD2866650132"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: b3b7a137-4e1b-4929-8261-08d5841bb775 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2018 11:08:11.8687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0702MB3613 Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 11:08:24 -0000 --Apple-Mail=_F9200E80-91F4-4024-89EF-FD2866650132 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 There were some useful stats column re-alignment changes as well, wonder = if you got those? > On 7 Mar 2018, at 10:36, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Toke H=C3=B8iland-J=C3=B8rgensen writes: >=20 >> Kevin Darbyshire-Bryant writes: >>=20 >>> Hi All, >>>=20 >>>=20 >>>=20 >>>> On 7 Mar 2018, at 08:50, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>>>=20 >>>> Jonathan Morton writes: >>>>=20 >>>>>> On 6 Mar, 2018, at 11:06 pm, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>>>>>=20 >>>>>> ...on the iproute2 side the only >>>>>> thing missing before we can attempt an upstream submission is an = update >>>>>> of the man page, as far as I can tell. Any volunteers to do that? = :) >>>>>=20 >>>>> I could look into that tomorrow. >>>>=20 >>>> Awesome! Is there anything else you want to add on the kernel side >>>> before we submit? >>>=20 >>> I think there was mention of the repo that Dave started on the last >>> round of getting cake in upstream iproute2. There were a few man = page >>> tweaks & output formatting tweaks which ideally shouldn=E2=80=99t be = lost. >>> I=E2=80=99ve forked that fork on github here >>> https://github.com/ldir-EDB0/iproute2-cake-next/tree/cake rebased = onto >>> release tag v4.15.0 and pulled in the the recent changes (overhead >>> handling paradigm, xstats & the JSON output). >>>=20 >>> In theory I guess there should be no/little difference to = tc-adv/master now but=E2=80=A6. >>>=20 >>> Anyway, it=E2=80=99s there if it=E2=80=99s of any interest=E2=80=A6 = it=E2=80=99ll be the basis of what >>> gets sent into LEDE a bit later today. >>=20 >> Please don't put something different into LEDE than what we're = working >> on upstreaming. It is difficult enough to keep track of the different >> versions as they are. The tc-adv repo is already rebased on the = upstream >> iproute2-next, so if there is anything else that needs to be changed, = it >> should be changed in that repo and not in a fork... >=20 > I pulled in the man page changes from Dave's iproute2-next fork to the > tc-adv repo now... >=20 > -Toke Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A --Apple-Mail=_F9200E80-91F4-4024-89EF-FD2866650132 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlqfyBsACgkQs6I4m53i M0p9JA/6Az2UFzybYAoYNkQd5nLZd/ru5cZO1gXZSpg+qZmrpLc0+qB5AUevMpwM 2aekTmmh+lggIMU8hoSpEQT6X3Bu7D626MlPHOu6g/xxgSbqc7F/+fOJ9bUHqhLa ZC4YiV0fWFcxbdb9hXoNmleuDhDYZ4w3rYdtGCZwmElcTog2i8nlQPa/MtBwdPfg Z/MtgUs+speX12m0qNxSC0zB2cJ6d5zGouUIvK9kJfKFGL+s42e+TsfDW8ckapKG 6pSO893reNd0m9Q42Wkbv+XHK4RPKzlvq8SG18s1HcVoh0pnCB3waWnK1P8ZwWI+ +98CURbKzq+ZAI3T2yNg//cHbyPBttWTchYiRS7SYtFJEXLcbjJ7yNririGXhJDY LreR994bTcdkKCgzwptEg5idmGIjg62As/9KAq9KmZ810qPO+s/ARsoIP75LxUrJ ipNa20w10MkxrEF1EOAqdHEQb49PWRWAfbHH18aRmHXuQ1CFZFD0OwbKRE6UvShM dSIeIgDXK+9I19yaRvhRkvkIqgOEjXiVIigzl1oxxBAdc256XanGPR+e+0ttsmex Y0Thy/ISpHd98IiUU761iECgbrPHfbiVmDiRweGNlWUEXW1gViHIMNO4ILsewEQn WWzBgh7W7ngDqkDd/q6pwSOMXoPnpXs7q8Sgvg50KOHX9noTypo= =CmjV -----END PGP SIGNATURE----- --Apple-Mail=_F9200E80-91F4-4024-89EF-FD2866650132--