From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] cake memory consumption
Date: Wed, 18 Sep 2019 09:19:42 +0200 [thread overview]
Message-ID: <3449acf8-e700-6b50-544f-b272165ad0e6@newmedia-net.de> (raw)
In-Reply-To: <87r24fjm60.fsf@toke.dk>
the problem is. i tested restricting the memory to 4 mb. but it still
runs oom. same memory consumption and from the qdisc show output i also
see that just a few kilobytes are used in that pool.
so the problem with cake must be somewhere else. its not the buffer
limit. i see values like memory used: 22176b of 4Mb which is really
nothing. most qdiscs are 0 and unused in that setup
Am 17.09.2019 um 11:40 schrieb Toke Høiland-Jørgensen:
> Sebastian Gottschall <s.gottschall@newmedia-net.de> writes:
>
>> more simple patch
>>
>> --- sch_cake.c (revision 41051)
>> +++ sch_cake.c (working copy)
>> @@ -2691,7 +2691,7 @@
>> do_div(t, USEC_PER_SEC / 4);
>> q->buffer_limit = max_t(u32, t, 4U << 20);
>> } else {
>> - q->buffer_limit = ~0;
>> + q->buffer_limit = 4U << 20;
>> }
>>
>> sch->flags &= ~TCQ_F_CAN_BYPASS;
> As Jonathan remarked, the right thing to do here is to use the
> memory_limit parameter to set a different limit when you setup the tree.
>
> Still, I count 35 instances of CAKE in your setup; even with a 4MB limit
> apiece, that is a total of 140 MB of potential packet memory. You'd need
> to set it as low as 1 or 2 MB to be completely sure that you won't run
> out of memory if they are all full...
>
> -Toke
next prev parent reply other threads:[~2019-09-18 7:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 22:42 [Cake] Fighting bloat in the face of uncertinty Justin Kilpatrick
2019-09-07 23:09 ` Jonathan Morton
2019-09-07 23:31 ` Justin Kilpatrick
2019-09-07 23:42 ` Jonathan Morton
2019-09-08 0:03 ` Justin Kilpatrick
2019-09-08 0:59 ` Jonathan Morton
2019-09-08 14:29 ` Justin Kilpatrick
2019-09-08 17:27 ` Jonathan Morton
2019-09-16 10:21 ` [Cake] cake memory consumption Sebastian Gottschall
2019-09-16 12:00 ` Dave Taht
2019-09-16 12:51 ` Dave Taht
2019-09-16 13:31 ` Sebastian Gottschall
2019-09-16 13:22 ` Sebastian Gottschall
2019-09-16 13:28 ` Justin Kilpatrick
2019-09-16 13:39 ` Jonathan Morton
2019-09-16 13:54 ` Sebastian Gottschall
2019-09-16 14:06 ` Jonathan Morton
2019-09-17 5:10 ` Sebastian Gottschall
2019-09-16 13:47 ` Sebastian Gottschall
2019-09-16 12:08 ` Toke Høiland-Jørgensen
2019-09-16 13:25 ` Sebastian Gottschall
2019-09-16 14:01 ` Toke Høiland-Jørgensen
2019-09-17 5:06 ` Sebastian Gottschall
2019-09-17 5:21 ` Sebastian Gottschall
2019-09-17 5:31 ` Sebastian Gottschall
2019-09-17 9:21 ` Jonathan Morton
2019-09-17 9:55 ` Sebastian Gottschall
2019-09-17 5:33 ` Sebastian Gottschall
2019-09-17 9:40 ` Toke Høiland-Jørgensen
2019-09-18 7:19 ` Sebastian Gottschall [this message]
2019-09-18 9:53 ` Toke Høiland-Jørgensen
2019-09-18 9:57 ` Sebastian Gottschall
2019-09-18 10:22 ` Toke Høiland-Jørgensen
2019-10-03 17:52 ` [Cake] Fighting bloat in the face of uncertinty Justin Kilpatrick
2019-10-03 18:41 ` Dave Taht
2019-10-03 19:04 ` Jonathan Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3449acf8-e700-6b50-544f-b272165ad0e6@newmedia-net.de \
--to=s.gottschall@newmedia-net.de \
--cc=cake@lists.bufferbloat.net \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox