From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from webmail.newmedia-net.de (smtps.newmedia-net.de [IPv6:2a05:a1c0:0:de::167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 29AC33B29E for ; Wed, 18 Sep 2019 03:21:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newmedia-net.de; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=p3wRt6t3VTPxlOueoRy6tv7cW4Prfwz3B9O7JB7pbwE=; b=KH1j8yB2jtwB1pZhjOciUaj6KNcWB3HLvGUpt45yYATk7TRvsdHd+zcTwQDv6eIGb1qR+0aAzcTgF8SGhqgMTXk4PrfFUu1dkfL5cToJU4IiGiYVa/Z5/ZlBHbEyBYTLdYEwaJwOSyLERbsWBQUc25ARFu6w2DPBhRv835MQMMs=; To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , cake@lists.bufferbloat.net References: <2825CE14-2109-4580-A086-9701F4D3ADF0@gmail.com> <18b1c174-b88d-4664-9aa8-9c42925fc14c@www.fastmail.com> <9a90111b-2389-4dc6-8409-18c40f895540@www.fastmail.com> <43F02160-E691-4393-A0C0-8AB4AD962700@gmail.com> <057ea708-6797-23f5-ef01-9d3d7b002578@newmedia-net.de> <878sqomoj4.fsf@toke.dk> <87h85cl4qk.fsf@toke.dk> <87r24fjm60.fsf@toke.dk> From: Sebastian Gottschall Message-ID: <3449acf8-e700-6b50-544f-b272165ad0e6@newmedia-net.de> Date: Wed, 18 Sep 2019 09:19:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <87r24fjm60.fsf@toke.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Received: from [212.111.244.1] (helo=[172.29.0.186]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1iAUHB-0002ii-7h; Wed, 18 Sep 2019 09:21:21 +0200 Subject: Re: [Cake] cake memory consumption X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 07:21:15 -0000 the problem is. i tested restricting the memory to 4 mb. but it still runs oom. same memory consumption and from the qdisc show output i also see that just a few kilobytes are used in that pool. so the problem with cake must be somewhere else. its not the buffer limit. i see values like memory used: 22176b of 4Mb which is really nothing. most qdiscs are 0 and unused in that setup Am 17.09.2019 um 11:40 schrieb Toke Høiland-Jørgensen: > Sebastian Gottschall writes: > >> more simple patch >> >> --- sch_cake.c  (revision 41051) >> +++ sch_cake.c  (working copy) >> @@ -2691,7 +2691,7 @@ >>                 do_div(t, USEC_PER_SEC / 4); >>                 q->buffer_limit = max_t(u32, t, 4U << 20); >>         } else { >> -               q->buffer_limit = ~0; >> +               q->buffer_limit = 4U << 20; >>         } >> >>         sch->flags &= ~TCQ_F_CAN_BYPASS; > As Jonathan remarked, the right thing to do here is to use the > memory_limit parameter to set a different limit when you setup the tree. > > Still, I count 35 instances of CAKE in your setup; even with a 4MB limit > apiece, that is a total of 140 MB of potential packet memory. You'd need > to set it as low as 1 or 2 MB to be completely sure that you won't run > out of memory if they are all full... > > -Toke