From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E4D3A3BA8E for ; Thu, 23 Nov 2017 17:20:11 -0500 (EST) Received: from hms-beagle2.lan ([80.135.78.186]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LnUna-1enUqS1Bd8-00hfXA; Thu, 23 Nov 2017 23:20:10 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) From: Sebastian Moeller In-Reply-To: <6E3AF126-B32C-4625-A443-FD048493B161@gmx.de> Date: Thu, 23 Nov 2017 23:20:09 +0100 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <3707E8F3-F795-49C1-89AE-2EB259483928@gmx.de> References: <1511309382-24060-1-git-send-email-dave.taht@gmail.com> <0AE259AC-DB97-42CE-9E0D-33FBF11159AD@gmx.de> <6E3AF126-B32C-4625-A443-FD048493B161@gmx.de> To: =?utf-8?Q?Dave_T=C3=A4ht?= X-Mailer: Apple Mail (2.3273) X-Provags-ID: V03:K0:4TNLuJeiU2hFKvMP6U7T+Asqwcn2IXtg/xLq22lNn7o506+worC KcJjVVGfVA6//zbxlQE7/Y9CX8ib3i187ENWVHVk7EyHqD+BFVQXO5+kZcEWm1r5/ZVEiQs cVpt4tezCsFgJFJZICZpMO51d+4VcHhgHFb1R52Im3XByf7+R0gzUkIxnWLunwLkIRcrgpH EQ75aDWThzJD2knWbwcbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:G2WXwBJqds4=:5m29UQXpGp/i9YT2SYC8Vw GN5sQ+ppo0wsHb/pBh2toKBarzu5573nMuUXmq/EuTYdeBPvOvC5Fb29LhNnrP65iNVHqP1/l 4pUjv6FcyTZz4xUFfN7iRO4yBu6YL1DhOOarvGmvivKi+Nw2c0qZ9so1ZgdaxPx/CIAbQnbPC EvDhMGw1x3Kj5XH7sszPQiI6dbIE+4tU202F5aPuj8Mxq5uRc+rBpSDBI00+sAJLRqjKusGjE uXRobD1+xL9/8AW04TUT7xwDc+0QFgCZ0VvLFnXVNspmSk4pu8Jpn7LbqPTOTX2/f+UFal6S9 8SnKC3BwBOA+9GP/FzTkcFMZ9vQd44WgZ8H2wCtSSJVj7pdhuF4LwR/HMDY5KSEFTHPrjjYbu D0WhXa9dCEOhUXre43Aef7U6bSLs2g9kQVhetbNXiTgn7ULQUkAoPbaueCIZfdg/ddKef7Zxu NtDjUHsve4wV5Rz1TE17K6pmsZwLXRkCnv6RLwHHtvYvOXzydZeFKjyKulWRgG0+lgXxQkCwo SeDbdtrUcK8edvu8FE+4eGf7P0G7du4Jx7TWroxSAIUfYXWFYNTuLumlEuN95gBoFkHxGf2l4 XzDR8K6cMjSbm6nAb33rYPblZF2EWWBLlAlD+Gw/VJ6Dgr49lDxTz7O74oqRMhCSBT13HlT7p popbxzxLYOA1nvAO6rbUSrrcsslbTrzBVytIIAExavCqBRi1qfNhzYAoPL+ygWlruaXb5JZJT dyTyajliwIuSifwTJD44Z1LylkO4dD3msP2L0SeP/hxIUerRz2AixhFIINoHGziue8yGI8a/r BxZcyOfa3uX/N03Kws4tvd3fRffC7rvkI49ZIPgjGLujxITCLw= Subject: Re: [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 22:20:12 -0000 And it turns out the current head has this fixed already... I guess this must be Kevin's fix, I could have sworn that I had that in = my repository when I started testing, but I guess I tried juggling a few = repositories too many on too many computers. So it seems this was fixed all along, well it made me try git bisect so = all was good... Just for documentation:=20 1) Building (from inside the sch_cake repository: sudo tc qdisc delete root dev eth0 ; sudo rmmod sch_cake ; tc -s qdisc = show dev eth0 ; make ; sudo make install 2) Testing: sudo ../iproute2-cake-next/tc/tc qdisc delete root dev eth0 ; sudo = ../iproute2-cake-next/tc/tc qdisc add root dev eth0 cake raw overhead 0 = ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0 Results user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc = delete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root = dev eth0 cake raw overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show = dev eth0 [...] GOOD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms raw total_overhead 14 hard_header_len 14=20 BAD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms raw total_overhead 14 hard_header_len 14 # note with the = added "raw" keyword this always worked [...] user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc = delete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root = dev eth0 cake overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev = eth0 [...] GOOD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms noatm overhead 0 via-ethernet total_overhead 0 = hard_header_len 14=20 BAD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms noatm overhead 14 via-ethernet total_overhead 14 = hard_header_len 14=20 [...] user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc = delete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root = dev eth0 cake ethernet ; ../iproute2-cake-next/tc/tc -s qdisc show dev = eth0 [...] GOOD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms noatm overhead 38 via-ethernet total_overhead 38 = hard_header_len 14 mpu 84=20 BAD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate = rtt 100.0ms noatm overhead 14 via-ethernet total_overhead 14 = hard_header_len 14 mpu 84=20 [...] The BAD results are from memory so might be off in the "overhead N" and = "via-ethernet" results but the total_overhead and hard_header_len looked = quite similar to the reported ones... Best Regards Sebastian > On Nov 23, 2017, at 23:02, Sebastian Moeller wrote: >=20 > And git bisect gave: >=20 > user@work-horse:~/CODE/sch_cake$ git bisect bad > 031998e4eee58cbc706711eba8c54684f07306be is the first bad commit > commit 031998e4eee58cbc706711eba8c54684f07306be > Author: Dave Taht > Date: Sun Nov 19 19:02:06 2017 -0800 >=20 > sch_cake: make more checkpatch compliant >=20 > :100644 100644 97a4727e6ed9b9451567568b027e65dd9937112c = e6a4b09ae8bebab5ae07b94b469184669ab6e27f M sch_cake.c > user@work-horse:~/CODE/sch_cake$ >=20 > as the likely culprit, now let's see whether I can figure out why. = (The git bisect thing, even though I had to skip a few commits makes bug = hunting almost fun). >=20 >=20 > Best Regards >=20 >> On Nov 23, 2017, at 22:43, Sebastian Moeller wrote: >>=20 >> 9789742cfc596d48583ba4cdbc8f38d026121fa6 >=20 > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake