From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 73E733CB38 for ; Wed, 4 Aug 2021 18:52:58 -0400 (EDT) Received: by mail-ej1-x62c.google.com with SMTP id qk33so6085212ejc.12 for ; Wed, 04 Aug 2021 15:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bHqN7UK5Kxn+EGfLJlyvTF2mqrFLafKULgYtPDdA91g=; b=dP3dhdZ24WNE45GMVYzzU94G2dc2NkL9DQr4/HHeqY2gtU6uddd4ZRcz2Kyt8BUJaq n/qxrz6v5EVyAAXOPHP8DdhWK8V2UL83fM47mtCHuMfFadyW7fHpE2oPetwtMtcwhjkc 1qZXO9b/yaydBPL/Xp7aWF3RLNMep47TCl40czvSfdencI6ZMjketGtKlewXEqa9VAgl mefK6/gtAJH+BqGq8pYNtrIQFIFSIPuzswcaiKS92oIXbkDn5SN2A5bmE0pp2yeOacQR qlFTEtRw6hzkpi0V1X34oKcNVGJ19nKJRbrPV+BTL+b0l7jkP5g+rCkWrxdgtnyah6cg U7KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bHqN7UK5Kxn+EGfLJlyvTF2mqrFLafKULgYtPDdA91g=; b=QHFw0F9mQev87IDnMRnc/UydthgMgB1d/ef7wBgGtkV8HecjkmV59Xog203QkHL/RR ko7h8B7gN5q++is01rpjzkQtQxRuyq4n9/s1m2nz+na6yYpnzEe4oJFBzmFMTP2gT8KN WOzk5UYOZbGF/HMnTg1d7rDqcZZtaQzi8yFMttG7bn+aBgfzjX7PE60ZUSIwgK/3MWrJ LxRaMU9Fw7PlmdOz5lOsG1vGaszage+LVNMZ87D/dZq+5djif2/6IDNt0Lwt5BVP73y0 xQYRYg/C+k7uFZ73D5PEZX6rr/xR5gFHeYTxWV8ujCp+jaz4R+c0EMtP3099HAaO9oLl JBag== X-Gm-Message-State: AOAM531YOn3IBfhl32bzmqxRepBFra1DgQWA8eTUeRmkqI9/N5u2iAZN oU7haSt9HjXjtiCrET/07CovaQ== X-Google-Smtp-Source: ABdhPJwdLz/tZkNwzGr7m4nBbTWk7rKXZpqe6LTFq6Jz+VL8zI3WaXvaNyFMt7jxI+zjY2geZUUDqA== X-Received: by 2002:a17:906:9c84:: with SMTP id fj4mr1408874ejc.264.1628117577389; Wed, 04 Aug 2021 15:52:57 -0700 (PDT) Received: from [10.72.0.88] (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id v8sm1067570ejy.79.2021.08.04.15.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 15:52:57 -0700 (PDT) Message-ID: <37822e2cebd977f2c5c0758b48a191f2644d7589.camel@heistp.net> From: Pete Heist To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Cake List Date: Thu, 05 Aug 2021 00:52:54 +0200 In-Reply-To: <5964374bee9979ee9f1b4b86d32b002722d628fc.camel@heistp.net> References: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net> <87r1f95und.fsf@toke.dk> <5964374bee9979ee9f1b4b86d32b002722d628fc.camel@heistp.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Cake] cake srchost/dsthost stopped working? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 22:52:58 -0000 I ended up testing each of the keywords, with two src IPs then two dst IPs, and I think everything makes sense: https://www.heistp.net/downloads/cake-hostfair/cake-hostfair-patched.txt I'm only not sure if we can tell from this test if triple-isolate is doing what it should... Pete On Wed, 2021-08-04 at 22:49 +0200, Pete Heist wrote: > Great, that seems to fix it. :) For sanity, I confirmed that I can > apply/unapply the patch to fix/break it, so all seems well. > > Is there anything that you'd want to make sure still works after the > patch? I don't have any official regression tests to run, but with this > setup ready I should be able to test something easily if needed... > > Pete > > On Wed, 2021-08-04 at 13:14 +0200, Toke Høiland-Jørgensen wrote: > > Pete Heist writes: > > > > > One more tip, reverting this commit seems to fix it: > > > > > > https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7297c15d6ce > > > > Ah, I think I see what the problem is; could you please try the patch > > below? > > > > -Toke > > > > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > > index 951542843cab..a83c4d4326da 100644 > > --- a/net/sched/sch_cake.c > > +++ b/net/sched/sch_cake.c > > @@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, > > const struct sk_buff *skb, > >  skip_hash: > >         if (flow_override) > >                 flow_hash = flow_override - 1; > > -       else if (use_skbhash) > > +       else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS) > >                 flow_hash = skb->hash; > >         if (host_override) { > >                 dsthost_hash = host_override - 1; > >