From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 90BF83BA8E for ; Wed, 29 Aug 2018 04:12:19 -0400 (EDT) Received: by mail-wr1-x42e.google.com with SMTP id u12-v6so3885866wrr.4 for ; Wed, 29 Aug 2018 01:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=hJXESt1PLunAXqC0wI+wsFEOhcJooWPLikyW/Ilec9A=; b=Quc9NP9t2xJc1tbo3nWDvAV3G/h8k3gijUGmjGQk1aT5hAB/JBLp33U6bvPp1ZZOYP KxTlRl9BOj1RJS82m7iX/HeDHaeyQR1yU+PWocomxlcBrDKvZozjumZPpBmJYGXXIrwt D1LuEehbpGCV5+6nyWu3VxTHJO5DHgOaa1Ezfd7gg6w62FvqpFGSzU3X5NaavkGjzrKq ykrYhnNbBaFzAguPbgNxJvXfO6gLc0ejlodDpEmxmkPOCWvlhzW9i/VuLo6iDUVva7Sd gMKcCKxjioTMvkNrUkVYxZGavOsEsBA8ehPddtzdHgtIldFDwBoydCrfEoUKODWtif4h v7YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=hJXESt1PLunAXqC0wI+wsFEOhcJooWPLikyW/Ilec9A=; b=JnvghdRxuD6fWywb/PqBFa/4dJ7BtePSQ4OJhe0aikHI2dMCV73zRrEHtxRZDygqcI V3qAVG5/gkrVo53kUtZoqkut6KxZ/EbzdNMdrBeYKuirSZ4sRd7P7UzA7jFuX0vUV5lK GSLw0RaxqYaYiUsGIkBV5OFm8pjXslDVVrmOPKQ+hHVcw4ms+q0rS9a4ZKuom4B5TByz 6sTThnOmdJahA4MvIF1yNLEEKWrzxJ7LU6eDjASfSlczQimHS6CL0YqAh0/NG17CIc3v TTtXYdw63IuwcbCZBW9L9S2FgYuLXCcPwfivEQUlAiSc7YSWTQxCZrCog6ZYHxMcC7wW QmMQ== X-Gm-Message-State: APzg51De/uOTRQlkzdoR72hfaaETJFC8WQgfC/2yGSJEOQPpkkSefMSW oyMt91cipOzS8/1cZ7pLLpUyTw== X-Google-Smtp-Source: ANB0VdYyLdzd8sp9rF8CCXR7aTi730bTj3uOGYc5wY8111IkgSjj83IqYa0REL86QFIe2W0VnfHUeA== X-Received: by 2002:adf:824f:: with SMTP id 73-v6mr3530538wrb.130.1535530338722; Wed, 29 Aug 2018 01:12:18 -0700 (PDT) Received: from tron.lt2.drhleny.cz ([185.15.109.151]) by smtp.gmail.com with ESMTPSA id 88-v6sm3820903wrf.95.2018.08.29.01.12.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 01:12:18 -0700 (PDT) From: Pete Heist Message-Id: <3E647031-D865-41B1-9C3A-6D34DB291005@heistp.net> Content-Type: multipart/mixed; boundary="Apple-Mail=_6D3A4CF9-7E7F-4CED-BE1F-9789BAAE7F70" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Date: Wed, 29 Aug 2018 10:12:17 +0200 In-Reply-To: Cc: Cake List To: Dave Taht References: X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] fq_codel_fast X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 08:12:19 -0000 --Apple-Mail=_6D3A4CF9-7E7F-4CED-BE1F-9789BAAE7F70 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 29, 2018, at 3:04 AM, Dave Taht wrote: >=20 > Anyway, this should be a drop in replacement (presently) for fq_codel, > that compiles out of tree and rips out almost everything I don't like. >=20 > https://github.com/dtaht/fq_codel_fast Cool=E2=80=A6I=E2=80=99d give it a quick run but it doesn=E2=80=99t = compile for me (attached). Kernel version? > I think the tc filter thing really hurt us in cake. It would be interesting to see how much. Jon also expressed concern and = I=E2=80=99d been meaning to try some benchmarks before and after that = change=E2=80=A6 --Apple-Mail=_6D3A4CF9-7E7F-4CED-BE1F-9789BAAE7F70 Content-Disposition: attachment; filename=fq_codel_fast_compile.txt Content-Type: text/plain; x-unix-mode=0644; name="fq_codel_fast_compile.txt" Content-Transfer-Encoding: quoted-printable root@ubuntu:~/src/fq_codel_fast$ make make -C /lib/modules/4.15.0-33-generic/build = SUBDIRS=3D/root/src/fq_codel_fast modules = LDFLAGS_MODULE=3D"--build-id=3D0xa524fc2e39dc291199b9b04fb890ea1548f17641"= = CFLAGS_MODULE=3D"-DCAKE_VERSION=3D\\\"a524fc2e39dc291199b9b04fb890ea1548f1= 7641\\\"" make[1]: Entering directory '/usr/src/linux-headers-4.15.0-33-generic' CC [M] /root/src/fq_codel_fast/sch_fq_codel.o /root/src/fq_codel_fast/sch_fq_codel.c: In function =E2=80=98fq_codel_init= =E2=80=99: /root/src/fq_codel_fast/sch_fq_codel.c:444:8: error: too many arguments = to function =E2=80=98tcf_block_get=E2=80=99 err =3D tcf_block_get(&q->block, &q->filter_list, sch, extack); ^~~~~~~~~~~~~ In file included from /root/src/fq_codel_fast/sch_fq_codel.c:26:0: ./include/net/pkt_cls.h:41:5: note: declared here int tcf_block_get(struct tcf_block **p_block, ^~~~~~~~~~~~~ /root/src/fq_codel_fast/sch_fq_codel.c:449:14: error: implicit = declaration of function =E2=80=98kvcalloc=E2=80=99; did you mean = =E2=80=98kvzalloc=E2=80=99? [-Werror=3Dimplicit-function-declaration] q->flows =3D kvcalloc(FQ_FLOWS, ^~~~~~~~ kvzalloc /root/src/fq_codel_fast/sch_fq_codel.c:449:12: warning: assignment makes = pointer from integer without a cast [-Wint-conversion] q->flows =3D kvcalloc(FQ_FLOWS, ^ /root/src/fq_codel_fast/sch_fq_codel.c:456:15: warning: assignment makes = pointer from integer without a cast [-Wint-conversion] q->backlogs =3D kvcalloc(FQ_FLOWS, sizeof(u32), GFP_KERNEL); ^ /root/src/fq_codel_fast/sch_fq_codel.c: At top level: /root/src/fq_codel_fast/sch_fq_codel.c:652:15: error: initialization = from incompatible pointer type [-Werror=3Dincompatible-pointer-types] .tcf_block =3D fq_codel_tcf_block, ^~~~~~~~~~~~~~~~~~ /root/src/fq_codel_fast/sch_fq_codel.c:652:15: note: (near = initialization for =E2=80=98fq_codel_class_ops.tcf_block=E2=80=99) /root/src/fq_codel_fast/sch_fq_codel.c:667:11: error: initialization = from incompatible pointer type [-Werror=3Dincompatible-pointer-types] .init =3D fq_codel_init, ^~~~~~~~~~~~~ /root/src/fq_codel_fast/sch_fq_codel.c:667:11: note: (near = initialization for =E2=80=98fq_codel_qdisc_ops.init=E2=80=99) /root/src/fq_codel_fast/sch_fq_codel.c:670:13: error: initialization = from incompatible pointer type [-Werror=3Dincompatible-pointer-types] .change =3D fq_codel_change, ^~~~~~~~~~~~~~~ /root/src/fq_codel_fast/sch_fq_codel.c:670:13: note: (near = initialization for =E2=80=98fq_codel_qdisc_ops.change=E2=80=99) cc1: some warnings being treated as errors scripts/Makefile.build:339: recipe for target = '/root/src/fq_codel_fast/sch_fq_codel.o' failed make[2]: *** [/root/src/fq_codel_fast/sch_fq_codel.o] Error 1 Makefile:1552: recipe for target '_module_/root/src/fq_codel_fast' = failed make[1]: *** [_module_/root/src/fq_codel_fast] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-4.15.0-33-generic' Makefile:8: recipe for target 'default' failed make: *** [default] Error 2 --Apple-Mail=_6D3A4CF9-7E7F-4CED-BE1F-9789BAAE7F70--