From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 856523CB35 for ; Fri, 22 Dec 2017 18:38:59 -0500 (EST) Received: by mail-wm0-x22f.google.com with SMTP id y82so26304328wmg.1 for ; Fri, 22 Dec 2017 15:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=VjSJdt2MD7D/h0mi5dXWb+n3vXcSgSzlI9c8ugkF4jE=; b=RtzyPsjhT3eKBuGAW0ZaTsY21H7cICS0MTwB0zeNyGpUdDpIUyjb9ejjWE61Jk9DK7 d5W1OJ1f8RfSc0eAMa47k6ubRzjZ3EitTUDluakDW2bOq/dU1KdY2fkbjjGuKF5F3GI7 1f9vNW0RjGc8uI94ZGiqV3AW44JsxxwNY1ldgTAhU9lMYaB91frIrR6t9oNgZ178eFCo lQ+jG5j5o1aKPLxm83S/FSLzlGCEq1DT3FmWY7TEqbz0K1zE0veb713NQi899lSNRnge 41e+xX7Nw7HRaKilJ1sQ7P9JMdT0JdrobFQUr8M2F9jIIUT5/Zn6hJF/BeTuQXhJe9Rm PxJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=VjSJdt2MD7D/h0mi5dXWb+n3vXcSgSzlI9c8ugkF4jE=; b=JM8YmWCjQa8NXNfH81Fo1QrBP77Xoaugm5AFfEaxes+qSuEFI1Eclr9wfLOzPYrULp AGaJNQPKG08PiHIczk0lQZMTXMG4FqBbvqRJQB9DBPm32kBfGYG0nP/5ie8FFhZJ8oMM KfBhJK7o8dDeFO0YW+aDsB8jUnB69DSTMqeWyYn4UZWgVmJOQHVKWKTRfq3ZHu0qx4IP jZuV7CRoE+e6di6zHXqGYBh/kgyK9g3qqxKKUuPMFHnJoA7Uas4e2qFgAhJccbCldfqP /AbCcMP0to+A+0ZUoKdedJVjQNQ8TugTdNeTC1JaNdKuqBuPsb3MWdYG+Mt049OhamxI e+Qw== X-Gm-Message-State: AKGB3mLDnNKmX2Vl+Bd9d+OFhIy72L7QtHYcGAWTgS45OnSydRJ/qz/G YHoUpTbtpvw5Mhhk+VjeuN5CbQ== X-Google-Smtp-Source: ACJfBosnV03nHPAUTLPUHwLxhlF25RQrgkE8nX9m5fMqSleiOLvvpHuzYE+vc225AiGcsxezSgqsSQ== X-Received: by 10.28.196.70 with SMTP id u67mr14902227wmf.100.1513985938289; Fri, 22 Dec 2017 15:38:58 -0800 (PST) Received: from [192.168.0.3] (179.131.90.146.dyn.plus.net. [146.90.131.179]) by smtp.gmail.com with ESMTPSA id b48sm48867684wrb.1.2017.12.22.15.38.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2017 15:38:57 -0800 (PST) To: Jonathan Morton Cc: Cake@lists.bufferbloat.net References: <31d49a5d-02a2-3dc8-a455-52d453b83bdf@gmail.com> From: Andy Furniss Message-ID: <3b255661-1b16-cc29-958f-bbbedbcbab9e@gmail.com> Date: Fri, 22 Dec 2017 23:38:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 SeaMonkey/2.51a2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Cake] overheads or rate calculation changed? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 23:38:59 -0000 Jonathan Morton wrote: >> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >> >> refactor cake_advance_shaper and ack_filter >> >> cake_advance_shaper now returns a modified len argument to >> reflect cake_overhead. >> skb_ack_filter variable replaced with ack > > Fixed. At one point cake_advance_shaper() was still getting a packet length with overhead correction already applied, and was then applying it a second time. Thanks, seems good now, well, as it was before anyway :-) Still a bit confusing for users having to look at max_len in stats to judge what overhead to use if they know what over ip they want. Maybe some hint in the man page about turn off gro and look at max_len would help when using raw. IIRC this was discussed before, I think conclusion was it's the kernel/ppp being different/wrong sometimes in what it reports to cake. My specific case is pppoe where I need IP + 34. I can see 1500 as max_len, which = IP length so raw overhead 34 is correct. On a pure eth to get the same I need raw overhead 20 as max_len is 1514. This is the (confusing) output from pppoe ./tc qdisc add dev ppp0 handle 1:0 root cake bandwidth 19690kbit raw overhead 34 diffserv4 dual-srchost nat rtt 200ms qdisc cake 1: dev ppp0 root refcnt 2 bandwidth 19690Kbit diffserv4 dual-srchost nat rtt 200.0ms noatm overhead 56 via-ethernet total_overhead 56 hard_header_len 22 Sent 776346756 bytes 883288 pkt (dropped 284882, overlimits 1429302 requeues 0) backlog 0b 0p requeues 0 memory used: 4196096b of 4Mb capacity estimate: 19690Kbit Bulk Best Effort Video Voice thresh 1230Kbit 19690Kbit 9845Kbit 4922Kbit target 14.8ms 10.0ms 10.0ms 10.0ms interval 204.8ms 200.0ms 200.0ms 200.0ms pk_delay 186us 1.6ms 0us 112us av_delay 11us 94us 0us 4us sp_delay 1us 4us 0us 4us pkts 1160 1166876 0 134 bytes 457795 1202631653 0 10176 way_inds 0 3813 0 0 way_miss 1126 10503 0 3 way_cols 0 0 0 0 drops 0 284882 0 0 marks 0 0 0 0 ack_drop 0 0 0 0 sp_flows 0 1 0 0 bk_flows 0 1 0 0 un_flows 0 0 0 0 max_len 746 1500 0 76 On eth raw overhead 34 gives different results, only seeing max_len gives the clue to take 14 to get IP + 34. tc qdisc add dev enp6s0 handle 1:0 root cake bandwidth 19690kbit raw overhead 34 qdisc cake 1: dev enp6s0 root refcnt 2 bandwidth 19690Kbit diffserv3 triple-isolate rtt 100.0ms noatm overhead 48 via-ethernet total_overhead 48 hard_header_len 14 Sent 24102094 bytes 15934 pkt (dropped 1, overlimits 31841 requeues 0) backlog 0b 0p requeues 0 memory used: 27Kb of 4Mb capacity estimate: 19690Kbit Bulk Best Effort Voice thresh 1230Kbit 19690Kbit 4922Kbit target 14.8ms 5.0ms 5.0ms interval 109.8ms 100.0ms 100.0ms pk_delay 0us 1.7ms 0us av_delay 0us 1.7ms 0us sp_delay 0us 229us 0us pkts 0 15935 0 bytes 0 24103608 0 way_inds 0 0 0 way_miss 0 4 0 way_cols 0 0 0 drops 0 1 0 marks 0 0 0 ack_drop 0 0 0 sp_flows 0 0 0 bk_flows 0 1 0 un_flows 0 0 0 max_len 0 1514 0