From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CB09D3B2A4 for ; Fri, 3 Jul 2020 08:54:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593780843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+k8RkC7JKMZr+sP+ag5DuGVQOXCROYbmnKZSv7DDXPs=; b=RxO7nC7avGfbqUI7fscgejRsT8AAudt/LkmKGze2tBQWDsrNhLSmoezZan4n6rE8cJlK9/ yi8NP+CzkkmVHQRuNaWrKKi6mbMNxs2LO7/BShICZMyKzf8SO42PcK71gjXgWgmAWluT5s r2E/yiIBexMhgHcNCeYS9HmHDLkA6XM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-RIHTo6adNXWL7f36P0xS5A-1; Fri, 03 Jul 2020 08:53:59 -0400 X-MC-Unique: RIHTo6adNXWL7f36P0xS5A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8ED861052510; Fri, 3 Jul 2020 12:53:57 +0000 (UTC) Received: from new-host-5 (unknown [10.40.192.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 478C21972A; Fri, 3 Jul 2020 12:53:51 +0000 (UTC) Message-ID: <4297936b4cc7d6cdcb51ccc10331467f39978795.camel@redhat.com> From: Davide Caratti To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , davem@davemloft.net Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net, Jiri Pirko , Jamal Hadi Salim , Ilya Ponetayev , Cong Wang In-Reply-To: <20200703120523.465334-1-toke@redhat.com> References: <20200703120523.465334-1-toke@redhat.com> Organization: red hat Content-Type: text/plain; charset="UTF-8" Date: Fri, 03 Jul 2020 14:53:50 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Subject: Re: [Cake] [PATCH net] sched: consistently handle layer3 header accesses in the presence of VLANs X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 12:54:03 -0000 hello Toke, thanks for answering! On Fri, 2020-07-03 at 14:05 +0200, Toke Høiland-Jørgensen wrote: > while (proto == htons(ETH_P_8021Q) || proto == htons(ETH_P_8021AD)) { maybe this line be shortened, since if_vlan.h has [1]: while (eth_type_vlan(proto)) { ... } If I read well, the biggest change from functional point of view is that now qdiscs can set the ECN bit also on non-accelerated VLAN packets and QinQ-tagged packets, if the IP header is the outer-most header after VLAN; and the same applies to almost all net/sched former users of skb->protocol or tc_skb_protocol(). Question (sorry in advance because it might be a dumb one :) ): do you know why cls_flower, act_ct, act_mpls and act_connmark keep reading skb->protocol? is that intentional? (for act_mpls that doesn't look intentional, and probably the result is that the BOS bit is not set correctly if someone tries to push/pop a label for a non-accelerated or QinQ packet. But I didn't try it experimentally :) ) [1] https://elixir.bootlin.com/linux/latest/source/include/linux/if_vlan.h#L300 -- davide