From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: <cake@lists.bufferbloat.net>
Subject: Re: [Cake] BUG_ON vs WARN_ON
Date: Wed, 5 Oct 2016 16:45:06 +0100 [thread overview]
Message-ID: <451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <BE0049C4-672E-4EF6-9FF9-8EEC974CE22A@gmail.com>
On 05/10/16 16:42, Jonathan Morton wrote:
>
>> On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant
>> <kevin@darbyshire-bryant.me.uk> wrote:
>>
>> How amenable are you to changing all 4 BUG_ON instances in cake to
>> WARN_ON?
>>
>> Linus isn't a complete fan and I'm thinking that producing a stack
>> trace and trying to carry on is more helpful to a remote accessed,
>> no serial interface type device than just killing the kernel dead.
>>
>> Quite possibly other bad things(tm) will happen shortly after...or
>> maybe there will be enough time look at dmesg for that stack
>> trace.
>
> The two in cake_heap_swap() can probably go away completely - they
> were there to make sure the heap algorithms were working correctly.
> They never did trigger, as it happens.
>
> The other two are genuine serious bugs (array overflow) if they ever
> trigger. It’s safer to leave them as-is.
Fair enough :-) I wonder what it was that caused yesterday's issues? I
really must try again when I've more time to get proper access.
Kevin
>
> - Jonathan Morton
>
next prev parent reply other threads:[~2016-10-05 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 15:24 Kevin Darbyshire-Bryant
2016-10-05 15:42 ` Jonathan Morton
2016-10-05 15:45 ` Kevin Darbyshire-Bryant [this message]
2016-10-05 15:53 ` Jonathan Morton
2016-10-05 18:53 ` Jonathan Morton
2016-10-07 13:27 ` Kevin Darbyshire-Bryant
2016-10-07 13:35 ` Jonathan Morton
2016-10-07 13:43 ` Kevin Darbyshire-Bryant
2016-10-05 15:53 ` Dave Taht
2016-10-05 15:55 ` Kevin Darbyshire-Bryant
2016-10-05 15:57 ` Jonathan Morton
2016-10-05 16:38 ` Dave Taht
2016-10-06 3:59 ` Kevin Darbyshire-Bryant
2016-10-06 4:19 ` Dave Taht
2016-10-06 8:12 ` Jonathan Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox