From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00052.outbound.protection.outlook.com [40.107.0.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 522123B25E for ; Wed, 5 Oct 2016 11:45:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=32mEUXrPjpe00MkvN09l3yV7ORlwVBrHeyciV0mP2ZE=; b=AyEIhM9d3UlMykFVWzaiP477wrZ+EBaX6Ft23086CtsM/U7JjklvT7ay/NYsptrRl7keqw76SgH79EegQYTjkg7DyRt+KyoyfGjGzX8aAEhGDE6dBZH+LtAhobzWuJwFcB+iU8fV/i4iOIja2jOMmK2iCssrfz5VKuX7RFB0zX0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; Received: from [IPv6:2a02:c7f:1216:da2b::4007:25d] (2a02:c7f:1216:da2b::4007:25d) by AMXPR07MB118.eurprd07.prod.outlook.com (10.242.70.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Wed, 5 Oct 2016 15:45:09 +0000 To: Jonathan Morton References: <70363372-13a0-a88f-840e-b8e10c685ed7@darbyshire-bryant.me.uk> CC: From: Kevin Darbyshire-Bryant Message-ID: <451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk> Date: Wed, 5 Oct 2016 16:45:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:c7f:1216:da2b::4007:25d] X-ClientProxiedBy: VI1PR10CA0023.EURPRD10.PROD.OUTLOOK.COM (10.165.230.33) To AMXPR07MB118.eurprd07.prod.outlook.com (10.242.70.144) X-MS-Office365-Filtering-Correlation-Id: 13a5a841-77f2-455a-4f31-08d3ed36963a X-Microsoft-Exchange-Diagnostics: 1; AMXPR07MB118; 2:sa+V6aH0tvRGZMpYcyW19qOpEMKVIcRWKX89wlZSSCm1qU8LwYmg8fCkQp+AHNGaUoTqyc7hHFRtMNRCkZwUZvp4vYpeAArGjHfaf/nqBVCaobb9UVSlHKPrYU2fqAbpNcnAYInQmrPxuTeC96P47ljcFKfCJkkIAHiqW1PtvFiftPdIjS1fR/9BDBiCC6b3; 3:iiUflRthjTNHwwDnz7VN8P8cXpXWjZHCnjJKf6kJVi9wCZ8oJACG/ZvokvdhGok2ZlF5nKU/zSgcEjsZBbJMWtk7GYeUC1T++PD3t+YqsI4gOmAz3T1Y9/CSjE6TKMJa; 25:Gia6Hsb/AveEg4m7UNK08Y93WmE2b24WGwi83TzDnqMIy4YfffiWaecszujzY9o2HqEjYvxUacQHpU1aAHZS/EWcSaOsohXXvMMn9IyjCR75yqXFSg2PbTQOws1ND4YPOkBLNA5yCH0qvNkzrpiuNeeKpKShLBrMUJP3A5uASZuJu3AJmxx3n/s0iEH46LL3zmuprJctfRNNR3bCn+dXUkUg+kcrw72TMt8OCKzeUQSyJyOC2ymHKciorZM8N1xznFiHFqygL4Ei2OlsOCtOkbQbJJTMELBNtjG1k2bw4svPh4hftESxKn3FYG5Xmx64wuHaAQBx5HOdiddA+SAotBhPm+lVweT5TE8JjRoQWsykgcymSRromraywCpaSyfunoem6GnyabDOd1fA20Mc1pGvnAIti1Ng01mEIpKXzIQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMXPR07MB118; X-Microsoft-Exchange-Diagnostics: 1; AMXPR07MB118; 31:tIGbbqwwAbzLW473MAYXOWcx9T9uTcJBrlWH2YRXeFg5QV6Ociv+AUoGc9EYCFaweWpaO52bGUFjvAY9D1hGTalP5MxcI0pd9DgrWuIHj2Nekuo4hB+DxUIf6KIIf01A3TVLyyvmsQVh/UqRAeS3MMvyNITrjmWL5yKBZfGK6xjkhE+Gz/HsTi9+/yZN4PDwT1QNbdl1jt3vQE3p260Yf7t8bOVygmpW39FTo9IwZY0=; 4:S5kL3VUjdZmUIM1VaI4bw3hK7s9yS/CsslT7zKEm2xuTDOC7LAcmmErnN1jk5s9TWfYZr/+QOCxzhZwB67HX37iDIv/IIizJiCrCVOKtxIhuMtc8XTY5xt0rh1wDcLQ59U0BLigImtF149nmH6RKEHcrmmrJ8JO31bjdPFUmQ5EuHwIOTF+XPv98jbolqmwRueU1LaNdwUc3tMt/3zHcbp3atfhTchaocQLPXrsuWZKfQqLyCUWfdsEcrSERhRx5cNIwIfDKHfyj1BoavvwG9u4pKRXgiwmrhcSJccYvN7QbY55FpOM2fXcJkZfPSLyThur3ggIcyyLOTN4ypXZHprhoSYLWV5C7hi1su36MFAMkK7SFcYUGdaQapkRRno6uTCH7qF+EA+w8S22iptvAJrBPUgPtGaMCyTTVSyD6xJQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6043046)(6042046); SRVR:AMXPR07MB118; BCL:0; PCL:0; RULEID:; SRVR:AMXPR07MB118; X-Forefront-PRVS: 008663486A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(189002)(199003)(65806001)(65956001)(305945005)(42882006)(31686004)(42186005)(7736002)(8676002)(83506001)(81166006)(7846002)(81156014)(6666003)(2950100002)(65826007)(110136003)(6916009)(92566002)(47776003)(31696002)(64126003)(50466002)(5660300001)(86362001)(189998001)(68736007)(2870700001)(105586002)(101416001)(4001350100001)(97736004)(77096005)(76176999)(50986999)(586003)(54356999)(1706002)(1411001)(33646002)(4326007)(23676002)(74482002)(2906002)(106356001)(19580395003)(19580405001)(36756003)(6116002)(3826002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMXPR07MB118; H:[IPv6:2a02:c7f:1216:da2b::4007:25d]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVhQUjA3TUIxMTg7MjM6NGtFdjdQMjkzaWo3WmlqcnNuWHVtYjlmTEtu?= =?utf-8?B?V3NBcGFpL24vQkNmbEJYcEFpeGQ4S3F3dXJJeVFjcjlXTTlRZUMxdU0wNzcy?= =?utf-8?B?T3hiQzRQSUVOVi9paU1PR1VzKzBtWHZWcVo4UnFLM0x1SVU3YjQ1c1JFZGVO?= =?utf-8?B?K0lrV1BDTjBaQkVSYzM5ZXBKaFRlblJJNXE5NE5sUmgrZU5UODg0QU5UcWZm?= =?utf-8?B?UnliMnpxU045eDFIS3g1bS9VdjI5S1hhaDg1aUk2eTJSVnM3WVpEVlp3TGh1?= =?utf-8?B?SVNWNXovUlhZakllQzRmWDQybVVOQUtOTFpSbjJyWG9ENEswMXc1SVY1WkYx?= =?utf-8?B?TWFTSUcxYmFIOXg2blpoQjIzYTlDaWhWWDRNSGg3TnNmUVVGYWFuRm1KYWcz?= =?utf-8?B?bG5KampRVUJOaUg4d1hONEFtdzFJdXdsYUJISEFFaXJibXY4ck1pN1diV1dr?= =?utf-8?B?RVU2aDdsL3Z0UTFSK0NVeUVHaGZkSTlwWEM1bUU0QjdEcE00QTZKcVdlUlR3?= =?utf-8?B?dlBWa3FJckM4TUd0OVpLa1J2Ykl5OWUremMyVEdUdzlTU3M5eFBUMG1ZeUdx?= =?utf-8?B?N3VteE82V2NYNTgxU3pCbTNxRzl0aGdZc0VqNnNGSlZHSWJZVVpQeVZaU3FH?= =?utf-8?B?Mi9JcllybDNVaVNHNkV3Mi9YL3BidC8yUEhreFZSZ0gwcHI3Sk5BREc3TTNt?= =?utf-8?B?VkRGNGN5WHd6Q1dQN1VmTTBGcXhXV3dKdXNHVDBCT3kvTFRHQ0xRM1JqSXNa?= =?utf-8?B?ZnpZNUdEYzl1TzR3WHVxUmJXcEdYT0VDT0xuVFc1UFFEZXdINkN3T2Z0V0pE?= =?utf-8?B?ckZManpQUDVhUzViRWQ0WEpza0xheHpvd01YTndOM0V5YUsxOEJtcS8wblFG?= =?utf-8?B?Y2lndUQ3TnoyY3JSVzJBaDlaSVlNbWVrbldueFZEdVFEbi9xTkIydWVVTXF2?= =?utf-8?B?eWJ2UUdSeDB5aUpNWHEwd1kzd1pjOHNSWlFPLytlK0lNaTlTRThkNHZqRUp1?= =?utf-8?B?UndCdEYvNGJYOHF6a0dRUm4rUDBOeElzSmxnMnJjdis2OG9IUlRJNUhtVFR5?= =?utf-8?B?ZjZucWcyUlpCM29UWWVLOFhNZTEzcGVIT2s5VUJ2R1dUdDFFR0dZbjBuRDFF?= =?utf-8?B?ZTUxa2VHV0JCOUdrbTF2NzVDT05vZVdXU1czN3IvbFhZMC9WbmthUVp0RnVP?= =?utf-8?B?Qmt5cjgwYU1rYzVTZzNnekdWcWFTb2RxSFhBdi9PQnd6YjhuajdtZVZPeFhj?= =?utf-8?B?ZHBIQTJGcWRrK1d6dWNsNEFaWXZ2bGpzSjdEd2o2aDVac1ByczFISk1pY2xN?= =?utf-8?B?V0ZHQ3NOR0UzQml0OEtCYmZocldoUWd5eFdvbTFjbEh0SHdYMFM1VGY1TW1Q?= =?utf-8?B?blZHRnlEZnNrekRhc3FGVHRUajdCc0xUVGFyRDlTdGhqMVFVOUhxWjhnVUNa?= =?utf-8?B?MHdIeTQ0ek5FY0JOcHZYRGlaMlF3TE1kczlOSWYyYlcxaWd4d2E3aFljTUtI?= =?utf-8?B?NTZ4UlIrNkI0VWpLMTVtWTVwbzhOZXIrOXBwZmpJMVdLdmpTcHpmTC9KR1po?= =?utf-8?B?K0pkSEFCNzhjNy9ueGVKVHNObmZJRUE5RXpJcnR1NlNtdUdveWp6S2w5VktP?= =?utf-8?B?R25ubXBDbmxMMzBkK2pPTlJvbmFVWDd2dUlIRGVLak9wVWJoZURwcUd0U3F6?= =?utf-8?B?VWpHSlZYbU1FWHBXZGhVUm9HMis3RzVzOGtVTHVKWlZxaTRERHlrd2diQW1h?= =?utf-8?B?VzBpRjlCWTVQVXorRVZPWWdkd3lwT1Q1ckcxWFZQdGp2QTVGZy9xa2p5cHND?= =?utf-8?B?OVUzazlHNzdkdTMzRGcvby9hNzRxYTJmVi9MTEpUTStqQT09?= X-Microsoft-Exchange-Diagnostics: 1; AMXPR07MB118; 6:L4BWGznD7pe0bb3qyJ9CB2556RbHUe7eDZEWYG8s/aeCJZuEju9VzsCXLIffsyxzPtZ+jONfHhoo7bWTYskjd4hOgu2FXgHYYMMPHLS7QL0zZJ50QwkHRmAEaXQPRWnCcppEdD8cIzEkA1qbJygDU6zWJhPw0rV8zuBX6z9dlmt8ElZAtKXFKL/L7IfdmIAETS1u/vSJ0EkaIklghVy3uYvH5Abc2wQQr2Te7GuJPugIi1N3mbI6ZJNEEctONFp2fQ4BOGo7chcD0u96Mm8DIN1KE8VApA4xJBM1xl6xSZdJSRm/9s6oGLMTNrNmLbpT; 5:cIrt/Q9VXuG3jcp5tIK1H7qF8oVSjuG7T+xlmSNeFNlw1s+MWBoYjk4NCV4yo+njrNGgr3BxQ0Wg7vsp9rd2vN3AvpCbJrBKa1mj6daoEARv9V+0trWdRVcnt9ZfO07aRfn70egTOj49hE02KX8cQg==; 24:LDP4y3ojCJQzA3i2B97EOzBWhd19EFQD4UA4mm1t/eV1+99d8P4ISciwq3/RejCohl0IhtzrusQC4/rEiXdbPTnbk2LX4mCAOBLvjRcRQFg=; 7:gZdU7FNA1b7ZH+keFvig+8WmSNnTHWQjZdsnSCYxY3de3WcwccpUVZlZknCYoaaTFT7xqNnLFP1or+QZ8MZdgl3AtOfApfhVOgdVEjKcvua0C5ctYM6K7rgbyjNnLmts0ACnJqSLUh/bxZoA1dVIO7yD/r+bJXw/wt1llULwndmacQFteonW9QqDROa/+ZdDj2LhPVUGBko+TBh6H/Wsb0nC8XNGHIIHo5A096EFSikoTtaDYsOtEzGqxSMsMyDx9mfrxJCBqyLB8R8m6Mb55xu19VT+kI0so+fBtwPtQcX0F4hHQ9SvHjuYVmu2QeWV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2016 15:45:09.1532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMXPR07MB118 Subject: Re: [Cake] BUG_ON vs WARN_ON X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 15:45:11 -0000 On 05/10/16 16:42, Jonathan Morton wrote: > >> On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant >> wrote: >> >> How amenable are you to changing all 4 BUG_ON instances in cake to >> WARN_ON? >> >> Linus isn't a complete fan and I'm thinking that producing a stack >> trace and trying to carry on is more helpful to a remote accessed, >> no serial interface type device than just killing the kernel dead. >> >> Quite possibly other bad things(tm) will happen shortly after...or >> maybe there will be enough time look at dmesg for that stack >> trace. > > The two in cake_heap_swap() can probably go away completely - they > were there to make sure the heap algorithms were working correctly. > They never did trigger, as it happens. > > The other two are genuine serious bugs (array overflow) if they ever > trigger. It’s safer to leave them as-is. Fair enough :-) I wonder what it was that caused yesterday's issues? I really must try again when I've more time to get proper access. Kevin > > - Jonathan Morton >