From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 9757321F7B9 for ; Mon, 12 Oct 2015 05:06:59 -0700 (PDT) Received: from u-089-d068.biologie.uni-tuebingen.de ([134.2.89.68]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MCxfb-1ZtY6a13sB-009g5a; Mon, 12 Oct 2015 14:06:51 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: Date: Mon, 12 Oct 2015 14:06:51 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4E2E28FA-954A-4321-A7A6-702EFC93062C@gmx.de> References: <20FAC204-CAA3-4E36-938A-E857EE81C0A3@gmx.de> To: =?windows-1252?Q?Dave_T=E4ht?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:PDnAiPI6CmjrxGREjd447GOd8lVi2HpJU2xBxTW7hDUiyHqh46Z xtm1lOatVNSPUgqmI4sFDsBTKaazY+9N96ZiLG/iuvsTFDDLCC0x6HXxR9aZQfnQGE+OGKM qXlKVFEluBMRqIJYkgRliQUXFUIxqYjOTeLmS8T62d/K1xaR3VNSrGg2h5vmzlNrYMnvir8 qhnXaUM8DVz1W6ecchEbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:kKwqHuQDgi0=:HCND4A/8q7tc/WuLgWkumb nUqxq+jD2POVvLFeCnFfGd9EFElMrM4poM9tSYFA8iYcfRy0DddocZIgcKGHZRJuFpxBQ1NnZ SNm+6/6eMNDO6Bypisx+eV+3Ex6/Bi8FDnJCaRvmWwQVlqfxs+sAoEjYRE6O7Fqzq7stvdZel 6gRzWh/UcXDhwWnNM6G+FfiOmS7nSApYHLpsh8CPOki7JH6Ttb6AWyGTdV83meXRAT8b8LMRC yk0kDqE2RXaVTxJnSXwe3vcHaUFwL1+aMiy4B6lsFo40rNRiO72k4vhzLAFFnQL4CoiIDylWn C3hUwA8XsJ+yWZIZgC5mp+zCF/HgOyG9o9/rYgdNGiNhEPEkZm/J9i9UiOs70kBGX+bcZUXRI zZmUdIpPwdoTDtFj7Wpo0BlyQeBBZbSXArNP1XkTrmmSEb29LqqJvT5S0XduY1lDosS1kE6OE PLWEXAcc5wagPcU3JMxMZzp4DaQPsq22VPcin2qIggF2lfj78AzY8Y7gjpOqnOyF7Uj1s+2Du 1aFc1CoWSXxQSH6VvrScTdIg6K9Wy8Z0hCKijJ+0EYLjiTdMbedabzePBE6lS+GSFaNs6MH73 CD1dTMSgYGwUbNpbBMNyZYDO4qpqECOu8+tW84r/G7L9Hbahsgs4HSUIzXyzbHHkVL+RDWUoG p7zxueDlbi2UbDFjWM2ZVBiv+dJRSOneNBWFua+ZV9QO0F3ZWQhZzdhRyZyk7p1xnKta9k7cA HVppLdwR2u+75S84tPKKhW4dJrt96AFg0omGbr/T/bNsIyIrNKH31KES+s8uBi7FK5zPKlJSZ gVb1VKh Cc: cake@lists.bufferbloat.net, dtaht/sch_cake , dtaht/sch_cake Subject: Re: [Cake] [sch_cake] Merge branch 'exposeinterval' (5541271) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 12:07:22 -0000 Hi Dave, On Oct 12, 2015, at 14:04 , Dave Taht wrote: > sigh. >=20 > In looking this code over again, interval is a 64 bit value in nsec in > our version of codel, and needs no conversion into usec. It also seems > to imply that all the conversion values are wrong throughout the code, > and the api should expose a 64 bit value. But tc will only pass in an unsigned worth of microseconds, so = there needs to be a conversion to nsecs, no? Isn=92t MS2TIME doing that = conversion for us, so maybe we need US2TIME to handle time values passed = from tc (so interval and potentially target). Best Regards Sebastian >=20 > On Mon, Oct 12, 2015 at 1:49 PM, Sebastian Moeller = wrote: >> Hi Dave, >>=20 >>=20 >> On Oct 12, 2015, at 13:16 , Dave Taht wrote: >>=20 >>> um, no, interval needs to be kept in usec, and converted more like I = did. >>=20 >> I have not looked at your code yet. In tc (tc_utils.h or so) = there is get_time() that knows how to deal with the default time = specifiers like sec ms us=85 I believe from the tc side this should be = used to parse the user input, just like Kevin=92s code does. Now this = needs to be passed to sch_cake.c, where I believe Kevin=92s version = expects milliseconds (MS2TIME(q->interval)), which does not do the right = thing if the user specified =93rtf 123usecs=94 on tic=92s cli=85 So just = getting rid of the MS2TIME called should do the trick, no? >>=20 >> Best Regards >> Sebastian >>=20 >>>=20 >>> On Mon, Oct 12, 2015 at 2:36 AM, Dave Taht = wrote: >>>> On Mon, Oct 12, 2015 at 11:28 AM, Jonathan Morton = wrote: >>>>>=20 >>>>>> On 12 Oct, 2015, at 12:24, Dave Taht wrote: >>>>>>=20 >>>>>> This is incorrect for the DC use case. We should be able to have = the >>>>>> target fall below at least 250us. >>>>>=20 >>>>> Hey, I=92m trying to work on this myself, but the code keeps = changing under me. >>>>=20 >>>> Tough. Deal with it. :) Once the rtt option works right toke and I = can >>>> finally go test the >>>> count/2 idea out properly in the testbed, like, today. You = otherwise >>>> have the pen, >>>> as far as I am concerned. >>>>=20 >>>>>=20 >>>>> - Jonathan Morton >>>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> Dave T=E4ht >>>> Do you want faster, better, wifi? https://www.patreon.com/dtaht >>>=20 >>>=20 >>>=20 >>> -- >>> Dave T=E4ht >>> Do you want faster, better, wifi? https://www.patreon.com/dtaht >>=20 >=20 >=20 >=20 > --=20 > Dave T=E4ht > Do you want faster, better, wifi? https://www.patreon.com/dtaht