From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x232.google.com (mail-pg0-x232.google.com [IPv6:2607:f8b0:400e:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2B1223BA8E for ; Tue, 1 May 2018 15:12:48 -0400 (EDT) Received: by mail-pg0-x232.google.com with SMTP id i29-v6so8865146pgn.12 for ; Tue, 01 May 2018 12:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sYNAnubdXUxw9gNvGNxqWz9zOJ+xpsNLyMqmRXF7w3Y=; b=mSvc7o7UMeQA+cP7ale/eFYw8NEILGXyiw+Og31N+VqNs0NWuSf3YAED1Bgn3Z7ltB PQmauaNSYmnf76LKrchFqAlx0bWTxxxgtDaFaX2DQdkCvJesaV+zu0UTghQP/cgOUbc1 rmEyyUJ8QsGgF59pd/px4E5as2WbJu+TZJhHtTSoKtXBRh/hjAGRcIvaK/opTQmkUBte pxlTSneARSOISnB9KSRVfswVqW/K2FSiLV492E05kki3PkJmPsL2QEmj6JqPThGF7BQ+ le5XXDqsuI/UrCIx013jTceJaiFjkBmR5f4g5U9InTPQcv972XJe/8FVIcyhh/YIuBJF bfuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sYNAnubdXUxw9gNvGNxqWz9zOJ+xpsNLyMqmRXF7w3Y=; b=TnIhlXdManLXZvip/EPqh0TGLFenUfBp3EhecuC5idi3DMNcN7YTGg9UuQ5zekN8SA GaCm/aicF7UjsOvcOi5JK1AL847WAmEutZI6F16lQLGWLza66Eo7XH+mF0pd4Xk1wGQ7 Ms+9cQj2jixePSndNcGXGpbfQZ9YyKloTsGXFC+Hk6RVQgzfOlbFkrIruwMW1rlY1oBi SPX0ybuhuuTZ7E/tTvn5Qfo6qDYvPlKDP//+GzTLIKeCLW+JXCl+J5txLsvkzFOz18cu FPVmcLdd17o18XXGdKqwhbYf2ocwAmqM+J9GSvZXpYwbGkd7OD1U224QnfaLcSzWK1pY 8vOQ== X-Gm-Message-State: ALQs6tCFZtET02baFQWbt9uFUH1dfsXC5BrjXptJ2W371ED/iAe5ECY+ 3v78NFuyizlv8MJOovNvn9L1voDv X-Google-Smtp-Source: AB8JxZreggkhN797V+3PCSxsqr+OalO9sNO0+lo2YAzmcBCAaPiP7ZQsJRm3LzEPL2d9G9DAPoLNKQ== X-Received: by 2002:a17:902:bd0a:: with SMTP id p10-v6mr17482366pls.69.1525201967130; Tue, 01 May 2018 12:12:47 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id y18sm3084847pfi.104.2018.05.01.12.12.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 May 2018 12:12:46 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , Dave Taht , Cong Wang Cc: Linux Kernel Network Developers , Cake List References: <20180429213439.7389-1-toke@toke.dk> <878t932ont.fsf@toke.dk> From: Eric Dumazet Message-ID: <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com> Date: Tue, 1 May 2018 12:12:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <878t932ont.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 19:12:48 -0000 On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > *sigh* - can do, I guess. Though I'm not sure what that is going to > accomplish, exactly? I guess that nobody really wants to really review Cake if it is a file with 2700 lines of code and hundreds of variables/tunables. Sure, we have big files in networking land, as a result of thousands of changes. If you split it, then maybe the work can be split among reviewers as a result. Or maybe David Miller can simply merge your patch as is, and hope for the best, I really do not know. It seems you guys spent years/months on work on this stuff, so what is the big deal about presenting your work in the best possible way ? Thanks.