From: Jonathan Morton <chromatix99@gmail.com>
To: Pete Heist <pete@heistp.net>
Cc: "Sebastian Moeller" <moeller0@gmx.de>,
"Toke Høiland-Jørgensen via Cake" <cake@lists.bufferbloat.net>,
"George Amanakis" <gamanakis@gmail.com>
Subject: Re: [Cake] Upstream submission of dual-mode fairness patch
Date: Sun, 3 Mar 2019 18:40:14 +0200 [thread overview]
Message-ID: <511C22FF-64A5-46CA-BFB9-4EA350B76122@gmail.com> (raw)
In-Reply-To: <C545AAFB-0944-4ABF-9F0E-0F70061B1E6D@heistp.net>
> On 3 Mar, 2019, at 6:35 pm, Pete Heist <pete@heistp.net> wrote:
>
> It almost seems like in ingress mode, dropped packets are being counted as bytes transferred, when they weren’t.
Well yes, that's the whole point - at least as far as the shaper is concerned. Ingress mode is supposed to deal with the case where inbound packets have already traversed the bottleneck link *before* Cake gets to choose what to do with them.
But that shouldn't affect fairness, only total throughput. Fairness is not handled by the shaper, but by the (very) extended DRR++ algorithm.
- Jonathan Morton
next prev parent reply other threads:[~2019-03-03 16:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1788.1551352661.3538.cake@lists.bufferbloat.net>
2019-03-01 10:52 ` Pete Heist
2019-03-01 11:01 ` Toke Høiland-Jørgensen
2019-03-01 11:55 ` Pete Heist
2019-03-01 14:40 ` Georgios Amanakis
2019-03-01 16:43 ` Pete Heist
2019-03-02 3:02 ` George Amanakis
2019-03-02 4:47 ` George Amanakis
2019-03-02 10:20 ` Pete Heist
2019-03-03 7:19 ` Pete Heist
2019-03-03 9:53 ` Sebastian Moeller
2019-03-03 9:58 ` Jonathan Morton
2019-03-03 11:26 ` Sebastian Moeller
2019-03-03 12:13 ` Jonathan Morton
2019-03-03 12:53 ` Sebastian Moeller
2019-03-03 16:07 ` Pete Heist
2019-03-03 16:10 ` Jonathan Morton
2019-03-03 16:35 ` Pete Heist
2019-03-03 16:40 ` Jonathan Morton [this message]
2019-03-03 18:48 ` Pete Heist
2019-03-03 19:03 ` gamanakis
2019-03-03 19:49 ` Pete Heist
2019-03-04 2:55 ` Georgios Amanakis
2019-03-04 3:17 ` Jonathan Morton
2019-03-04 4:22 ` Ryan Mounce
2019-03-04 8:27 ` Pete Heist
2019-03-04 13:17 ` Pete Heist
2019-03-04 14:36 ` Georgios Amanakis
2019-03-03 12:06 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511C22FF-64A5-46CA-BFB9-4EA350B76122@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=gamanakis@gmail.com \
--cc=moeller0@gmx.de \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox