From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ui1Qyx+r; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=redhat.com policy.dmarc=quarantine Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id 7141914D85A4 for ; Thu, 20 Aug 2026 15:07:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787231238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WeVXudguVsuHtNFC2uAD4H7Hns3vZwhNpfP4RIg3Bw=; b=Ui1Qyx+rMvOgh+ry54SG48VC8ZD9F7JlsN/KigtYTcSQ3AjxEwtuT6kDiVWfktJeEhwqpS COCw3XpCujiZ0N2Bp4+KLjPjD4Qviken9C3pCXN3Ta/NlTGzjUdWXX5FBopH1vbuaG1Zof dkaVumIsPKZEhWtl2eIZ8s5nyQXleL8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-oBzVHaYAOvSF3CtSBv1aPw-1; Thu, 20 Aug 2026 09:07:17 -0400 X-MC-Unique: oBzVHaYAOvSF3CtSBv1aPw-1 X-Mimecast-MFC-AGG-ID: oBzVHaYAOvSF3CtSBv1aPw_1787231236 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-481558a96e2so1516383f8f.3 for ; Thu, 20 Aug 2026 06:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787231236; x=1787836036; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5WeVXudguVsuHtNFC2uAD4H7Hns3vZwhNpfP4RIg3Bw=; b=U6pALCfNDrIlnxDivvUTJLuYlM63TRjD7YdDrPPrlZeNnqprHx6G7orFBF54EE56Kd C6rlmGcQtzfuDeg2RwvQVzhcskkq4IkinpVAJR9q4MjGlJNWyE+gcwYK+aLE29TZ3mvB YLy5Q1CXN6aTxCZ3R1EcvrnWtJyzPCtA+rc9+OhxILm5ePVH7WJvDILVFEa3mkHwDwbn 8Mn6BVvP18V5f3oFuNG9ulRb8DMnaPwm171Ouwlb/DN1HD/VrYe5Y1hMT22uYGnu7DJE Gde3YAeEB4Xvcq8jIcJ0nV8uY9qyNIYUBoaXtskiMfPY7CllJscV7D2LG7T8AGv7OIxr JiXg== X-Forwarded-Encrypted: i=1; AHgh+Rrft1Y8S6Vfn9ovTga1kHlc4krzTPZOV6UHjr8vvnf+ekOR75kBEt1BEls83SxccQ+g71Zd@lists.bufferbloat.net X-Gm-Message-State: AOJu0YwJJbsoSKzWWyH7HdtAJo6Tt+0s2nkrYqcv5AHGwDkT1cfzDoHT 6NkS6bRTbYELSM2F+RPesqRMGfuXbUBlL/X7b5K5A8uYo7x6C6kQtzr12TeyGn0mN2aQrYno6Of jI6XoRPo8xKkdQgEzxSGMcFX099A8WaHdbAJDCJPkcG9HRJELY1tUBkykDLJkA1Y= X-Gm-Gg: AR+sD12hXr+yJPk6tQavBwUC927sk05f5VNiMeWM//a2Go+HWuEZOM40TDUva5rFKPY eQamvWktUqjQmi4tUQj1uat2wpR+FtFCW/NybjKwk+A1z3SuAmIzJWSDtLVJnnC8wA8gai8UrAs WAFxeTnqH7qV5E46nTvaj3TuAy5J8+1NLC/1rluaWoo3Bn5P+YcULDPvm8YWNu3k0m0F5TVmSYt rrpsh6oyQKJP/Kd1ZKcGpQkfCmemGQR6JvlNCMPDWTlylM7/CAKL3JbHrNxY/xX0DRajXPkeL1h quVPW6d3rbeTiGeSouVbupcljXCyaPnWZdYCgU1mawow1tYpeXnNpaqS64tiNeY/7L5Sff73X5h WIPqkWJ/wOQkBbwUYmDsHDlAX4CkTdlRU7yzEvyugoGFU9oQpe45lS/G7Dcd2dzmbDKot1akmKx Y= X-Received: by 2002:a05:600c:8b81:b0:499:8ff5:8ec4 with SMTP id 5b1f17b1804b1-499aa1802a9mr248051715e9.3.1787231235968; Thu, 20 Aug 2026 06:07:15 -0700 (PDT) X-Received: by 2002:a05:600c:8b81:b0:499:8ff5:8ec4 with SMTP id 5b1f17b1804b1-499aa1802a9mr248050695e9.3.1787231235530; Thu, 20 Aug 2026 06:07:15 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aaef1665sm148727235e9.5.2026.08.20.06.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 06:07:14 -0700 (PDT) Message-ID: <531993fb-2485-41fe-8ae0-dfa170a9001a@redhat.com> Date: Thu, 20 Aug 2026 15:07:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ooonea , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260816012109.2865223-1-ooonea@gmail.com> From: Paolo Abeni In-Reply-To: <20260816012109.2865223-1-ooonea@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YNfeFjRXJTAUAPxL9PVBOhW-_GyrcrdicciPmcFu9dk_1787231236 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-MailFrom: pabeni@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: RUTPNG5FUOGZH7CAX7XE2IELWTDCNRNW X-Message-ID-Hash: RUTPNG5FUOGZH7CAX7XE2IELWTDCNRNW X-Mailman-Approved-At: Thu, 20 Aug 2026 15:17:07 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/16/26 3:21 AM, ooonea wrote: > CAKE's autorate-ingress path intends to limit shaper reconfiguration to > once per 250 ms, but last_reconfig_time is only checked and never updated. > Since the field stays zero, every qualifying capacity-estimate window can > call cake_reconfigure(), causing avoidable rate churn and scheduler work > under bursty traffic. > > Store the current timestamp when autorate actually reconfigures the qdisc > so the guard enforces the intended interval. > > Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") > Assisted-by: Codex:gpt-5.5 > Signed-off-by: ooonea The SoB must contain your real full name, and not a nick. /P