From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 426A13B2A4 for ; Thu, 17 May 2018 07:56:29 -0400 (EDT) Received: by mail-pl0-x243.google.com with SMTP id e6-v6so2399994plt.11 for ; Thu, 17 May 2018 04:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fZEae4QigmllNLDnlG+8VXDZGRMVTwJus7y9vdIX9Hg=; b=m3QEFyjhMSJQAEEPk8KQ32nxZpwIshhaLKJHIHxXq9sflYLyzsDJoG2MWGlpd3Momi MYVUsmwGucULPL/r4ydEtXhJ6/TV7XDVHXMgYDZggINOIfFN5Bi1feVVIzT5VbvrwZjk 7/obBJJ06bw01v3UHCljNlrfl0Igynkd5pcSbXqeuswkTakxOng0p/7z0jbUyyxT0+3I W5f94Fs3yTcJJ3cZQpvj+J2HPvm/l6dG6E1od9by4ThvbwoW5SMfI7D8QJbJoAJw4IRm LGYMQ4OUG06hi3SSZQ2fidUIJNaXf94VOTZRhgeYw8jGb0et4l2vsHhYJnNOW8sSKNBU CY6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fZEae4QigmllNLDnlG+8VXDZGRMVTwJus7y9vdIX9Hg=; b=H1r51zbOdtp928rAwIOM9Ehp/vnK5xWLeY0eCIWoE4mqN5i9yUysWrzgOrlrg8pJci D3vZTjmV1J0HbLnCZY+XbV19wEa2JU+IwGvke1eGiN3WB43PrBEzqUKnpdGeOkaL4/QG saipp6HPv2qkdFctFah24Cn73aEe1U3RtIoLVUn1vqvGNt8wl16ZZLtM6ecwr1oenwUb Cu9UKjI2dvi28B01ARYOh3N3gy1AvjpqNT6xO7N2Iti63QrcEEs60KE3SEi4jyufkSGk kZfUNkHas4/qgocbQCpaCglQ1CcldbgasFTYL4w7vTtQ4Ly37W2J/2JhbsbSomdKckgc qUeg== X-Gm-Message-State: ALKqPwfswSiGEerSDnrMAVbW6gyN/UklIFgQJ+KdNp1V//pBaFf0Tzgs 5kd26VFgGIWGLnvZc3I3Tq9zB8yo X-Google-Smtp-Source: AB8JxZqyMriyWR6qaXPVM8ZuwYW4G2LWQKa9rLksaxsMg7gWAyfrDnWJStpGPL03jxPKxZySrYn5KQ== X-Received: by 2002:a17:902:8541:: with SMTP id d1-v6mr5153477plo.106.1526558187962; Thu, 17 May 2018 04:56:27 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id u69-v6sm9910430pgb.42.2018.05.17.04.56.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 May 2018 04:56:27 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net References: <152650253056.25701.10138252969621361651.stgit@alrua-kau> <152650254614.25701.1377066681230937234.stgit@alrua-kau> <87in7my196.fsf@toke.dk> From: Eric Dumazet Message-ID: <541d62af-3938-5fdc-666c-dd243fa465b5@gmail.com> Date: Thu, 17 May 2018 04:56:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87in7my196.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 11:56:29 -0000 On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > > We don't do full parsing of SACKs, no; we were trying to keep things > simple... We do detect the presence of SACK options, though, and the > presence of SACK options on an ACK will make previous ACKs be considered > redundant. > But they are not redundant in some cases, particularly when reorders happen in the network.