[Cake] Coding Style changes

[Cake] Coding Style changes

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Hello All,

Unless anyone has any objection/has already done the work etc I'm going
to make a start on getting sch_cake.c passing linux 'checkpatch'. 
Hopefully will get some time today between shows I'm mixing and will
continue 'fiddling' (as my wife calls it) during the week 'till done. 
I'll start on spacing issues, then deal with the resulting long lines
and so on.

Kevin


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

Re: [Cake] Coding Style changes

[Stephen Hemminger]

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]

Please do cake is long overdue to be upstream. I am firm believer in trial
by fire. Waiting "until its done" hasn't helped other projects

[-- Attachment #2: Type: text/html, Size: 169 bytes --]

Re: [Cake] Coding Style changes

[Dave Taht]

On Sun, Oct 4, 2015 at 8:36 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> Please do cake is long overdue to be upstream. I am firm believer in trial
> by fire. Waiting "until its done" hasn't helped other projects

Little things like finding a way to keep a roof over jonathon's head
took precedence.

I agree that we are very close to being done enough for submittal
upstream. While I have some issues with the codel implementation, it
would be easy to fix after we get more testing done.

I have all day set aside tomorrow with jesper to look this over and
get some 10gigE testing done.  Kevin, if you want to hand back the
pen, and if jon remains silent on the other global changes, I have
high hopes to make a serious dent on the issues remaining.

Key to me are several other global search and replaces to make the
code a little cleaner,
in addition to the checkpatch stuff.  Jonathon, either you do it, or I
do it... tomorrow.

Also waiting on jonathan has been making a binary incompatably change
to the API.  I do that, tomorrow....

Tomorrow is the first day back from vacation, and oooh, I'm ready.

If you have commits pending please


>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
>



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] Coding Style changes

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On 04/10/15 20:42, Dave Taht wrote:
> I agree that we are very close to being done enough for submittal
> upstream. While I have some issues with the codel implementation, it
> would be easy to fix after we get more testing done.
>
> I have all day set aside tomorrow with jesper to look this over and
> get some 10gigE testing done.  Kevin, if you want to hand back the
> pen, and if jon remains silent on the other global changes, I have
> high hopes to make a serious dent on the issues remaining.
You have the pen ;-)  I notice you've merged all the stuff I've sent so
far, great stuff!
Today has been busier than expected so not as much done on style as I
hoped, probably not worth sending in to be honest.
Good luck for tomorrow, sounds like a busy day.  Let me know when it's
'settled' and I'll happily pick up what I can.

Kevin



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]