Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Dave Taht <dave.taht@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Cake parameter anomaly?
Date: Tue, 13 Oct 2015 14:22:16 +0100	[thread overview]
Message-ID: <561D0588.9030108@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAA93jw6U2HeUns05rFEJPbWvW4Q1mv2s7UUAgY+0v+uy8UHd_A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2068 bytes --]

Removed - Thermonuclear device not required ;-)

On 13/10/15 12:53, Dave Taht wrote:
> nuke it then.
>
> On Tue, Oct 13, 2015 at 1:26 PM, Kevin Darbyshire-Bryant
> <kevin@darbyshire-bryant.me.uk> wrote:
>> I can't find anything that uses "TCA_CAKE_ACTIVE_FLOWS" in the current
>> codebase of ether cake or tc-adv, so if we're in the current business of
>> breaking API/ABI stuff then shouldn't it go?
>>
>> The output of 'sparse & bulk' flows is still there in the output stats
>> shown by tc, so is obviously in use.
>>
>> On 13/10/15 11:34, Dave Taht wrote:
>>> active_flows was a parameter that was in one version or another that
>>> was exposed to the API. It was very useful and interesting.
>>>
>>> On Tue, Oct 13, 2015 at 12:22 PM, Kevin Darbyshire-Bryant
>>> <kevin@darbyshire-bryant.me.uk> wrote:
>>>> Hi List,
>>>>
>>>> In pkt_sched.h we see an enumeration for 'TCA_CAKE_ACTIVE_FLOWS':
>>>>
>>>> /* CAKE */
>>>> enum {
>>>>         TCA_CAKE_UNSPEC,
>>>>         TCA_CAKE_BASE_RATE,
>>>>         TCA_CAKE_DIFFSERV_MODE,
>>>>         TCA_CAKE_ATM,
>>>>         TCA_CAKE_FLOW_MODE,
>>>>         TCA_CAKE_OVERHEAD,
>>>>         TCA_CAKE_ACTIVE_FLOWS,
>>>>         TCA_CAKE_RTT,
>>>>         TCA_CAKE_TARGET,
>>>>         __TCA_CAKE_MAX
>>>> };
>>>> #define TCA_CAKE_MAX    (__TCA_CAKE_MAX - 1)
>>>>
>>>> These enumerations are normally used for passing options from tc into
>>>> the cake module, but at the present time, nowhere in either cake or tc
>>>> can I see use of 'ACTIVE_FLOWS'.  It's not read as an input into cake,
>>>> nor is it sent out of cake back to tc via the nla_policy.
>>>>
>>>> Is this a 'typo' from when bulk/sparse flows reporting was put into the
>>>> stats, or is it some as yet unimplemented feature?
>>>>
>>>> I've meant to ask about this before but it sort of got lost.
>>>>
>>>> Kevin
>>>>
>>>>
>>>> _______________________________________________
>>>> Cake mailing list
>>>> Cake@lists.bufferbloat.net
>>>> https://lists.bufferbloat.net/listinfo/cake
>>>>
>>>
>>
>
>



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

      reply	other threads:[~2015-10-13 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 10:22 Kevin Darbyshire-Bryant
2015-10-13 10:34 ` Dave Taht
2015-10-13 11:26   ` Kevin Darbyshire-Bryant
2015-10-13 11:53     ` Dave Taht
2015-10-13 13:22       ` Kevin Darbyshire-Bryant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561D0588.9030108@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox