From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nm33-vm9.bullet.mail.ne1.yahoo.com (nm33-vm9.bullet.mail.ne1.yahoo.com [98.138.229.73]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5D3493B29E for ; Tue, 11 Apr 2017 10:14:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1491920093; bh=tr6Mzd+BRC5F4Z+F9RXVVOQZnVA0UaXUUMCfPzh1FEU=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=UZvACOUA3gib/DlijBY8ymthPsFclWxK2YI1DrOHQZpy/MMXP2RNCr4vzt197HcIWupbIcwhj9jUZley+zJ7tM5In5CtWrrEUYG7AXmjV0T5BxYVlm6ERmo+VN4op/acqJ9sm+wem9TB0dMqjDgAkOyA5OOfSiTqMgU0c/6BMSEP9aqo7Oos//NMjfRLarqZicR5qRUu5EV+CTHlbvwJVpuMSnJkdF+GuoWK7Ikb5H/Ceo5bgu+1Pm4APZdIEeZGfaOZx6wjw9ivvoIJouP05Uft3uhlFywLtOcNC90VWaDEnkqc8oXuihTXPdORuf+iQ5e2QVe9xAmVaocu97rrIA== Received: from [127.0.0.1] by nm33.bullet.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:14:53 -0000 Received: from [98.138.226.180] by nm33.bullet.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:11:53 -0000 Received: from [98.138.88.233] by tm15.bullet.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:11:53 -0000 Received: from [127.0.0.1] by omp1033.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:11:53 -0000 X-Yahoo-Newman-Property: ymail-4 X-Yahoo-Newman-Id: 282743.45120.bm@omp1033.mail.ne1.yahoo.com X-YMail-OSG: N9..5dcVM1niI_5j3xRLcJf2gTurqfBKVP1k5oZsc1CqM5pqR.Rslto.xehy1Jc KX5SRf9hAcUAJ81YqeJnJz4Clm8U2o2JvDEPZbSzuLSHUm_mBBa1I8RdKkxRPpMe404FAbezv871 tffLxafugS2PsBs6y2J8c1hobAh1V2ND4UKG4v24nMLkeICbXjEwnUDSXcwL4VXvVEpezMJT7zjv lujSh9itcmSV_iIanVqVRzGnw6DOK6wCUk2CRhfxT.cxGqHcTdnLT5z7AGOfB9EMf.vX6LRWSDl0 K0bIQSdXFuiVO5k5pEw1o95k3KWemsXGT2JDX6Y7AJE2lp790aKAgWNKYPl3A7V5.alg3XX8HuHM .h.m_aScU9w1oQhJWPLsp2QFzNeMG0RTsUdV8RCY96pFnnq9ELvE0smgSTjL52xJyKXqHNTUe7HC Di0v_CKR9MdvCBup0L6uQCA6qWvU37PerSWzubWxZfuIiKcPIt1o6CLX2imafBM27DHK.y4lYoIi UDubStAZKaQAlf.aKez9LMGvG.u47xdBNGCbe8zlBMsYJFg-- Received: from jws200202.mail.ne1.yahoo.com by sendmailws131.mail.ne1.yahoo.com; Tue, 11 Apr 2017 14:11:52 +0000; 1491919912.791 Date: Tue, 11 Apr 2017 14:11:52 +0000 (UTC) From: George Amanakis To: "cake@lists.bufferbloat.net" Message-ID: <562380961.557946.1491919912568@mail.yahoo.com> In-Reply-To: <1698783902.612018.1491919195146@mail.yahoo.com> References: <1698783902.612018.1491919195146.ref@mail.yahoo.com> <1698783902.612018.1491919195146@mail.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_557945_1639298504.1491919912567" X-Mailer: WebService/1.1.9374 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 Subject: [Cake] Fw: Choosing a tin to work on X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 14:14:54 -0000 ------=_Part_557945_1639298504.1491919912567 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jonathan, I have some questions regarding the algorithm to choose a tin to dequeue fr= om in sch_cake.c:-----------8<------------ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int oi, best_tin=3D0; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0s64 best_time =3D 0xFFFFFFF= FFFFFUL; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for(oi=3D0; oi < q->tin_cnt= ; oi++) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int= tin =3D q->tin_order[oi]; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0b = =3D q->tins + tin; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if(= (b->sparse_flow_count + b->bulk_flow_count) > 0) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0s64 tdiff =3D b->tin_time_next_packet - now; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0if(tdiff <=3D 0 || tdiff <=3D best_time) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0best_time =3D tdiff; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0best_tin =3D tin; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} -----------8<------------ 1) best_time is defined as a positive signed integer, this equals to 78 hou= rs if I did the calculations right. Why did you choose this? Did you mean t= o define it as "-1"? 2) If you meant to define it as "-1", the condition " tdiff <=3D best_time"= would not matter. I can see no case where " tdiff > 0" and " tdiff <=3D be= st_time". Could you shed some light into this? Thank you, George ------=_Part_557945_1639298504.1491919912567 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Jonathan,
I have some questions regarding the algorithm to choose a tin = to dequeue from in sch_cake.c:
-----------8<------------
 &= nbsp;      int oi, best_tin=3D0;
  &n= bsp;     s64 best_time =3D 0xFFFFFFFFFFFFUL;
        for(oi=3D0; oi < q->= ;tin_cnt; oi++) {
         =    int tin =3D q->tin_order[oi];
   &nb= sp;        b =3D q->tins + tin;<= br>            = if((b->sparse_flow_count + b->bulk_flow_count) > 0) {
 &nb= sp;            =   s64 tdiff =3D b->tin_time_next_packet - now;
  =             &nb= sp; if(tdiff <=3D 0 || tdiff <=3D best_time) {
  &n= bsp;            = ;     best_time =3D tdiff;
   &n= bsp;            = ;    best_tin =3D tin;
     = ;           }
&nb= sp;           }
&= nbsp;       }
-----------8<-------= -----

1) best_time is defined as a positive signed integer, this equ= als to 78 hours if I did the calculations right. Why did you choose this? D= id you mean to define it as "-1"?
2) If you meant to define it as "-1", = the condition " tdiff <=3D best_time" would not matter. I can see no cas= e where " tdiff > 0" and " tdiff <=3D best_time".

Could you sh= ed some light into this?

Thank you,
George




------=_Part_557945_1639298504.1491919912567--