Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Fixing iproute2 compile
Date: Wed, 21 Oct 2015 11:31:18 +0100	[thread overview]
Message-ID: <56276976.4080403@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <874mhlsg7z.fsf@toke.dk>

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]



On 20/10/15 16:38, Toke Høiland-Jørgensen wrote:
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>
>> iproute2 commit 6256f8c9e45f01187b297a576e148534a393c990 introduced a
>> backup definition of 'offsetof' macro in utils.h presumably to cover
>> the case where it wasn't defined elsewhere. Anything post that
>> iproute2 commit (Dave's tc-adv repo as example) will have this macro
>> defined courtesy 'utils.h'.
> Okay, so I just merged the net-next upstream branch of iproute2 into the
> cake repository. It now builds for me on both Debian Wheezy (i.e.
> ancient) and Arch Linux (i.e. fairly recent).
>
> -Toke
It builds here now on Mint too :-)

I still think including <stddef.h> in q_cake.c is the most sanitary way
to go.  gcc for example does its own version of the 'offsetof' macro.

Who do I ask and how do I go about commit access to kau.toke.dk ;-)



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

  reply	other threads:[~2015-10-21 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 16:01 Toke Høiland-Jørgensen
2015-10-19 16:31 ` Kevin Darbyshire-Bryant
2015-10-20 15:33   ` Toke Høiland-Jørgensen
2015-10-19 16:41 ` Kevin Darbyshire-Bryant
2015-10-19 21:17   ` Kevin Darbyshire-Bryant
2015-10-20  9:13     ` Kevin Darbyshire-Bryant
2015-10-20 15:38       ` Toke Høiland-Jørgensen
2015-10-21 10:31         ` Kevin Darbyshire-Bryant [this message]
2015-10-21 11:38           ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56276976.4080403@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox