Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] Correct 'change' behaviour
Date: Tue, 3 Nov 2015 17:54:03 +0000	[thread overview]
Message-ID: <5638F4BB.1000208@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <87k2pzns29.fsf@toke.dk>

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

On 03/11/15 13:14, Toke Høiland-Jørgensen wrote:
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>
>> Interestingly I think the opposite. On a change parameters should be
>> left alone unless they're the thing I'm changing. It's a 'change' to
>> an instantiation, *not* an instantiation if you get my drift.
> Yes, that is indeed implied in the 'change' verb. However, the tc verb
> is 'replace'. If we go with the "leave things alone" paradigm, there
> will need to be some way to explicitly specify defaults...
>
> -Toke
Toke,

At the risk of bringing up a recent unfortunate bit of change
management, there was a lot of discussion/confusion over calculated
targets/intervals due to a change that ended up using uninitialised
variables in those calculations.  Certainly I remember 95mS targets
being a symptom of that amongst other things, and I also remember there
being a 'default' statement of 'that's a tc issue' when it was nothing
of the sort.

I'd like more evidence of there being an issue (steps to repro) and how
it manifests before stating 'bug in tc change/replace' whatever.  Call
me pedantic

Kevin (the pedantic)


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

      parent reply	other threads:[~2015-11-03 17:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 12:59 Toke Høiland-Jørgensen
2015-11-03 13:11 ` Kevin Darbyshire-Bryant
2015-11-03 13:14   ` Toke Høiland-Jørgensen
2015-11-03 17:24     ` Jonathan Morton
     [not found]       ` <87oafbat54.fsf@toke.dk>
2015-11-03 17:32         ` Jonathan Morton
2015-11-03 17:51           ` Toke Høiland-Jørgensen
2015-11-03 19:07             ` Toke Høiland-Jørgensen
2015-11-03 19:14               ` Dave Taht
2015-11-04 11:09                 ` Toke Høiland-Jørgensen
2015-11-04 14:28                   ` Sebastian Moeller
2015-11-04 18:04                   ` Kevin Darbyshire-Bryant
2015-11-04 18:51                     ` Toke Høiland-Jørgensen
2015-11-04 18:55                       ` Sebastian Moeller
2015-11-03 17:54     ` Kevin Darbyshire-Bryant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5638F4BB.1000208@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox