From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: "cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] More on 'target' corner cases - rate/target/interval confusion?
Date: Thu, 5 Nov 2015 16:41:56 +0000 [thread overview]
Message-ID: <563B86D4.6030704@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <8737wnnpco.fsf@toke.dk>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On 03/11/15 14:12, Toke Høiland-Jørgensen wrote:
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>
>> At the moment cake is effectively saying that it expects stuff in tin
>> 4 to take 4 times as long to send/its packets are 4 times as big
>> depending which warped view you care to take :-)
> Yup, exactly. However that can be true because tin 4 is shaped to 1/4
> the rate; so for 1 packet, that is actually true.
>
> However, it's not really a shaping, it's a threshold. Or is it? As I
> said, I need to go read the code :P
>
> -Toke
Following this up: The existing code is correct, or is certainly much
more correct than some changes I've been experimenting with :-) The
bottom line is that passing the true 'line' rate and hence related
target/intervals for each tin rather breaks the class/tin shaper,
something I proved with the aid of flent. 'b->tin_rate_bps = rate;' is
really a reporting construct and isn't actually used as an active part
of code.
So I'm gradually understanding things....by breaking them and putting
them back together :-) The exact mechanism for shaping eludes me at
the moment (I suspect 'threshold') and quite what effect 'target' and
'interval' really have again is something to experiment with.
Fun!
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]
next prev parent reply other threads:[~2015-11-05 16:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 12:13 Kevin Darbyshire-Bryant
2015-11-03 12:31 ` Dave Taht
2015-11-03 12:46 ` Toke Høiland-Jørgensen
2015-11-03 13:49 ` Sebastian Moeller
2015-11-03 13:56 ` Toke Høiland-Jørgensen
2015-11-03 14:10 ` Kevin Darbyshire-Bryant
2015-11-03 14:12 ` Toke Høiland-Jørgensen
2015-11-05 16:41 ` Kevin Darbyshire-Bryant [this message]
2015-11-08 10:19 ` Kevin Darbyshire-Bryant
2015-11-08 10:50 ` Toke Høiland-Jørgensen
2015-11-08 16:36 ` Jonathan Morton
2015-11-08 19:19 ` Sebastian Moeller
2015-11-09 12:12 ` Kevin Darbyshire-Bryant
2015-11-09 15:07 ` Jonathan Morton
2015-11-09 20:46 ` Kevin Darbyshire-Bryant
2015-11-16 12:22 ` Kevin Darbyshire-Bryant
2015-11-16 12:41 ` Jonathan Morton
2015-11-16 13:46 ` Kevin Darbyshire-Bryant
2015-11-16 13:50 ` Sebastian Moeller
2015-11-16 13:34 ` Sebastian Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B86D4.6030704@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox