From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: <cake@lists.bufferbloat.net>
Subject: Re: [Cake] backward compatibility cruft and possible performance optimizaton
Date: Fri, 20 Nov 2015 12:56:28 +0000 [thread overview]
Message-ID: <564F187C.1030009@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAA93jw7YTfp9dyan8MA2J92TTiE3AwpYc3dphqjqN6g=GtrD+Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On 20/11/15 12:25, Dave Taht wrote:
> I just pushed a change cleaning up the typedefs.
Concerned about some of those changes. Are you sure that using u32/s32
where unsigned int/int were used before is as fast? I understood 'int'
to be the fastest type for at least 16 bits. For example, dscp is
actually only 6 bits wide, even 16 bits is excessive but I originally
chose 'unsigned int' cos in theory it should be more than wide enough
and fast. Similarly 'shift' - it's only ever going to a positive
integer between 32 & 0, it doesn't need to be 32 bits wide.
Hopefully I'm not being stupid.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]
prev parent reply other threads:[~2015-11-20 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 12:25 Dave Taht
2015-11-20 12:56 ` Kevin Darbyshire-Bryant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F187C.1030009@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox