[Cake] GSO super-packets, classification (tin) & DSCP washing

[Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

Hiya,

Whilst I was mixing some football (soccer for those across the pond)
last night, a naughty question popped into my head related to GSO
packets.  From what I understand a GSO packet is actually a collection
of packets, in essence passed to the NIC (or through the stack) as a
'lump' of data which is then pulled apart as late in the process as
possible.  This led to the following questions.

First off, DSCP washing as implemented, only washes the GSO packet..I'm
assuming effectively the first contained packet only.  This is unfortunate.

That question led to the implied observation that 'tin classification'
based on DSCP is also decided upon by the GSO packet and not the packets
contained therein.  Even if cake decides to peel the GSO because it will
affect flow isolation, it still doesn't individually classify each
packet and potentially puts some of them in the wrong queue.  I
appreciate this has some unfortunate CPU usage implications.

I also pondered if there's a small cpu advantage to wash on de-queue
rather than enqueue, especially if the wash procedure is enhanced to
traverse a GSO aggregate.







[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]