From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: <cake@lists.bufferbloat.net>
Subject: Re: [Cake] always or never peeling at unlimited speed?
Date: Mon, 23 Nov 2015 11:35:11 +0000 [thread overview]
Message-ID: <5652F9EF.6090103@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAA93jw63NRZoZLZBsBXuCp7z9KXwsMp0bo9xRqiey6g71iV7kQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]
On 20/11/15 12:27, Dave Taht wrote:
> // FIXME: We always peel at unlimited speed
> if (unlikely((len * max_t(u32, b->bulk_flow_count, 1U) >
> q->peel_threshold && skb_is_gso(skb)))) {
My initial gut reaction was 'never peel in unlimited mode' until I
thought about it a little more. Unlimited is 'shaper off' rather than
my silly English language default of 'super fast, there's no limit'. I
was reminded of my dream where an ADSL driver had BQL so cake could run
'unlimited' - and ADSL isn't 'super fast'.
> In either case we could perhaps do better with the rate estimator
> giving us a saner peel threshold???
Care is needed here. A peel threshold of '0' is used as a flag that ATM
framing is in use and hence things are always peeled. I'm curious as to
why a non zero overhead isn't also considered a reason to peel?
>
>
>
> Dave Täht
> Let's go make home routers and wifi faster! With better software!
> https://www.gofundme.com/savewifi
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]
prev parent reply other threads:[~2015-11-23 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 12:27 Dave Taht
2015-11-23 11:35 ` Kevin Darbyshire-Bryant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652F9EF.6090103@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox