Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: [Cake] GSO peel behaviour tweaks
Date: Tue, 24 Nov 2015 09:12:51 +0000	[thread overview]
Message-ID: <56542A13.3010307@darbyshire-bryant.me.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

I've just pushed 2 commits related to GSO peeling behaviour to master.

1st tweak is at worst benign and at best removes a multiply compare for
every packet enqueued.  I'd like to think the optimiser in the compiler
would have done what I've done explicitly (in essence check this is a
gso packet 1st before thinking about peeling it) but when I checked on
x86_64 there was a definite difference in produced code.

2nd tweak is *not* benign.  In essence this forces peeling if either ATM
framing or packet overhead is specified.  Previously only ATM framing
forced peeling.  I think this is more correct but unfortunately will be
slower.

Commits can be reverted - feel free :-)


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

             reply	other threads:[~2015-11-24  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  9:12 Kevin Darbyshire-Bryant [this message]
2015-11-24 10:48 ` Dave Taht
2015-11-24 10:55   ` Kevin Darbyshire-Bryant
2015-11-24 10:52 ` Sebastian Moeller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56542A13.3010307@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox