From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0089.outbound.protection.outlook.com [157.55.234.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 286FD3B2A2 for ; Wed, 1 Jun 2016 06:02:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gi6O01JvVkyG9EGBNaJRnwhqqyvmAWdyjgP+umjZEr0=; b=KE8sj1MlRdnU7Al8ex27+je1j7/2eBZ8ggZLfK22NL0qAHu7ezg0PVib+RuNbBN7lWnCO+4zTOsoyQWrWcMzht1gcODRDH4bdTyIxA9A63+I4G3CwIyiQMnS/1vD7S4mgAnXbKNAI8z3zMshT4so26URPT3rFoW0h/NSsfhnpao= Authentication-Results: noreply.github.com; dkim=none (message not signed) header.d=none;noreply.github.com; dmarc=none action=none header.from=darbyshire-bryant.me.uk; Received: from [IPv6:2001:470:183f:da2b::4007:25d] (2001:470:183f:da2b::4007:25d) by HE1PR07MB0937.eurprd07.prod.outlook.com (10.162.27.143) with Microsoft SMTP Server (TLS) id 15.1.506.9; Wed, 1 Jun 2016 10:02:07 +0000 To: lede-project/source , lede-project/source , References: CC: Mention From: Kevin Darbyshire-Bryant Message-ID: <574EB29B.1000405@darbyshire-bryant.me.uk> Date: Wed, 1 Jun 2016 11:02:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2001:470:183f:da2b::4007:25d] X-ClientProxiedBy: AM4PR0401CA0005.eurprd04.prod.outlook.com (10.167.83.15) To HE1PR07MB0937.eurprd07.prod.outlook.com (10.162.27.143) X-MS-Office365-Filtering-Correlation-Id: b5f29178-d20f-461e-35ae-08d38a03ca7a X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB0937; 2:Yjfzo0GgLTsLtybxgYdmjBiO/Q6h5Ymi7fxBajWYYF1auPwQMgjF5xsXlY/AmwFbuPXwUULSBr/as1yFw17BBTMPRvQ7tlbA7rZt24cr2nmhzGrsItqKmYT7SMbjbpDYIdkSTLELIoX3JrrgRwhg4VvMR+FIr46nayiqoOrA1AG+2JudUfVUJpS5dUcu8dEP; 3:DBRwY/ByWCmyZ1jCRYnj76PiMBTV1RA51Gm9nAUUyiDulZPtJbvABXJQyf1x7aB6ne7JekgR8OVK11OWt8ZLW+aDbJQMD96pUEr++HGLsQQtfQRUqqqKPbUd0jTCbpX2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR07MB0937; X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB0937; 25:fbJfaE4Fq/rHk9DBWXSNaZOIeNWf+/rBefAe7BNp0sB9+e82m+nlaEdNH5S8GevDq8BM7850x/uaeRR++cvAhnQNod+ry+jUiMFlK6f7bmCbeHbIFl2eBO/0YHZTC32hCARHYpAdS+v8o7fhtGNnAtsA+aU/dqLvs2WLe/8juv6th3gLVVcLabh65ZvF74IMQobkJvae1xw5jRMc/5psVSW1kG+APJ8b5X1Wk9W8Utq5wIB8FwAaLEXRpuiZEOztvQw96m2HhwRXwo7xa8hq9tpp3eD7Tg0LsTQ5jcFaYEdskpcQo5F1/fHaAdtM5gcIQIQX0u+9aDL8yeBrwZz2iLUsl7Iz15iIRuOc+xHfiZlJO9u4e6DimanbCm1MS0MBo1jBfqm821Vmiio6aCHopJH23WnzZx3PvOT8X7BpKrMO8VFPmTdzKgWvjpQkNwconCgSqi72lunnWRGtLy5Cnu6iAU1wQleTjB5GntBB4+55PeotC0DSe5RWRCQKRWG86uIGPSaNjNv4kL1lRVldRXRCqvGaha/Gi7Xg5Iahh0NOgeqLKNnAVkPCYfURKxPh4cBy0nMI9iIqTqo8HO2FCYbHZXwnhzJMrCl22zrmvOdeI6b3Uwv5ByIuI+4z2RPpKCHjcX9lbj9hQ0Hj2lZzW4lDNAutXGysqU5JfxZIy7cDSul5RvNYsUGLCjsH2mlm//pkbbaM5t88pK1N3N8XOYCV2I8vN0OGKW5H+i7cf1jEwh7l5u3+4+iniJuNjSPoQfp50mLiWrUA33cnJveBgqlfjki8KjZvuIzYOCTaW8Zcn/ecPNyBoCOHgT72jChusiYHySq2muiGIRQtEyF7TccaPgZaLhTYKs+vqE9tDC8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046); SRVR:HE1PR07MB0937; BCL:0; PCL:0; RULEID:; SRVR:HE1PR07MB0937; X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB0937; 4:ARJ73Bz2JFjJ9IPqW1/htaM9TNUm48EQQjDTuWl8WBDAX6ewW0JX+5dLaZSaaVr0LYyP37W6e4oJUYQrXXx3yZ9vl25tP784PocZhqyqTtpm9K7OIp6jk1auDDFTbyBZvpWMCSta37VJbsfq/ZhtPZ/lUcCirD72DxWATTmfeKbcNxhWytg47IhTCiEp7qwtPYLYwMsSvn0uWFSdui7CkT0h3dEqdaEpU7J1URd2v9fHp4S/0/qK2ODOC+V1kEaW2SS6bc8cOIQipO7dYqvzjCDUay9/0WS1p8JMcNCuBRXOJ1jVfXiY2U7aFq/aa2UjLAFdStyFAYZrfAaxmbadCip77casbRtTXI2+VaNbjQWYbqJvr7vlKKCOzT1M1KVkNw0cA9t81kUBkXY5x4g/V7NRkCP3+5cbFzuEe164MDx0clx1eA88l1OyAHiqa1xrNoS6qvMS5sxaQTbSUyayfxONNZadf/pkNE95h1BQp80= X-Forefront-PRVS: 096029FF66 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(24454002)(2906002)(8676002)(4326007)(77096005)(65816999)(80316001)(189998001)(42186005)(2870700001)(81166006)(83506001)(19580395003)(74482002)(575784001)(86362001)(23676002)(59896002)(33656002)(5008740100001)(5004730100002)(5001770100001)(92566002)(36756003)(2950100001)(65956001)(50986999)(87266999)(65806001)(76176999)(15975445007)(47776003)(54356999)(50466002)(4001350100001)(6116002)(586003)(3826002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB0937; H:[IPv6:2001:470:183f:da2b::4007:25d]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA3TUIwOTM3OzIzOjkxd0N6WEZPV0ExbHAxUmdDMHRMb29uOEhy?= =?utf-8?B?Z2gybzdsVXU0bi9KbldHTGJQZitZWk5IVHRhblZBVHRtQW1LNkgvMWwxU1VD?= =?utf-8?B?UVhLUjFFTTVURThKaE1lQzBmZ2Yvd293TjA2NmlDZCtpVktmOW5DV2llaldN?= =?utf-8?B?REM4VmRPTFVMSG0zdHRHZEpWOUI0OVFPSVNSZDdzWDNvUFlPWmV4VXM3TTFq?= =?utf-8?B?SkpaQ2Njend3MGsvanFkWC9PTXp0cGlXR3dvOStpMEZXTExTcmpwa3g3SGNo?= =?utf-8?B?NFA2MGpqc2xadDgrdTFrWkl5YVJaRXB3WmZIL2UzNnFIS25IQWNYRm1wYmJP?= =?utf-8?B?ZDJuZzV6NmRUL21DWlZ4NjBmeHp4UEJKQld0azZZL3M0VWF6V1BtVHNxU0Nt?= =?utf-8?B?R3JqOG5nYnhmSHVjekMrZVlVdlE2Y0Z0c3FwNUoyMUdoWFVsWkpZM3Y3VzVL?= =?utf-8?B?TWNvV0ZvbnFBZlpEMW9PMElBMmN5WVdJaDJWRXppcm5QTzZjNzYxOGY1UTRW?= =?utf-8?B?UytlL2Q0NWpROG0zYVJqQnZsblYxVU1WZWZoOHJ2OVZIRElaakF0MTBad2pW?= =?utf-8?B?OEdMbVNhZFVpbFBtcFV4OUZDR293TmYwcitxd2M2Mm9PT1ltR1Z3ZW9rVDlT?= =?utf-8?B?aFhSQUlaNHR4aExMSHBHV2ZMQzc1dy9zVXJ0bzF4Sm9lMEU5RDd0ZXVxdXd0?= =?utf-8?B?cW9wcFV2TlVBZXg3N290Q2thbEV6cmJYS2RHWlNjSUdiN3ZZR1ZDVGxSb1Yy?= =?utf-8?B?dUVyc3B4Vm5aS0F4dUNIdnNaQlJjU3lrc2w0cmVjcTZ1eXNLTStFVHpQYVpL?= =?utf-8?B?MjFXZzZzZ1VEWVdoZHI3RU8wNE9WREdsbWJYcDRWenBHSmh0VTlTZnVGMWV1?= =?utf-8?B?SUFjKzJLUkczbUlVRUpKNFl4b1pXT3RqT1ZsTW96cjRacThaUWNmUVRMVHlZ?= =?utf-8?B?dmE4SWxnY29vQlRYUUFNTmJqcDRtVWhOdThjZTRXb01NQ1pnL084R0l1QVJz?= =?utf-8?B?SmNPN1crMG9PWXFYZmpDZmlVNTl3OWJPblcrYUljVksyQ3dLaERhMDV5UnhZ?= =?utf-8?B?bWJ4SUpWQ2xTOW1hU3ZRdllhSnpKb0tobFlKYUNoTGhPNmFVU1R2bkdtQUFV?= =?utf-8?B?YU1PNFJzU0RwNGtraE0wVFJ5L0YwRVZKbERtbGtqS3pjMEJIbDhHWjhBOGx2?= =?utf-8?B?S1B3OUEraHNiSEplR3dIL3IvV2F5ZnZxUWIvRE5DY1lad0xoVXZxRDhRb1Fu?= =?utf-8?B?eFZ2L2liN0l4YW1OSzR1ckZpdDdJS1drc1drdFZoSWxOMCtYUDFVTEZsN2p1?= =?utf-8?B?cndRY3B5Si9scXIraE0wM0FIL0tyYXB0Wkdac1lPVnIwa3dJNzE1QWtnYUov?= =?utf-8?B?dFdkVi9TTEF2SzV1cXpzdTZobXBtQW1WNWMvVVM3VXl4OVBtTVNhNEszNkhW?= =?utf-8?Q?40H3tEWjhnGAICqHsnnSUSza5iH?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB0937; 5:awuTEW0XA+H1JM27NqZBO9t1e/gaSRjkqN3DzXGuDG6x1NUNXydQtYCnM+Hu+or+0H/f0rGeKPoIrggzfIv7AmT4OZUB5r23vSIPKqPr18Qo2aUEaV72b2UyM8uDW6flH7iaK0MtDwENDV6kRearNg==; 24:a8Xs+T35z/DbpXHPjCz+zJHrEfeVudQYVVPSP8DKJLZ3e87/5Z8Ag1/51VcqMqqpYJ51xvKY/HNY6YoZy2KAFVdNTD5sb4iLrbhUgq4znIE=; 7:gNXHIabDcHds9+ItJUDGvuSIv1PuhO5aRBysmxxmPhVZKQaFAu51w6pdBAO8vqs8rzBaF5n3OG6ajrWTNyjx/mJ31hwrRG01Z+Vkf79RrDY+yankDPqQvP7sheH4InrhqN57vPPDg3z7asNzfEUfG4FwFq4nKdYNiF0rFukMs3XUjBN1p9QG6evnazLwMM0P SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2016 10:02:07.2788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB0937 Subject: Re: [Cake] [lede-project/source] Add support for cake qdisc (#72) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 10:02:10 -0000 To try and keep everyone in the loop this has also been sent to the cake list. LR;DR - There's a pull request to the LEDE tree to integrate cake as a patch to tc as well as a small, separate core package for kmod-sched-cake. This is a good thing. The pull request is https://github.com/lede-project/source/pull/72 Hannu Nyman is the author of the patch included in the PR - I've volunteered to be maintainer until cake really, really, really goes upstream. Lucky me :-) Hannu's patch included an improvement in column alignment on tc -s qdisc show output. I have updated Dave's tc-adv tree to include this cosmetic change https://github.com/dtaht/tc-adv/commit/54794117daef5dd16e0ccec4b821f0c67e6b9ede Jonathan made reference to "a particular misfeature that should be deleted". This mis-feature is DSCP washing. This has been brought up before and to that end I put in some pull requests removing said facility to Dave's cake & tc-adv repos. On that previous occasion it was decided it could stay but again it has been mentioned as being something undesirable. I dug around, found my previous 'nosquashwash' trees, rebased them and have submitted pull requests again. https://github.com/dtaht/tc-adv/pull/10 https://github.com/dtaht/sch_cake/pull/25 Maybe it will save a little work. Or if JM happy I will commit them as is. I personally would like this stumbling block removed for better or for worse, let's not stumble over it again :-) Kevin On 31/05/16 19:46, Hannu Nyman wrote: > I have amended the commit (and it is rebased to the current LEDE head) > > * import the cake commit recommended by @chromi > > * define Kevin as the maintainer for cake, thanks @kdarbyshirebryant > > > @kdarbyshirebryant , regarding > maintenance: > > * The cake part is easily maintainable, as the Makefile here just > defines the commit to be fetched from the original cake repo and > sets date as the version. > * tc patch may require some manual diff work if the later changes in > tc-adv are complex. I actually created my patch a few months ago by > making a diff of your tc-adv4.3 branch (that contained tc-adv > applied to iproute 4.3) to plain iproute. Then I pruned the > non-essential parts (e.g. extra/old cake versions still present in > tc-adv, changes to other qdiscs, man pages etc.) from the patch and > left only the cake stuff to be compiled. And that was not actually > very much. Basically just a new module for tc, small changes to a > header file and Makefile. I have since then updated the patch to > include the two commits from @chromi in > April. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > . >