From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.taht.net (mail.taht.net [IPv6:2a01:7e00::f03c:91ff:feae:7028]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B2A463B2A2 for ; Wed, 1 Jun 2016 06:07:02 -0400 (EDT) Received: from dair-2430.local (c-73-252-201-217.hsd1.ca.comcast.net [73.252.201.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id 4623221326 for ; Wed, 1 Jun 2016 10:07:01 +0000 (UTC) To: cake@lists.bufferbloat.net References: <574EB29B.1000405@darbyshire-bryant.me.uk> From: =?UTF-8?Q?Dave_T=c3=a4ht?= Message-ID: <574EB550.5020005@taht.net> Date: Wed, 1 Jun 2016 03:13:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <574EB29B.1000405@darbyshire-bryant.me.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [lede-project/source] Add support for cake qdisc (#72) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 10:07:02 -0000 I still think squashing is very important, and essentially required by several rfcs. On 6/1/16 3:02 AM, Kevin Darbyshire-Bryant wrote: > To try and keep everyone in the loop this has also been sent to the cake > list. > > LR;DR - There's a pull request to the LEDE tree to integrate cake as a > patch to tc as well as a small, separate core package for > kmod-sched-cake. This is a good thing. The pull request is > https://github.com/lede-project/source/pull/72 > > Hannu Nyman is the author of the patch included in the PR - I've > volunteered to be maintainer until cake really, really, really goes > upstream. Lucky me :-) > > Hannu's patch included an improvement in column alignment on tc -s qdisc > show output. I have updated Dave's tc-adv tree to include this cosmetic > change > https://github.com/dtaht/tc-adv/commit/54794117daef5dd16e0ccec4b821f0c67e6b9ede > > > Jonathan made reference to "a particular misfeature that should be > deleted". This mis-feature is DSCP washing. This has been brought up > before and to that end I put in some pull requests removing said > facility to Dave's cake & tc-adv repos. On that previous occasion it > was decided it could stay but again it has been mentioned as being > something undesirable. I dug around, found my previous 'nosquashwash' > trees, rebased them and have submitted pull requests again. > > https://github.com/dtaht/tc-adv/pull/10 > https://github.com/dtaht/sch_cake/pull/25 > > Maybe it will save a little work. Or if JM happy I will commit them as > is. I personally would like this stumbling block removed for better or > for worse, let's not stumble over it again :-) > > Kevin > > > > > > On 31/05/16 19:46, Hannu Nyman wrote: >> I have amended the commit (and it is rebased to the current LEDE head) >> >> * import the cake commit recommended by @chromi >> >> * define Kevin as the maintainer for cake, thanks @kdarbyshirebryant >> >> >> @kdarbyshirebryant , regarding >> maintenance: >> >> * The cake part is easily maintainable, as the Makefile here just >> defines the commit to be fetched from the original cake repo and >> sets date as the version. >> * tc patch may require some manual diff work if the later changes in >> tc-adv are complex. I actually created my patch a few months ago by >> making a diff of your tc-adv4.3 branch (that contained tc-adv >> applied to iproute 4.3) to plain iproute. Then I pruned the >> non-essential parts (e.g. extra/old cake versions still present in >> tc-adv, changes to other qdiscs, man pages etc.) from the patch and >> left only the cake stuff to be compiled. And that was not actually >> very much. Basically just a new module for tc, small changes to a >> header file and Makefile. I have since then updated the patch to >> include the two commits from @chromi in >> April. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> , >> or mute the thread >> . >> >> > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake