From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Benjamin Cronce <bcronce@gmail.com>,
Sebastian Moeller <moeller0@gmx.de>,
Jonathan Morton <chromatix99@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, cake@lists.bufferbloat.net
Subject: Re: [Cake] [lede-project/source] Add support for cake qdisc (#72)
Date: Wed, 1 Jun 2016 14:09:48 +0100 [thread overview]
Message-ID: <574EDE9C.9040305@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAJ_ENFFT2-obaqDY-TVhNsg+uwU7eFysDqAgxX-AL6-cJJVbpw@mail.gmail.com>
On 01/06/16 13:25, Benjamin Cronce wrote:
>
> I'm just going to ask two questions just to reflect on
>
> 1) Ideally, regardless of platform, should an AQM or scheduler have the
> responsibility of changing anything other than ECN?
> 2) Should you be deciding the responsibility of CAKE based on the
> implementation of the platform (IP Tables, not IPTables, etc) or
> implementing the ideal solution?
>
> Ideals can be bad if overly zealous, but it's a slippery slope to the
> anti-ideal every time you give up an ideal for practical reasons. I
> always ask myself, what is the perfect solution, can it be done, and
> what are the trade-offs if it cannot be. Single point of responsibility
> is one of those ideals.
Thank you, that has really helped clarify my thinking. I'm definitely
happy for it to go. Based on the above it should never have got in!
I believe that Dave's concerns can be addressed by iptables rules (as
would have to be done with other qdiscs anyway)
Anyone against?
Jonathan, would you like me to merge those pull requests to remove
'wash' or do you have a better way of implementing? I'm less worried
about backwards/forwards compatibility because as as far as I'm
concerned cake has never been 'released'. I'm not so much a fan of
linux's backporting of API changes either!
Kevin
next prev parent reply other threads:[~2016-06-01 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <lede-project/source/pull/72@github.com>
[not found] ` <lede-project/source/pull/72/c222782884@github.com>
2016-06-01 10:02 ` Kevin Darbyshire-Bryant
2016-06-01 10:13 ` Dave Täht
2016-06-01 10:20 ` Kevin Darbyshire-Bryant
2016-06-01 10:52 ` moeller0
2016-06-01 11:20 ` Toke Høiland-Jørgensen
2016-06-01 11:41 ` moeller0
2016-06-01 11:47 ` Kevin Darbyshire-Bryant
2016-06-01 11:57 ` Sebastian Moeller
2016-06-01 12:25 ` Benjamin Cronce
2016-06-01 13:09 ` Kevin Darbyshire-Bryant [this message]
2016-06-01 13:51 ` Jonathan Morton
2016-06-01 15:19 ` moeller0
2016-06-01 20:22 ` David Lang
2016-06-01 15:26 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EDE9C.9040305@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=bcronce@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=moeller0@gmx.de \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox