Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: <cake@lists.bufferbloat.net>
Subject: Re: [Cake] flow dissector idea/enhancement - help
Date: Thu, 30 Jun 2016 20:23:48 +0100	[thread overview]
Message-ID: <577571C4.2070905@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <BCD282AE-CD0A-4255-BFA9-93ABDEC9147E@gmail.com>



On 30/06/16 11:27, Jonathan Morton wrote:
>> On 30 Jun, 2016, at 12:33, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>>
>> +#ifdef CONFIG_NET_SCH_ESFQ_NFCT
>> +       enum ip_conntrack_info ctinfo;
>> +       struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
>> +#endif
> Good find.  If this actually works the way we want it to, it’ll make all the host-dependent modes (including triple-isolation) much more useful on the outer side of a NAT.
>
> My main concern is that the conntrack state might not be sorted out until it hits the firewall or routing logic.  I’ll be very pleased if it happens sooner, or is actually triggered by the query rather than passing to some specific stage of processing.
>
> I have other work to do on the host and flow processing, but I think that’ll be independent of the hash function, which is where you want to be looking.
I knew I shouldn't have got so excited.  It sort of half works-ish. I 
hacked something together and then added a few printk statements to help 
with debugging.  For testing I setup 'dual-dst' on the ifb4wan (ingress) 
interface, and set 'dual-src' on the wan4 (egress) interface.  Testing 
showed the input side of things hadn't got as far as conntrack 
association by the time it hit the qdisc.  The output side of things 
definitely has conntrack associations. They're a bit strange and I need 
to do a bit more digging to see if there's anything useful here, it 
might be possible to do per host egress fairness.   For reasons I don't 
understand it looks as though I'm occasionally seeing the 'reply' 
conntrack association and not just the 'incoming'...in other words I'm 
seeing 'internet' source addresses, not just internal lan.

I'm beginning to think there's a reason why enhanced sfq which is where 
I found that code never made it upstream :-/   It's been/being an 
interesting little diversion...and I've modified a kernel module that so 
far doesn't crash :-)

KDB


  reply	other threads:[~2016-06-30 19:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 11:09 Kevin Darbyshire-Bryant
2016-06-02 12:29 ` Jonathan Morton
2016-06-30  9:33   ` Kevin Darbyshire-Bryant
2016-06-30 10:27     ` Jonathan Morton
2016-06-30 19:23       ` Kevin Darbyshire-Bryant [this message]
2016-07-01  8:11         ` Kevin Darbyshire-Bryant
2016-07-01 15:38           ` Kevin Darbyshire-Bryant
2016-07-02 12:47     ` [Cake] conntrack and ipv6 Dave Täht
2016-07-02 13:00       ` moeller0
2016-07-03  6:16       ` David Lang
2016-07-03  7:44         ` Jonathan Morton
2016-07-03 21:12       ` [Cake] [Cerowrt-devel] " moeller0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577571C4.2070905@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox