From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6221D3CB38 for ; Wed, 4 Aug 2021 16:49:09 -0400 (EDT) Received: by mail-ej1-x62e.google.com with SMTP id e19so5648848ejs.9 for ; Wed, 04 Aug 2021 13:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bxxsVHHhQM2xLIanDQOr7NgXJNmXVKBQ5e5F6n6lS/Y=; b=Sc6D76LFabhaUM3bwDeaqgDutLnLJbFk+Z1rghb35hggM50y8Fm+et+fjagg5nLtr+ T10zucqjn9ttu+l8vlNKEDouBJQYjCSgfWqoO3XZSOnsa3hH7YlkbkvHCvjQdwZ0clX0 3u8rE3J1+FwUecZ2qYiLL5WlAeqixaK6FvC1ssaoSxcoRixd/35jSnL1DnchbKiHJ9J6 XemwFi/+1HsvziF/KutroOUMMSP1WacK9Nh6WMAzt4mJw5yyorHhd3Zh1eqKkExvnSlz f3CNYL/nJzTSMrmNG5vQpWDIHKDHlBixQ0Z47KzHsh++JMJaEYVNjE6IXVMfFkBjVcG8 vqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bxxsVHHhQM2xLIanDQOr7NgXJNmXVKBQ5e5F6n6lS/Y=; b=CfFsSodZAPDGkTSe2wEijjqYp7Iyix6VLrkaaHP/1Kj2tILUTlPpSNU1cwcmeOZeD6 XaaR/rQsZTESUL9UX8eoxD/Bf1vomNf6C7Z+MJDZZARiaQdlDZ4GX+oEmm59dVqdL8lw uO09xMZ0/5FtxsWMd8Fpc9/3yd0cnQyLzOWtZFlaUPBK4qZnrlnNBcukKXac/puAl+2c 62ScCkUbUmXUN4gst2BEU2kh8cYVNJpdLPKSYhVaxw6C0w5eUCIOhu+kKj0mLems7lKY bVjnsWrePUAc28e+4bjW2S4dl63CmUFHvAEuj7AvHzsQPbdbsvxZ6oaYyn6qiGgTC0jf WsWQ== X-Gm-Message-State: AOAM531p6E93jNbhcGq0CPoRiU/WRJqigOyHm7vnf77avd4p9ZPQT24I CLgNb2aoqpUyqHZp/66JY6KNzHMQp5rTpg== X-Google-Smtp-Source: ABdhPJw9uTqWignraaGelkhO3/+00WvJoKOaSDbBUx9/a+gGCZR93OdX7wF5WulHTvRh+1XbjwUQnQ== X-Received: by 2002:a17:906:1c07:: with SMTP id k7mr1000943ejg.173.1628110148472; Wed, 04 Aug 2021 13:49:08 -0700 (PDT) Received: from [10.72.0.88] (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id f15sm984353ejt.75.2021.08.04.13.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 13:49:07 -0700 (PDT) Message-ID: <5964374bee9979ee9f1b4b86d32b002722d628fc.camel@heistp.net> From: Pete Heist To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Cake List Date: Wed, 04 Aug 2021 22:49:07 +0200 In-Reply-To: <87r1f95und.fsf@toke.dk> References: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net> <87r1f95und.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Cake] cake srchost/dsthost stopped working? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 20:49:09 -0000 Great, that seems to fix it. :) For sanity, I confirmed that I can apply/unapply the patch to fix/break it, so all seems well. Is there anything that you'd want to make sure still works after the patch? I don't have any official regression tests to run, but with this setup ready I should be able to test something easily if needed... Pete On Wed, 2021-08-04 at 13:14 +0200, Toke Høiland-Jørgensen wrote: > Pete Heist writes: > > > One more tip, reverting this commit seems to fix it: > > > > https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7297c15d6ce > > Ah, I think I see what the problem is; could you please try the patch > below? > > -Toke > > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > index 951542843cab..a83c4d4326da 100644 > --- a/net/sched/sch_cake.c > +++ b/net/sched/sch_cake.c > @@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, > const struct sk_buff *skb, >  skip_hash: >         if (flow_override) >                 flow_hash = flow_override - 1; > -       else if (use_skbhash) > +       else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS) >                 flow_hash = skb->hash; >         if (host_override) { >                 dsthost_hash = host_override - 1;