[Cake] commit d187cd1 breaks on 4.9.64

[Cake] commit d187cd1 breaks on 4.9.64

[George Amanakis]

FYI, I am testing the latest cobalt branch, and commit d187cd1 breaks 
compilation on 4.9.64.


make -C /lib/modules/4.9.64-1-lts/build SUBDIRS=/home/scy/src2/sch_cake 
modules 
LDFLAGS_MODULE="--build-id=0xf3fb15754862299786d7e6cf1bc26e289a96dff9" 
CFLAGS_MODULE="-DCAKE_VERSION=\\\"f3fb15754862299786d7e6cf1bc26e289a96dff9\\\""
make[1]: Entering directory '/usr/lib/modules/4.9.64-1-lts/build'
   CC [M]  /home/scy/src2/sch_cake/sch_cake.o
/home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_init’:
/home/scy/src2/sch_cake/sch_cake.c:2474:12: error: implicit declaration 
of function ‘kvzalloc’; did you mean ‘vzalloc’? 
[-Werror=implicit-function-declaration]
   q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
             ^~~~~~~~
             vzalloc
/home/scy/src2/sch_cake/sch_cake.c:2474:10: warning: assignment makes 
pointer from integer without a cast [-Wint-conversion]
   q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
           ^
/home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_dump_stats’:
/home/scy/src2/sch_cake/sch_cake.c:2581:30: warning: initialization 
makes pointer from integer without a cast [-Wint-conversion]
   struct tc_cake_xstats *st = kvzalloc(sizeof(*st), GFP_KERNEL);
                               ^~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:300: 
/home/scy/src2/sch_cake/sch_cake.o] Error 1
make[1]: *** [Makefile:1493: _module_/home/scy/src2/sch_cake] Error 2
make[1]: Leaving directory '/usr/lib/modules/4.9.64-1-lts/build'
make: *** [Makefile:8: default] Error 2

George

Re: [Cake] commit d187cd1 breaks on 4.9.64

[Dave Taht]

reverted. thanks for testing!

On Fri, Nov 24, 2017 at 4:35 PM, George Amanakis <gamanakis@gmail.com> wrote:
> FYI, I am testing the latest cobalt branch, and commit d187cd1 breaks
> compilation on 4.9.64.
>
>
> make -C /lib/modules/4.9.64-1-lts/build SUBDIRS=/home/scy/src2/sch_cake
> modules
> LDFLAGS_MODULE="--build-id=0xf3fb15754862299786d7e6cf1bc26e289a96dff9"
> CFLAGS_MODULE="-DCAKE_VERSION=\\\"f3fb15754862299786d7e6cf1bc26e289a96dff9\\\""
> make[1]: Entering directory '/usr/lib/modules/4.9.64-1-lts/build'
>   CC [M]  /home/scy/src2/sch_cake/sch_cake.o
> /home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_init’:
> /home/scy/src2/sch_cake/sch_cake.c:2474:12: error: implicit declaration of
> function ‘kvzalloc’; did you mean ‘vzalloc’?
> [-Werror=implicit-function-declaration]
>   q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
>             ^~~~~~~~
>             vzalloc
> /home/scy/src2/sch_cake/sch_cake.c:2474:10: warning: assignment makes
> pointer from integer without a cast [-Wint-conversion]
>   q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
>           ^
> /home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_dump_stats’:
> /home/scy/src2/sch_cake/sch_cake.c:2581:30: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
>   struct tc_cake_xstats *st = kvzalloc(sizeof(*st), GFP_KERNEL);
>                               ^~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:300:
> /home/scy/src2/sch_cake/sch_cake.o] Error 1
> make[1]: *** [Makefile:1493: _module_/home/scy/src2/sch_cake] Error 2
> make[1]: Leaving directory '/usr/lib/modules/4.9.64-1-lts/build'
> make: *** [Makefile:8: default] Error 2
>
> George
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619