Re: [Cake] tc coding comments

[Sebastian Moeller <moeller0@gmx.de>]

Hi Dave,


On Nov 19, 2015, at 09:56 , Dave Taht <dave.taht@gmail.com> wrote:

> Maybe: squash and wash? Squash would be best effort only, wash would
> be whatever diffserv model

	Since besteffort is the default already, I believe there is no need to link two otherwise orthogonal toggles. diffservN (we could add diffserv1 as alias to besteffort?) The man page can then easily explain the options independently and people can predict their interaction, something along the line of:
“The diffserv mode defines how cake reacts to DSCP markings in queued packets, with besteffort treating all markings the same and hence effectively ignores them. Squash defines how cake treats the DSCP bits of packets it passes on the the next layer, by default the markings are conserved, the squash keyword instructs cake to re-mapp all DSCPs to 0”


> 
> The "tc standard" for compound variables is mostly whatever_it_is, not
> whatever-it-is or "whatever it is"
> 
> drops: Dropped_bytes might be a good indicator also
> 
> indentation is needed to differentiate between qdisc invocations on mq
> and full blown dumps
> 
> tc qdisc add dev whatever root cake bandwidth 50gbit does not work

	Potentially caused by -ENOADEQUATETESTHARDWARE and hence not tested ;) ?

> 
> "unlimited" vs "bandwidth X" is asymmetric. "bandwidth unlimited”?

	Good idea, this is only really needed to change away from a limited mode, so users can be expected to request bandwidth explicitly…

Best Regards
	Sebastian

> 
> is tc qdisc change dev whatever root cake bandwidth new_bandwidth
> Xmbit # is efficient, not drop packets on the change itself?
> 
> 
> Dave Täht
> Let's go make home routers and wifi faster! With better software!
> https://www.gofundme.com/savewifi
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake