From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 5E91621F69B for ; Sun, 1 Nov 2015 09:47:55 -0800 (PST) Received: from hms-beagle.home.lan ([217.237.68.126]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M8leW-1ZlIIl15XY-00CAM3; Sun, 01 Nov 2015 18:47:51 +0100 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <56364975.1030606@darbyshire-bryant.me.uk> Date: Sun, 1 Nov 2015 18:48:29 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <5E484E77-C716-4703-940B-C3D2F08809B6@gmx.de> References: <563517E5.4050202@darbyshire-bryant.me.uk> <7F32378C-878D-437C-B56C-F8E5B0D99895@gmx.de> <563611DE.5080304@darbyshire-bryant.me.uk> <56364975.1030606@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:ji2uWYo5xWqAsPYEQNfIxfQkJIfVhx/DGndr/MyBK0Ro55WtJew +Xvk9XhscxicT/Dz4OlLEZC7bsC/UCY2Kj7NgLCWWSRx6cv++L/cTwOs3+s4L2yjgcj/OtY YPWOXdPwq9K7oGBqhC3ZNDcv/apLSQ1ISDDA4MbNotZbmdyXMVvu8LdGi8DsbzK7XIvU4A/ kWYvDWUyc8LHa3Y2K17WQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:XHvDKtHvM2Y=:BoG0FhmF+uWxRmwp1TgTKt TFItSaeAzInkIRWGUoXsfVrWOe1+kAqrOS6THxBrsf8CNydbd69wXWA04gPUrisJU1FuVnLZT wv2gzrJyNz0aaR6OIynJCSLvh+GtYv1OScURLZLyx/ZUHIQb32rvyP1uZZ6oTqg8By9VJ4a7z lnFCaMONI+vDsESRZt07sSljZVGfDoSVrlhm8aNtsfnVUlmodCo4eA+NFKf3+RroRP3Oge2rE Red5SBy3V9VkL5H+40/LOS5/WELNdvPkCzxmyCafyfPLAOy/0rlBrG23pYd7GRhKPGEw5LulU c+YdGe9QCY8GRbUJh4UTTrsZqS46zKxRRjiG5zzCbbRkoGMddAoj9f8yVPwtYO+rv9PK1Hu81 wMrevSbx9uycAvW67QyrVA8B6GLtshU6uDlevz/pzzL2cCUMLwO67N3cEhBbt19A/6joDIuW8 8M9N5C/nmuqqINILPtCJh+zrDd0/YSC5GCYhRJwkRFMd+NqeHnntg2huPpgG690YH2kySyDkA EdideyOnP1UFzuXCSEIOADrgQy672BxX/kbeuIpOjIPzmVzCeQDULUOqjtB2W8KmVhHrdNMsw pKX2VBSp5kVgGM32dzrsXrHL6zT0PoEsZ8sv1r/nW2kUWGtgO4DcxW9fKjm3BECWW8U+bq3g6 LpWgPBJqppChF7/B00HNlzNXw65KCEFXvJeljGnMln5T14Rzvajb+wvHtKjeprjhn+ZpOqOta ZSA5KoGOraT4e/GV68r0NWGWN3/UckDWP9Z3Hv9NChgzt2cT7Fdblcs+RjHoqUAeV/JKBHqzh 8Ajxni+ Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Stranger target behaviour X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 17:48:19 -0000 Hi Kevin, On Nov 1, 2015, at 18:18 , Kevin Darbyshire-Bryant = wrote: > On 01/11/15 16:05, Sebastian Moeller wrote: >> Dear friends of cake, >>=20 >>> [...] >> I believe I just fixed this by initializing target in sch_cake = to "interval >> 4=94, I opted for the calculation instead of the simple = number 6250 to sort of document the pattern and tried to put in a = comment explaining why this is okay with codel's theory. Please note, I = did not really test this, so for all I know it might break = spectacularly... > Looks ok to me, though the optimising compiler likely will turn that > calculation into a constant 6250 anyway ;-) =20 And that is fine it really is to document the fact for the = source reader and to catch the hypothetical case that the default = interval will be increased in the future... > Only comment would be > 'watch your line length' - no lines over 78 chars ideally in the > kernel. Well, the powers that be need to decide, I believe the comment = is helpful enough to having made it, but insignificant enough to not = warrant its dedicated line or block of lines. First let=92s see whether = the comment survives in its verbosity and then care for style. That = said, I am happy to keep monitoring this and potentially make the = change. > On that note I've just committed some checkpatch > style/formatting related changes. Oh, even better, I just see you fixed it for me; thanks a lot = (sure beats having to clean up after myself ;) ) >> Slightly different question, I have a few cosmetic changes for = tc, so which repository to commit this too, is tc-adv to be the = gathering point for changes to be considered? > I've no idea! Recently I tried to merge Toke's repo version into my > copy of Dave's tc-adv without success. Well the merge works, but > openwrt complains loudly at this recent version of iproute2 utilities > and so far it's beyond my wit to tease out how to fix. *if* it worked > then we could be down to 1 repo, 1 version that worked for linux & = openwrt. At least to me that sounds like a decent strategy, no? >=20 > Speaking purely personally, committing to tc-adv would mean openwrt = type > people would test/play with it (me!) Committing to kau.toke.de would > mean non-openwrters would play....of course you could = cherrypick/commit > to both :-) Since I only have commit permissions at tc-adv (I am not asking = for more) I will just play with the tc-adv repository and hope Jonathan = will cherry pick (or even just implement the ideas in his own way) = everything he considers worth it=85 Best Regards Sebastian >=20 > Kevin