From: Jonathan Morton <chromatix99@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake's ack-filter vs GSO
Date: Sun, 18 Feb 2024 02:31:44 +0200 [thread overview]
Message-ID: <5E544857-711A-4284-9481-C1C711E43F56@gmail.com> (raw)
In-Reply-To: <CAA93jw7YeW4wTC2OL4AxeEPBOGL4sKN+e5Dtre_0VZCkOjkbCw@mail.gmail.com>
> On 18 Feb, 2024, at 2:01 am, Dave Taht via Cake <cake@lists.bufferbloat.net> wrote:
>
> Does anyone remember why we do not ack-filter a gso-split?
That may actually be unintentional. The original code self-recursed, IIRC, so individual segments would then go through the non-gso-split path. At some point we inlined it for efficiency.
The thing to try might be to copy the relevant code (both the search and the drop) into the gso-split path and see if anything breaks, and if the ack-dropping statistics tend to increase.
- Jonathan Morton
next prev parent reply other threads:[~2024-02-18 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 0:01 Dave Taht
2024-02-18 0:31 ` Jonathan Morton [this message]
2024-02-18 13:37 ` Toke Høiland-Jørgensen
2024-02-23 16:26 ` Dave Taht
2024-02-23 16:39 ` Toke Høiland-Jørgensen
2024-02-23 17:03 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E544857-711A-4284-9481-C1C711E43F56@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox