From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 468583B2A4 for ; Sat, 17 Feb 2024 19:31:48 -0500 (EST) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d180d6bd32so26378061fa.1 for ; Sat, 17 Feb 2024 16:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708216306; x=1708821106; darn=lists.bufferbloat.net; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EwxwTPqPMH2W73CVDOngrWiHmg/32q4WOTbHiVu4/+A=; b=bO8hXPPNbnmcXmDsgY4gXmlAfHCv1SKjwSPSTtjQInDHOWiDjfYR2RtVDkhkNRY0wC J93z9oi7A16Yh9o4WNaLFmPElsIZdhr7rfx7DX/2W/r/VDchumTFOmOBAQWDAnAz+MuY UcMSnVy51D0Q2hJi7bfGl+xM49mDMAZ1Ic4VxoBHoKVhuTu9cDinH+DFZn3oa2HLohBp wUH3i8BQdgIQSuOi1jY4O6/+ejbak1SRt/U+yZdffAOuE1/97Q8pdinzGqGpuB/l6Ce6 aNDs1dKv7JhZQO+Y+WIohx6KEYycgAbZ66qvjqU16EQLmSV7h/4P1yio0XwJGf7muYSC K5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708216306; x=1708821106; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EwxwTPqPMH2W73CVDOngrWiHmg/32q4WOTbHiVu4/+A=; b=paj3giLbn0twpzhRqFKEEA60Kzk2bO5QMro+SQOzB/eS7911IhxxpKQLrqOFC5hoTV vB2iV5y1Al/GQ33lSFMgTfQ85V58aoKcYq+Bm2eeB1pmxP+2oD1a1+VZkR6hGTAhZptG vRETIWI7P9+xeea/mmH8n1Qoy0+66zg/DWBZ+ikHAzIBYunuP9tMMD6dEQvRvss5sWP1 Eem9V3K/kC5UQfkojle3hDBPzSoyLw12IC+ynfHfQ61QUnmdUDK9jnA+6Op8jd4MBobs l1O+adPsuoAuxle8fxGdcagCHfQT+IM2PKwptLvBnjft0OLLcnRdhjmK7jlm9qzQIgsc mPbQ== X-Gm-Message-State: AOJu0YxWY+/vmVQyNJAsFi6/4/hvTB3e3PLxD1ZkKHX0EKuaIsMBQ5aH 9VoBVIeUGclys8uZliBvzs2fSwz1QK7EYR+Ie80PPNGbp6H4yPi7 X-Google-Smtp-Source: AGHT+IFkKUEHRzjvmh+P+zJKRS4nzMAAAgG/Km+ZNCmIseqfDVP6VLWfuQboMzNi/q13l5behQvUxA== X-Received: by 2002:a2e:87ce:0:b0:2d0:dfd7:28f4 with SMTP id v14-20020a2e87ce000000b002d0dfd728f4mr5395191ljj.41.1708216305809; Sat, 17 Feb 2024 16:31:45 -0800 (PST) Received: from smtpclient.apple (178-55-39-192.bb.dnainternet.fi. [178.55.39.192]) by smtp.gmail.com with ESMTPSA id n15-20020a2e720f000000b002cf55fddca7sm489029ljc.49.2024.02.17.16.31.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Feb 2024 16:31:45 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) From: Jonathan Morton In-Reply-To: Date: Sun, 18 Feb 2024 02:31:44 +0200 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <5E544857-711A-4284-9481-C1C711E43F56@gmail.com> References: To: Dave Taht X-Mailer: Apple Mail (2.3654.100.0.2.22) Subject: Re: [Cake] cake's ack-filter vs GSO X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2024 00:31:48 -0000 > On 18 Feb, 2024, at 2:01 am, Dave Taht via Cake = wrote: >=20 > Does anyone remember why we do not ack-filter a gso-split? That may actually be unintentional. The original code self-recursed, = IIRC, so individual segments would then go through the non-gso-split = path. At some point we inlined it for efficiency. The thing to try might be to copy the relevant code (both the search and = the drop) into the gso-split path and see if anything breaks, and if the = ack-dropping statistics tend to increase. - Jonathan Morton=