From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id BDA9D21F185 for ; Fri, 15 May 2015 14:50:25 -0700 (PDT) Received: by labbd9 with SMTP id bd9so140631994lab.2 for ; Fri, 15 May 2015 14:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=16q+zRfg/9XlqJYl4gB5M8bxmvzFSjmic6XrD1QrepM=; b=TWj8S0JQPiCKpBPjyF64ukPx5by6RJ47AfWdET8spMtd+z8q+FRMxTSAkR8gTabw7Z +CzX0kSVw7hCcatF0ZlSpXDGveAu10OiF4gs5qGDDE97ghvgC6OdA8QHQPatwBZt85yV QYKPKKiCMPRIdf677lDkUGUTanmUk8EdkvG8hf8YfE9bNekJ6av8cwnLp5cMnTOqVnXD td+fmfjDcZRdCoCdXADXSNyYzj0IiMzD0UYuLbv5jSS0SKL4N+Jvtx9pgz/oXs+XcAG4 vTK4YKfYrTsF7qd3Hk9B9WEUiJCk0gIyfPEYv6e8rcOw88oiM8JGKueJrTXjgxE0jjXn 4t5g== X-Received: by 10.112.222.133 with SMTP id qm5mr8759750lbc.86.1431726575961; Fri, 15 May 2015 14:49:35 -0700 (PDT) Received: from bass.home.chromatix.fi (87-93-34-32.bb.dnainternet.fi. [87.93.34.32]) by mx.google.com with ESMTPSA id fb5sm709481lbc.35.2015.05.15.14.49.31 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 May 2015 14:49:34 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) From: Jonathan Morton In-Reply-To: Date: Sat, 16 May 2015 00:49:26 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <5F3E339B-24F4-4A6A-9272-F56BC79FE1B9@gmail.com> References: <554F64E1.6000609@gmail.com> <554F9594.60808@gmail.com> <50DB1E31-61AE-4298-B80F-8C6F7487C99B@gmail.com> <002A5BFC-5511-4995-8785-370251F24083@gmx.de> <38FFDA3C-2F67-4831-B316-DF8CC7EF0167@gmail.com> <664C6B9D-67C2-4614-A9B0-140D3BEEA4AD@gmx.de> <444770E9-51C0-4935-8E00-5008CDB388E5@gmail.com> <5334C435-218A-48CF-8AB2-F73F76F47216@gmail.com> To: Dave Taht X-Mailer: Apple Mail (2.2098) Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] openwrt build with latest cake and other qdiscs X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 21:51:12 -0000 > On 15 May, 2015, at 05:27, Dave Taht wrote: >=20 > Well, there is a lot of redundant work being done in cake_enqueue in > this case - the diffserv lookup (which might not be redundant but > usually is), the hashing (which will be), grabbing the timestamp > (probably won't hurt to just grab it once for the whole aggregate), > and so on down through cake_enqueue >=20 > I do not have sufficient expertise to evaluate the rest. But would > certainly like to benchmark it as is. Well, premature optimisation and all that. I think I can see how to = refactor it to take those possibilities into account, but I=E2=80=99d = like to know whether it basically works as-is before I try that. On the assumption that most people who are more interested in the = overhead code have already grabbed it, I=E2=80=99ve pushed it to the = sch_cake repo so that we=E2=80=99re on the same page. - Jonathan Morton