From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>, netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Eric Dumazet <edumazet@google.com>
Subject: Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header
Date: Thu, 13 Sep 2018 07:11:18 -0700 [thread overview]
Message-ID: <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> (raw)
In-Reply-To: <153670437243.12756.693381878569982309.stgit@alrua-kau>
On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote:
> When splitting a GSO segment that consists of encapsulated packets, the
> skb->mac_len of the segments can end up being set wrong, causing packet
> drops in particular when using act_mirred and ifb interfaces in
> combination with a qdisc that splits GSO packets.
>
> This happens because at the time skb_segment() is called, network_header
> will point to the inner header, throwing off the calculation in
> skb_reset_mac_len(). The network_header is subsequently adjust by the
> outer IP gso_segment handlers, but they don't set the mac_len.
>
> Fix this by adding skb_reset_mac_len() calls to both the IPv4 and IPv6
> gso_segment handlers, after they modify the network_header.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Looks good but I would have appreciated a thanks or something
after the help I gave on this problem.
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2018-09-13 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 22:19 Toke Høiland-Jørgensen
2018-09-13 14:11 ` Eric Dumazet [this message]
2018-09-13 14:14 ` Dave Taht
2018-09-13 14:22 ` Toke Høiland-Jørgensen
2018-09-13 14:43 ` [Cake] [PATCH net v2] " Toke Høiland-Jørgensen
2018-09-13 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox