From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6261C3CB35 for ; Thu, 13 Sep 2018 10:11:21 -0400 (EDT) Received: by mail-pg1-x544.google.com with SMTP id v66-v6so2801535pgb.10 for ; Thu, 13 Sep 2018 07:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wwEZROVUGNrZD1551z/A8zmSWcOvD+bnaCjldQWQwYo=; b=GimRQcWBHrZPWhMNt5B84+J1K13xPt4A4UdePnvQhvjxrw/L4PmzqwPqkDpEwJPwWl T6LG6riqaSy3QuR2o53DCm4MDW7B6nEKnDn4A9pxG+pWugGDEObO25RL2uzl50Xa8Yw/ GbJjsNlgfIlBLIOSApCDq6gnQjM16TdHvbC8fnOe2/iDgdhQwKttPjK8uFc9QH8uoKf3 8tsk+7zEMOzQPPiXYOFG1emnYEzMIdfkeyjy8fDCqdhENojrJ2K9E55Zd32f7Fuhhs1a MICV2RNr7RdwHsAPtoZ8ZYAB8gy7EcBF2zhhRIEtNJcXkFNquJBGjfZ77OGWLtSpJAcu 3B8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wwEZROVUGNrZD1551z/A8zmSWcOvD+bnaCjldQWQwYo=; b=N9Uld+Dhc7S15JCZ0popeHQW+xH3bbSyAq9FlF7posV0OpF5VbcdVMvr/uKbSI3zQK 1CpPhbMEfvUKVzETxRaNZu37Gjf/HEnNcaJfJzBKnFQjiA/i3pa6ssuMOyK1mYcb2UcS 3DX0NVrS8ToxMbiFPuRYPF4eRuSphlghOM+wvAQknaZpSVUFUQfv9XXt/Qh8Y0Nzikxz 6MYJjmr4NNwJ6FNhDBf0OA+FvW5BgJMhDfF1jzmnsz+rNA/23vN5D42sI8F7p0T+OvS7 FSw0YAapwXHknK6Hv56vSsqIc8HGtZQIaWpG8YP+e9xO05U8orC0nlpykvs/J1BAd+2s xNKw== X-Gm-Message-State: APzg51D1sJWaErpMpVL/GPSHYeADoMoJ8ecH9DK9Gqx+FTubcANFLZrw MUYwa0Fbzr18s9cnYT/xBZI= X-Google-Smtp-Source: ANB0VdY4Fl5+3fuxhh3IuekDCLHPyIOmG4xkZUZ34wY9qQswXxz/oZYZKobOFPDgHBIQB6JrOKGOFw== X-Received: by 2002:a63:e40d:: with SMTP id a13-v6mr7379876pgi.289.1536847880430; Thu, 13 Sep 2018 07:11:20 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id e26-v6sm5225665pfi.70.2018.09.13.07.11.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Sep 2018 07:11:19 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Eric Dumazet References: <153670437243.12756.693381878569982309.stgit@alrua-kau> From: Eric Dumazet Message-ID: <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> Date: Thu, 13 Sep 2018 07:11:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <153670437243.12756.693381878569982309.stgit@alrua-kau> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 14:11:21 -0000 On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: > When splitting a GSO segment that consists of encapsulated packets, the > skb->mac_len of the segments can end up being set wrong, causing packet > drops in particular when using act_mirred and ifb interfaces in > combination with a qdisc that splits GSO packets. > > This happens because at the time skb_segment() is called, network_header > will point to the inner header, throwing off the calculation in > skb_reset_mac_len(). The network_header is subsequently adjust by the > outer IP gso_segment handlers, but they don't set the mac_len. > > Fix this by adding skb_reset_mac_len() calls to both the IPv4 and IPv6 > gso_segment handlers, after they modify the network_header. > > Signed-off-by: Toke Høiland-Jørgensen Looks good but I would have appreciated a thanks or something after the help I gave on this problem. Reviewed-by: Eric Dumazet