From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0A9433B29E; Sun, 3 Feb 2019 15:02:14 -0500 (EST) Received: by mail-lj1-x22a.google.com with SMTP id v15-v6so9881634ljh.13; Sun, 03 Feb 2019 12:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LIonltYZ5fI98IDxXp37WDbjF+dzozePjBmidB2Fuwg=; b=velGt+QaKlYboSVFBkYQgPGGZn8xAKGg5Ek11lckCFDDavA6dKoiSH7YbUdULfRNNd u7cjro7x6AD/qIHMcIRFdSMcgoPTaOZBhJxQ5FY432lHPI6PuNwPXkotUKs93vYQ6QKS Aqf1Z7dNoC4yEmII57OffLc85mcWxWxOqX4yfQNSY9DzSYrkMLMPsUw2OPy62vQYBfvh drQynwbuVvzthg9SyG5RpiNoB0IwLLZkLHR/y/PmeSos9BuwZq8kqy4DYvubTnhXsz5t mX10sxh6a01vNflDH/HBPLNPryU28wgkzd7BhYhN4JK0EsXypHqwLOK24N1I0CXabd+C lCWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LIonltYZ5fI98IDxXp37WDbjF+dzozePjBmidB2Fuwg=; b=qLzajAyHItEPGYJkWL5OYpckYNdYO2V2ronlUf4/XEwYwOBEFvUyX9WjJSG9JOrhgu 7FjbHJDOXZQCi2Erm7irOmdWzLRDGgbzwTvxbAyfitHY6G8bO7RGTNfvHohdy1oBt/KH TBRJpWl6lpF1K5+y9Lazx0k7KeTpaNqIQGrQeVqNh9Le9dCIKemVbNjyuEyA0e4P8V1u EqwBdxthEYOfUy5sH9+lBmk5QcVv7OJ5s+of+hDNyz9l6rQRSiHBdPfcPFmx62r6vs05 sr7ffHnLLk3SL2LKK5ky06ExIVjREn+4/qcVK93sbaLo/HwchZTUIHgpZ+N7xRKRYc1k 7HaA== X-Gm-Message-State: AJcUukcIBrCBQ3EImxZb4v93JaLpUpmqxE5jy2zKrM/qaCRW9GR0vy1g Axh1Mt0V6Gx7AsK4OOFanFA= X-Google-Smtp-Source: ALg8bN41pLREIJRZkBso2TU69KGKiVojx1j50UjJcDItRUV786bhOw6fPenXcWmEixfMGbyfQAblrg== X-Received: by 2002:a2e:9655:: with SMTP id z21-v6mr39257479ljh.136.1549224133798; Sun, 03 Feb 2019 12:02:13 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-233-163-nat-p.elisa-mobile.fi. [83.245.233.163]) by smtp.gmail.com with ESMTPSA id o14-v6sm2390557lji.70.2019.02.03.12.02.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Feb 2019 12:02:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: Date: Sun, 3 Feb 2019 22:02:11 +0200 Cc: cerowrt-devel , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <64FB4B3D-E94A-4F3E-81EE-52ED212736DC@gmail.com> References: To: Dave Taht X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] [Cerowrt-devel] https://tools.ietf.org/html/draft-ietf-tsvwg-le-phb-06 is in last call X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2019 20:02:15 -0000 > On 3 Feb, 2019, at 8:39 pm, Dave Taht wrote: >=20 > it's 000001 which I guess is: >=20 > diff --git a/sch_cake.c b/sch_cake.c > index 3a26db0..67263b3 100644 > --- a/sch_cake.c > +++ b/sch_cake.c > @@ -343,7 +343,7 @@ static const u8 diffserv4[] =3D { > }; >=20 > static const u8 diffserv3[] =3D { > - 0, 0, 0, 0, 2, 0, 0, 0, > + 0, 1, 0, 0, 2, 0, 0, 0, > 1, 0, 0, 0, 0, 0, 0, 0, > 0, 0, 0, 0, 0, 0, 0, 0, > 0, 0, 0, 0, 0, 0, 0, 0, >=20 > (or is that reversed? my big endian/little endian chops scuks, and > nobody modified the gen_cake_const tool to match what cake expects > now) That looks correct to me, though it should also be added to the other = Diffserv modes including a bulk tin. Fields in TCP/IP are all laid out = in "network order" which is most-significant bit/byte first, the same = way you'd *normally* write a number down. The TOS field can sometimes be confusing because the DSCP field is the = upper 6 bits and the ECN field the lower 2, and the BSD Sockets API = gives you the while byte to work with while DSCPs are quoted as just = their own 6 bits. So you have to shift the latter left two bits before = applying them to the former. - Jonathan Morton