Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Eric Dumazet" <eric.dumazet@gmail.com>,
	netdev@vger.kernel.org
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc
Date: Fri, 27 Apr 2018 06:44:11 -0700	[thread overview]
Message-ID: <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com> (raw)
In-Reply-To: <87in8c4vn7.fsf@toke.dk>



On 04/27/2018 06:38 AM, Toke Høiland-Jørgensen wrote:
> 
> Ah, right. Will fix.
> 
> Is it safe to dereference the iph pointer before calling
> pskb_may_pull()?

No, please take a look at ip_rcv() for a typical use case.


  reply	other threads:[~2018-04-27 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 12:17 Toke Høiland-Jørgensen
2018-04-27 12:17 ` [Cake] [PATCH iproute2-next v5] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-27 16:17   ` Stephen Hemminger
2018-04-27 13:17 ` [Cake] [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc Eric Dumazet
2018-04-27 13:38   ` Toke Høiland-Jørgensen
2018-04-27 13:44     ` Eric Dumazet [this message]
2018-04-27 13:45       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox