From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5B9BA3B29E for ; Fri, 27 Apr 2018 09:44:13 -0400 (EDT) Received: by mail-pg0-x22a.google.com with SMTP id i29-v6so1606720pgn.12 for ; Fri, 27 Apr 2018 06:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ECjLR25J+SRbx9clm52/SHC/mesIAhDaVKCfl+b23vo=; b=WZM7f0S0tTq2SwM/SR1GBUid6E5W201b02DpYnxiyIq3L89bwLrtHsYHmkqS1g9ZMo TU0HQ8/r1OnQktqnaJTSaZmfUUjZqaNB6vTDMd/vGIycgUCVwSJmRnttC/KEMoziZZnq ovBcZjjibYlOAzDQ+AbMdgp1pPK9O0fYukJRvi3r8k4V/OFu8RuOtggo5BWidx6oCfRA uBZO+8RLQj0yAB1xOYgbqY/HlkKSI4G+O3X7oUeL/OquBubnusFejsZxXLJtKW+hcTy1 NTavEi3QRjxOkEx/BA73b7N1+Kq9wOfwHb2S01apxK0Mhcjj3XUMPga1Hf68Wt4s/XyV 91Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ECjLR25J+SRbx9clm52/SHC/mesIAhDaVKCfl+b23vo=; b=V7AuvhldwRTMI9+LvbusbDkraXmDI3OFRwumLxQEtdzQ5FTF10LVb+9fGAt8Sld2y0 2iWN6UQ+/Uu3fwxL7hM5QdGr6UfdIRCxgp/nuw9g68mMy5hVxp2eYSMvHD/cYGK7rqKz UFdr+Q4G4mhDCwbj9UZccNoRpcfF8Ev13NA3o5NEzuX4B0Xth+vcr6KtIGPvKGZ6vfg3 Pqa2AffRXOSnHo7pRvxm5olsFFMZHXc14uq4dVry+8tncvCF1is/VjkfaLUBywpUOYOs 0ZcGSbm7d1rtPxuO61cjH8q4F5S+Z9bGWJPQS2f9EzC1h/AWnXTF3WUllZnWCR/Ygg2z t05g== X-Gm-Message-State: ALQs6tBIWxKD8h9XJ2zxqKKUKiDq4SJi/pBRoCksAduhdEk8guUUOGBo UJ+ky76jXVM3PZZ+720bxEM= X-Google-Smtp-Source: AB8JxZoBo6PR0yB9TOsnT1TloyWypp4TS18anA8xXHIj4k0/juOTbo5helFk7R8FTryILN/h0pD48g== X-Received: by 2002:a17:902:57c7:: with SMTP id g7-v6mr2375358plj.222.1524836652590; Fri, 27 Apr 2018 06:44:12 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id q75sm3502609pfj.94.2018.04.27.06.44.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 06:44:11 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht References: <20180427121706.23273-1-toke@toke.dk> <87in8c4vn7.fsf@toke.dk> From: Eric Dumazet Message-ID: <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com> Date: Fri, 27 Apr 2018 06:44:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87in8c4vn7.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 13:44:13 -0000 On 04/27/2018 06:38 AM, Toke Høiland-Jørgensen wrote: > > Ah, right. Will fix. > > Is it safe to dereference the iph pointer before calling > pskb_may_pull()? No, please take a look at ip_rcv() for a typical use case.