From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0047.outbound.protection.outlook.com [104.47.1.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B295B3B2A4 for ; Tue, 24 Apr 2018 04:11:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VaV+nFGJ/Bll98uMAs9Y0p5RynbhKOC1Y50s1TD89gA=; b=POw4YyE7Ik9tdEbGOcuJ4Oh9EL0Jx7LC4gD0XQAh5zdDjU+DifGpIhQqj7zG031nOKuPHL1AYXcykRXvW0ZHsUDAiR7yPiDONVeUFB0HOLe5cILLI36m7dHdTyml4jg2H8+YqTr+KY8s+YBkisLOILWkpLJpp32p994z3zU8t5U= Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com (52.133.51.23) by AM0PR0702MB3649.eurprd07.prod.outlook.com (52.133.50.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.715.7; Tue, 24 Apr 2018 08:11:33 +0000 Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::d5a9:6215:c302:c0f5]) by AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::d5a9:6215:c302:c0f5%5]) with mapi id 15.20.0715.015; Tue, 24 Apr 2018 08:11:33 +0000 From: Kevin Darbyshire-Bryant To: Jonathan Morton CC: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Cake List Subject: Re: [Cake] Testing variants of the MTU latency scaling Thread-Topic: [Cake] Testing variants of the MTU latency scaling Thread-Index: AQHT2nsPiuzUimNdsk6w4nVwzBHyUaQOHHwAgAAF9YCAAApmAIABZemA Date: Tue, 24 Apr 2018 08:11:33 +0000 Message-ID: <6B59CEAA-D5C0-44C6-81BD-C3F144F751C0@darbyshire-bryant.me.uk> References: <87a7tv3r5z.fsf@toke.dk> <5DB5443D-043B-44EF-B075-6D3E62D27D7A@gmail.com> <87vaciw7r4.fsf@toke.dk> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [2a02:c7f:1231:202b::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0702MB3649; 7:plJ60gG5y+N0Gi4MDogIbE4UOeuBnPSJa0A3t9THe6HThXkerOWNdAEaW6rE21Hc446lzuJoHVHCOVLtHqNQnUYroNZY94gFBI7I3XyyIgX+Y2io/7bXiO283vJegBoV590LaD8aUCsn6Sn19kcqW9onRD7B65BHXMl7DL22N8WcuwzQ6UhQFevllYi84CGR70wtu5jl1B2+XdW4uJD0OHNluG2OpnjJampZiMKYOx9F+8b8Wn114Gca9gJlG6Jy x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:AM0PR0702MB3649; x-ms-traffictypediagnostic: AM0PR0702MB3649: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231232)(944501410)(52105095)(3002001)(6041310)(20161123560045)(20161123562045)(20161123558120)(2016111802025)(20161123564045)(6043046)(6072148)(201708071742011); SRVR:AM0PR0702MB3649; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0702MB3649; x-forefront-prvs: 0652EA5565 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(376002)(39830400003)(366004)(396003)(54094003)(46003)(7736002)(6916009)(6436002)(81166006)(6116002)(8676002)(8936002)(74482002)(6486002)(82746002)(478600001)(14454004)(11346002)(229853002)(99936001)(33656002)(5660300001)(83716003)(2906002)(76176011)(54906003)(6512007)(316002)(6246003)(3660700001)(39060400002)(4326008)(305945005)(53936002)(186003)(6506007)(5250100002)(102836004)(3280700002)(53546011)(93886005)(1411001)(25786009)(2616005)(476003)(86362001)(36756003)(446003)(99286004)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0702MB3649; H:AM0PR0702MB3730.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:ovrnspm; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: pi/Ob3Ud2URYPywa1RtBYErdFh9Wn9cawl7wzeandUDySxqldsjsDUG+ai1ljzTqqYQffvEFMgJvS5BXDXxGBQ1uZ5gJl5FmdKARvrllmlCXhWsnapx0dCEyXyRJzBJweWWYxVZnnpa/TtvFuSNZKBk/JwvAJ4n/jeVjKsPTmTXYNw73bPnUpma0ZEPzmEvh spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_CD76D651-666D-4ACD-81D3-2A48C098FD15"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9af052cd-ffe0-48c2-c06c-08d5a9bafe2f X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 9af052cd-ffe0-48c2-c06c-08d5a9bafe2f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2018 08:11:33.5566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3649 X-List-Received-Date: Tue, 24 Apr 2018 08:11:36 -0000 --Apple-Mail=_CD76D651-666D-4ACD-81D3-2A48C098FD15 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 23 Apr 2018, at 11:50, Jonathan Morton = wrote: >=20 >> Right. Pushed the patch to the cobalt branch, feel free to fix it up = :) >=20 > Given that I basically had to revert 80% of it and start again, = perhaps not the best policy. Ha :-) cobalt_should_drop(&flow->cvars, &b->cparams, now, skb, b->bulk_flow_count * !!(q->rate_flags & = CAKE_FLAG_INGRESS) I like the conditional multiply (by 1) based on ingress mode, so we only = pass a non zero flow count in ingress mode only. Saves passing an = additional parameter which I disliked but could see no way around. I=E2=80=99m not sure that the replacement code in cobalt_should_drop = itself is an equivalent of what Toke tested in his many combinations: bool over_target =3D sojourn > p->target && ( sojourn > p->mtu_time * bulk_flows * 2 || sojourn > p->mtu_time * 4 ); So in egress mode the first part of the OR statement will always be true = (p->mtu_time * bulk_flows (0) * 2) is always 0, I=E2=80=99d like to = think sojourn will always be bigger than 0. So at run time it = simplifies to bool over_target =3D sojourn > p->target ingress mode is more interesting since bulk_flows is now non zero. sojourn > p->mtu_time * bulk_flows * 2 (I think in essence this is = =E2=80=98permit up to 2 outstanding MTU packets(time) per flow overall) = - this wasn=E2=80=99t tested OR sojourn > p->mtu_time * 4 ); (up to 4 MTU packets(time) on this flow = only) - this I believe was tested. and this particular combination of the two wasn=E2=80=99t tested. I = wonder if I could politely ask Toke to run his test on this version. I=E2=80=99m arguing/commenting from a position of ignorance and a double = migraine yesterday, so to say I=E2=80=99m foggy today is an = understatement! Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A --Apple-Mail=_CD76D651-666D-4ACD-81D3-2A48C098FD15 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlre5rUACgkQs6I4m53i M0r8IA//dldGtll8DyuDEkGaoyL5Lt4iAF94+8RGtTE6KkWK6wdxPiBgYoFPJuoP ubHIWZLV2olZmVw0KfwraAPq9luAwkvpokCc6KxAMe8jRO/MDudmg135mkUuYoPD 7BTlAultiRRGxc9aLreSZzGy2Rk9skdkbTx8+464+uRMOjogCv8qOSFhKqzIhQ/C 2pGheeQdAffzAI0q20YApqxdGPdSEybN2Anl1OR1YPzmoptXpo9nph46xtg6TkV8 GQc9yq13mFLLgT9wH7VPzW/RgqC0kXd1zCsZI4vSDsCgDEVin5GgeprEqk5+jvBG 3LhXi+oAakMos9RULPFruPViui2eXgWuSOvjmb1HhdlbXEv2GlvDvOQ2u9WzybqU wtSav1VrlyDD6+vLEp3ZuXl7Uf083UWA94Sgzx2dOnz7AbdVlkMQItEguBsw193u SNvgSvOqtqsaqwg3L4Pihop7gafI4IKOns6PDi6Jyvkll/C8/nSLMtBDKXVZ4CnJ T9e1EJv3Zkpm69qsPlEMRPCImpxXQauYyb8DTlPH9SH1Kl0c0m/UxN1J3fAEVYG8 ZTtkNDDL5tE0F2ij63tSlLxI6B/O3eB/NmMtQ6WSHZpstgOp+ct5xwEKjuZwXl0s vySPq0a1uu49BsgBE/cnqoiU2wpV6OYLLj99iaHtYF+qOjwOMkc= =g4zH -----END PGP SIGNATURE----- --Apple-Mail=_CD76D651-666D-4ACD-81D3-2A48C098FD15--